Skip to content

[NoQA] Convert code-inline-reviewer rules into proactive coding guidelines for Claude - #81604

Merged
Julesssss merged 13 commits into
Expensify:mainfrom
callstack-internal:feat/convert-ai-reviewer-rules-into-skill
Feb 13, 2026
Merged

Julesssss merged 13 commits into
Expensify:mainfrom
callstack-internal:feat/convert-ai-reviewer-rules-into-skill

Conversation

@kacper-mikolajczak

@kacper-mikolajczak kacper-mikolajczak commented Feb 5, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #81478
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@kacper-mikolajczak

Copy link
Copy Markdown
Contributor Author

CC @adhorodyski @mountiny

@adhorodyski

Copy link
Copy Markdown
Contributor

Let's wait with this PR until #81651 gets merged, should be EOD 🤞🏻

@adhorodyski

Copy link
Copy Markdown
Contributor

All good, feel free to resolve conflicts @kacper-mikolajczak

@kacper-mikolajczak
kacper-mikolajczak force-pushed the feat/convert-ai-reviewer-rules-into-skill branch from 9fc6e8a to 62488ac Compare February 10, 2026 01:20
@kacper-mikolajczak

kacper-mikolajczak commented Feb 10, 2026 •

Copy link
Copy Markdown
Contributor Author

Decisions

This approach tries to convert rules into abstracted form that can be picked up both during review and development. We are also improving the structure so it should be easier for reviewer not to loose context and carefully go through the rules (i.e. addition of to-do list during review).

  • Skill name: coding-standards — framed as best practices, not review-specific; reviewer is just one consumer
  • alwaysApply: true — SKILL.md is a lightweight index, cheap to always inject
  • Rule files:
    • Numbered filenames (perf-1-no-spread-in-renderitem.md) for ordering and cross-referencing
    • _ prefix convention to exclude non-rule files (e.g. _template.md)
    • Minimal frontmatter: only ruleId, title, searchPatterns
    • Structure: Reasoning → Incorrect → Correct → --- → Review Metadata
  • Rule extraction: YAML ruleId: field instead of regex on monolithic file (also fixed bug missing CLEAN-REACT-PATTERNS-*)
  • IDE integration: Cursor .mdc with globs: src/**/*.ts,src/**/*.tsx; Claude via alwaysApply + CLAUDE.md

What Was Done

  • Created:
    • .claude/skills/coding-standards/SKILL.md — index with category table + quick reference
    • .claude/skills/coding-standards/rules/ — 26 individual rule files + _template.md
    • .cursor/rules/expensify-code-review.mdc — Cursor IDE integration
  • Rewritten:
    • .claude/agents/code-inline-reviewer.md — 1722 → ~115 lines, references skill instead of embedding rules + has instructions to create an explicit to-do list of ingested rules to follow
    • .github/scripts/extractAllowedRules.sh — YAML frontmatter extraction instead of regex
  • Edited:
    • .github/workflows/claude-review.yml, CLAUDE.md, contributingGuides/STYLE.md, contributingGuides/philosophies/AI-REVIEWER.md — updated paths and references

This needs to be tested first in order not to fall into any critical regressions - I will create a testing PR tomorrow.

CC @adhorodyski @mountiny @Julesssss @tgolen @roryabraham

@kacper-mikolajczak

Copy link
Copy Markdown
Contributor Author

Conflicts resolved ✅

@kacper-mikolajczak
kacper-mikolajczak marked this pull request as ready for review February 10, 2026 01:53
@kacper-mikolajczak
kacper-mikolajczak requested review from a team and tgolen as code owners February 10, 2026 01:53
@melvin-bot
melvin-bot Bot requested review from eVoloshchak and removed request for a team February 10, 2026 01:53
@melvin-bot

melvin-bot Bot commented Feb 10, 2026

Copy link
Copy Markdown

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@kacper-mikolajczak kacper-mikolajczak changed the title Convert code-inline-reviewer rules into proactive coding guidelines for Claude [NoQA] Convert code-inline-reviewer rules into proactive coding guidelines for Claude Feb 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6907bf4cd7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/scripts/extractAllowedRules.sh Resolved
Comment thread .cursor/rules/expensify-code-review.mdc Resolved
Comment thread .claude/agents/code-inline-reviewer.md Resolved
Comment thread .claude/agents/code-inline-reviewer.md Resolved
Comment thread .claude/agents/code-inline-reviewer.md Resolved
Comment thread .claude/agents/code-inline-reviewer.md Resolved

@Julesssss Julesssss left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea here of pulling the best coding practices earlier into developers workflows, I'm just not sure about the approach currently. Some thoughts:

  • The searchPatterns are very wide and I'm not sure language such as Hardcoded numbers/strings works as a search pattern
  • Mentioning the rules in the main Claude file feels a bit bloaty, though the main Claude file does seem the best place for coding standards 😕
    • A preferable solution would pull relevant rules into context, rather than pulling all rules for each session, though this is easier said than done, obviously, and also bloats the memory
  • The skill description should describe when it should be triggered
  • alwaysApply pulls the rule details, but not the rule itself, not sure this will work automatically, without manually being told to check the rules
  • I still kinda think hooks might be preferable here. Or we put these rules in a more typical style file that Claude is simply prompted to review when preparing PRs

Would like to hear @thienlnam's thoughts on this too when he's back

@kacper-mikolajczak

Copy link
Copy Markdown
Contributor Author

The searchPatterns are very wide and I'm not sure language such as Hardcoded numbers/strings works as a search pattern

Agree! We've discussed it with @adhorodyski and I intend to look into with more depth as one of the next improvements. Let's keep them for now as they were not to introduce too much changes in one PR (we'd like to test moving rules into a skill in separation)

@kacper-mikolajczak

kacper-mikolajczak commented Feb 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Mentioning the rules in the main Claude file feels a bit bloaty, though the main Claude file does seem the best place for coding standards 😕

A preferable solution would pull relevant rules into context, rather than pulling all rules for each session, though this is easier said than done, obviously, and also bloats the memory

Currently, Claude only loads the SKILL description (based on three steps of progressive disclosure) so it won't pollute context much until it really needs relevant info. It skips alwaysApply directive, too.

For the Cursor case, which makes use of alwaysApply, I couldn't find proper information in the docs. Checked that in practice and Cursor seems to be respecting the three-layerd structure as well - curious of your experience with that guys.

Let me know if you have any specific idea of implementing this in mind.

alwaysApply pulls the rule details, but not the rule itself, not sure this will work automatically, without manually being told to check the rules

With proper rule description + reference guide inside SKILL, rules should be pulled consistently. As we've discussed recently, we are lacking consistent testing framework, so most of those are tested in practice - I will create testing PR to increase our confidence.

Skill has an advantage of progressive disclosure - if it's going to perform worse, then we can pivot to claude/rules approach, wdyt?

Thanks for the profound feedback @Julesssss! I applied/answered all the comments ❤️

CC @adhorodyski

@kacper-mikolajczak

Copy link
Copy Markdown
Contributor Author

Created a testing PR: #82206

This refactor does not introduce any new rules, so the testing PR consist of synthetic tests that should check we don't have any regressions compared to existing setup.

@mountiny @Julesssss asking kind souls to run that ❤️

@Julesssss

Copy link
Copy Markdown
Contributor

Ah I missed that the rules sit under the coding-standards skill folder, that's my bad. Agree in that case that context should be pulled correctly, assuming the skill is picked up. Also I see no noticeable extra context use with a clean Claude session which is good.

I am unfamiliar with Cursor, perhaps we can simply run some manual prompts against main and then this branch to verify?

Thanks for the test PR, let me modify the workflow and run a manual test tomorrow.

@kacper-mikolajczak

kacper-mikolajczak commented Feb 11, 2026 •

Copy link
Copy Markdown
Contributor Author

I am unfamiliar with Cursor, perhaps we can simply run some manual prompts against main and then this branch to verify?

@Julesssss I ran some "diagnostic" prompts (like <agent_skills> or context dump) and it seemed to contain only what's needed for further exploration. We will surely get higher confidence when people start using it.

@kacper-mikolajczak

kacper-mikolajczak commented Feb 12, 2026 •

Copy link
Copy Markdown
Contributor Author

let me modify the workflow and run a manual test tomorrow.

@Julesssss When ready, could you please link to the test workflow? Thanks!

In the meantime, I triggered current reviewer on the PR to check whether it picks up those violations, so we can compare with version from here.

Comment thread .claude/agents/code-inline-reviewer.md Resolved
@Julesssss

Copy link
Copy Markdown
Contributor

@Julesssss When ready, could you please link to the test workflow? Thanks!

Yep sorry, just got to this. In the end I just ran locally with apparent success:

  • No regressions in detections
  • CLEAN-REACT-PATTERNS were picked up, and weren't previously

Locally I see Claude has knowledge of the rules and retrieves the skill when asked about code rules. Not a perfect test, of course.

Screenshot 2026-02-12 at 15 36 54

@kacper-mikolajczak

Copy link
Copy Markdown
Contributor Author

Yep sorry, just got to this. In the end I just ran locally with apparent success

Awesome news @Julesssss! Thanks for running that.

We are ready to merge this 🚀

CC @mountiny

@Julesssss

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Julesssss
Julesssss merged commit a93a316 into Expensify:main Feb 13, 2026
16 of 17 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 16, 2026
51 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.20-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀

platform result
🕸 web 🕸 cancelled 🔪
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants