Skip to content

Revert "Allow edit input for SplitListItem when there is negative value" - #81632

Merged
mollfpr merged 1 commit into
Expensify:mainfrom
dukenv0307:revert-74189-fix-63311
Feb 6, 2026
Merged

mollfpr merged 1 commit into
Expensify:mainfrom
dukenv0307:revert-74189-fix-63311

Conversation

@dukenv0307

Copy link
Copy Markdown
Contributor

Reverts #74189

@melvin-bot

melvin-bot Bot commented Feb 6, 2026

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@codecov

codecov Bot commented Feb 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/AmountTextInput.tsx 100.00% <ø> (ø)
src/components/MoneyRequestAmountInput.tsx 1.92% <ø> (ø)
src/components/NumberWithSymbolForm.tsx 2.80% <ø> (+0.03%) ⬆️
...onList/ListItem/SplitListItem/SplitAmountInput.tsx 0.00% <ø> (ø)
...st/ListItem/SplitListItem/SplitPercentageInput.tsx 0.00% <ø> (ø)
...nput/BaseTextInput/implementation/index.native.tsx 77.61% <100.00%> (-0.11%) ⬇️
...s/TextInput/BaseTextInput/implementation/index.tsx 0.00% <ø> (ø)
src/libs/MoneyRequestUtils.ts 52.63% <100.00%> (-2.14%) ⬇️
...omponents/SelectionList/ListItem/SplitListItem.tsx 0.00% <0.00%> (ø)
src/libs/IOUUtils.ts 77.38% <91.66%> (-0.08%) ⬇️
... and 3 more
... and 6 files with indirect coverage changes

@mollfpr
mollfpr marked this pull request as ready for review February 6, 2026 17:27
@mollfpr
mollfpr requested review from a team as code owners February 6, 2026 17:27
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team February 6, 2026 17:27
@mollfpr
mollfpr self-requested a review February 6, 2026 17:27
@melvin-bot
melvin-bot Bot requested review from carlosmiceli and removed request for a team February 6, 2026 17:27
@melvin-bot

melvin-bot Bot commented Feb 6, 2026

Copy link
Copy Markdown

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mollfpr
mollfpr merged commit 9a472b1 into Expensify:main Feb 6, 2026
28 of 31 checks passed
@melvin-bot melvin-bot Bot added the Emergency label Feb 6, 2026
@melvin-bot

melvin-bot Bot commented Feb 6, 2026

Copy link
Copy Markdown

@mollfpr looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mollfpr mollfpr removed the Emergency label Feb 6, 2026
@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

@mollfpr

mollfpr commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Removing Emergency label. Straight revert.

@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b83719b33

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +138 to +142
useEffect(() => {
const errorString = getLatestErrorMessage(draftTransaction ?? {});

if (errorString) {
setErrorMessage(errorString);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear stale error message when draft errors are removed

The new effect only calls setErrorMessage when getLatestErrorMessage(...) returns a truthy string, so if draftTransaction.errors is cleared (e.g., after a retry or clearSplitTransactionDraftErrors that doesn’t change the split amounts), errorMessage is never reset and the banner can keep showing a stale error. Consider clearing errorMessage when errorString is falsy or deriving the display text directly from draftTransaction so it stays in sync with Onyx.

Useful? React with 👍 / 👎.

OSBotify pushed a commit that referenced this pull request Feb 6, 2026
Revert "Allow edit input for SplitListItem when there is negative value"

(cherry picked from commit 9a472b1)

(cherry-picked to staging by Julesssss)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Feb 6, 2026
@OSBotify

OSBotify commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.15-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.16-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants