Repository navigation
Revert "Allow edit input for SplitListItem when there is negative value" - #81632
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mollfpr looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
Removing |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b83719b33
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| useEffect(() => { | ||
| const errorString = getLatestErrorMessage(draftTransaction ?? {}); | ||
|
|
||
| if (errorString) { | ||
| setErrorMessage(errorString); |
There was a problem hiding this comment.
Clear stale error message when draft errors are removed
The new effect only calls setErrorMessage when getLatestErrorMessage(...) returns a truthy string, so if draftTransaction.errors is cleared (e.g., after a retry or clearSplitTransactionDraftErrors that doesn’t change the split amounts), errorMessage is never reset and the banner can keep showing a stale error. Consider clearing errorMessage when errorString is falsy or deriving the display text directly from draftTransaction so it stays in sync with Onyx.
Useful? React with 👍 / 👎.
Revert "Allow edit input for SplitListItem when there is negative value" (cherry picked from commit 9a472b1) (cherry-picked to staging by Julesssss)
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.15-4 🚀
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.16-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀
|
Reverts #74189