Refine category receipt itemized interaction by abzokhattab · Pull Request #81917 · Expensify/App

abzokhattab · 2026-02-10T00:30:32Z

Explanation of Change

This PR refines the interaction between the "Receipt Required" and "Itemized Receipt Required" category rule settings by introducing cascading logic:

When Receipt Required is set to Never for a category, Itemized Receipt Required is automatically also set to Never (it doesn't make sense to require an itemized receipt if no receipt is required at all).
When Itemized Receipt Required is set to Always for a category, Receipt Required is automatically also set to Always (an itemized receipt implies a receipt is needed).

A new joint API command SetPolicyCategoryReceiptsAndItemizedReceiptRequired is used for these two cascading cases to update both settings in a single call (maintaining the 1:1:1 pattern). All other non-cascading selections continue to use the existing individual commands. Policy-level receipt settings are not affected.

Fixed Issues

$ #81713
PROPOSAL:

Tests

Cascade: Receipt Required → Never also sets Itemized Receipt to Never

Go to a workspace > Categories > select a category > Category Rules
Set "Require itemized receipts over" to Always
Set "Require receipts over" to Never
Verify that "Require itemized receipts over" is automatically switched to Never

Cascade: Itemized Receipt Required → Always also sets Receipt Required to Always

Go to a workspace > Categories > select a category > Category Rules
Set "Require receipts over" to Never
Set "Require itemized receipts over" to Always
Verify that "Require receipts over" is automatically switched to Always

No cascade for other selections

Go to a workspace > Categories > select a category > Category Rules
Set "Require receipts over" to Always — verify "Require itemized receipts over" is not changed
Set "Require itemized receipts over" to Never — verify "Require receipts over" is not changed
Set "Require receipts over" to Default — verify "Require itemized receipts over" is not changed
Set "Require itemized receipts over" to Default — verify "Require receipts over" is not changed

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-03-03.at.18.32.24.mov

Android: mWeb Chrome

Screen.Recording.2026-03-03.at.18.39.08.mov

iOS: Native

Screen.Recording.2026-03-03.at.18.27.25.mov

iOS: mWeb Safari

Screen.Recording.2026-03-03.at.18.29.47.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-03.at.18.22.11.mov

Screen.Recording.2026-03-03.at.18.25.22.mov

codecov · 2026-02-10T00:37:19Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/actions/Policy/Category.ts	`48.36% <100.00%> (+1.56%)`	⬆️
...gories/CategoryRequireItemizedReceiptsOverPage.tsx	`0.00% <0.00%> (ø)`
...ace/categories/CategoryRequireReceiptsOverPage.tsx	`0.00% <0.00%> (ø)`
... and 16 files with indirect coverage changes

Replace two separate API calls with the new SetPolicyCategoryReceiptsAndItemizedReceiptRequired command when: - Receipt Required is set to Never (cascades itemized to Never) - Itemized Receipt Required is set to Always (cascades receipt to Always)

…pt-itemized-receipt-interaction

Tests both cascading directions of the joint API command: - Receipt Required → Never cascades Itemized Receipt → Never - Itemized Receipt Required → Always cascades Receipt Required → Always

melvin-bot · 2026-03-02T20:19:49Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…pt-itemized-receipt-interaction

ShridharGoel · 2026-03-03T17:40:07Z

@abzokhattab Is this ready for review? Asking since title still mentions "WIP"

…pt-itemized-receipt-interaction

abzokhattab · 2026-03-03T17:42:16Z

now its ready for review

ShridharGoel · 2026-03-03T19:40:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-04.at.1.07.02.AM.mov

Android: mWeb Chrome

Screen.Recording.2026-03-04.at.1.09.47.AM.mov

iOS: HybridApp

Screen.Recording.2026-03-04.at.1.05.32.AM.mov

iOS: mWeb Safari

Screen.Recording.2026-03-04.at.1.08.47.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-04.at.12.56.31.AM.mov

trjExpensify · 2026-03-04T15:33:07Z

@heyjennahay I'm going to switch you on for this PR as it's your project. 👍

heyjennahay

LGTM

…eraction

…-category-receipt-itemized-receipt-interaction # Conflicts: # src/libs/API/parameters/index.ts

dangrous

LGTM!

OSBotify · 2026-03-11T19:05:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-11T19:34:06Z

🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-11T19:41:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81917.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cca2e2a-47a1081-f435c44e450bd36b0041a0df043d01e3ee044215/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cca2e2a-47a1081-4ce67aad99cbbbe7b3f252186ee4456a0557656b/index.html

Web 🕸️
https://81917.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-11T20:04:03Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.36-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-12T22:48:44Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Refine category receipt itemized interaction

52c3e34

melvin-bot Bot assigned abzokhattab Feb 10, 2026

abzokhattab mentioned this pull request Feb 10, 2026

[Due for payment 2026-03-19] Refine interaction between category receipt and itemized receipt requirements #81713

Closed

abzokhattab added 3 commits March 2, 2026 20:58

Merge remote-tracking branch 'origin/main' into refine-category-recei…

d604265

…pt-itemized-receipt-interaction

Add unit tests for setPolicyCategoryReceiptsAndItemizedReceiptRequired

1962993

Tests both cascading directions of the joint API command: - Receipt Required → Never cascades Itemized Receipt → Never - Itemized Receipt Required → Always cascades Receipt Required → Always

abzokhattab changed the title ~~Refine category receipt itemized interaction~~ WIP: Refine category receipt itemized interaction Mar 2, 2026

abzokhattab marked this pull request as ready for review March 2, 2026 20:19

abzokhattab requested review from a team as code owners March 2, 2026 20:19

melvin-bot Bot requested review from ShridharGoel and removed request for a team March 2, 2026 20:19

melvin-bot Bot requested review from trjExpensify and removed request for a team March 2, 2026 20:19

Merge remote-tracking branch 'origin/main' into refine-category-recei…

62e5fcf

…pt-itemized-receipt-interaction

Merge remote-tracking branch 'origin/main' into refine-category-recei…

c2ccec2

…pt-itemized-receipt-interaction

abzokhattab changed the title ~~WIP: Refine category receipt itemized interaction~~ Refine category receipt itemized interaction Mar 3, 2026

ShridharGoel approved these changes Mar 3, 2026

View reviewed changes

melvin-bot Bot requested a review from dangrous March 3, 2026 19:40

trjExpensify requested review from heyjennahay and removed request for trjExpensify March 4, 2026 15:33

heyjennahay previously approved these changes Mar 6, 2026

View reviewed changes

abzokhattab added 2 commits March 10, 2026 21:33

Merge branch 'main' into refine-category-receipt-itemized-receipt-int…

eaaa20b

…eraction

Merge branch 'main' of https://github.com/abzokhattab/App into refine…

9fe30e3

…-category-receipt-itemized-receipt-interaction # Conflicts: # src/libs/API/parameters/index.ts

abzokhattab dismissed heyjennahay’s stale review via 9fe30e3 March 10, 2026 20:39

dangrous approved these changes Mar 11, 2026

View reviewed changes

dangrous merged commit cca2e2a into Expensify:main Mar 11, 2026
30 checks passed

OSBotify mentioned this pull request Mar 11, 2026

Deploy Checklist: New Expensify 2026-03-11 #84953

Closed

MelvinBot mentioned this pull request Mar 12, 2026

[Due for payment 2026-03-19] Report - Cancel payment doesn't work and leads to blank page #85019

Closed

1 of 7 tasks

Conversation

abzokhattab commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Feb 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Mar 2, 2026

Uh oh!

ShridharGoel commented Mar 3, 2026

Uh oh!

abzokhattab commented Mar 3, 2026

Uh oh!

ShridharGoel commented Mar 3, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

trjExpensify commented Mar 4, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 11, 2026

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

OSBotify commented Mar 11, 2026

Uh oh!

OSBotify commented Mar 12, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

abzokhattab commented Feb 10, 2026 •

edited

Loading

codecov Bot commented Feb 10, 2026 •

edited by github-actions Bot

Loading