Repository navigation
Update the copy for rate error duplications - #82288
Conversation
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 0b25d0a8..2edfdea6 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1516,7 +1516,7 @@ const translations: TranslationDeepObject<typeof en> = {
ratePreview: (rate: string) => `${rate} / Stunde`,
amountTooLargeError: 'Der Gesamtbetrag ist zu hoch. Verringere die Stunden oder reduziere den Satz.',
},
- correctRateError: 'Behebe den Fehler beim Entfernungssatz und versuche es erneut.',
+ correctRateError: 'Behebe den Kursfehler und versuche es erneut.',
AskToExplain: `. <a href="${CONST.CONCIERGE_EXPLAIN_LINK_PATH}"><strong>Erklären</strong></a> ✨`,
policyRulesModifiedFields: {
reimbursable: (value: boolean) => (value ? 'hat die Ausgabe als „erstattungsfähig“ markiert' : 'hat die Ausgabe als „nicht erstattungsfähig“ markiert'),
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 00ad8a8d..a7350c25 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1522,7 +1522,7 @@ const translations: TranslationDeepObject<typeof en> = {
ratePreview: (rate: string) => `${rate} / heure`,
amountTooLargeError: 'Le montant total est trop élevé. Réduisez le nombre d’heures ou diminuez le taux.',
},
- correctRateError: 'Corrigez l’erreur de taux de distance, puis réessayez.',
+ correctRateError: 'Corrigez l’erreur de taux et réessayez.',
AskToExplain: `. <a href="${CONST.CONCIERGE_EXPLAIN_LINK_PATH}"><strong>Expliquer</strong></a> ✨`,
policyRulesModifiedFields: {
reimbursable: (value: boolean) => (value ? 'a marqué la dépense comme « remboursable »' : 'a marqué la dépense comme « non remboursable »'),
diff --git a/src/languages/it.ts b/src/languages/it.ts
index cd1346d7..20a7a5cc 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1513,7 +1513,7 @@ const translations: TranslationDeepObject<typeof en> = {
ratePreview: (rate: string) => `${rate} / ora`,
amountTooLargeError: 'L’importo totale è troppo alto. Riduci le ore o abbassa la tariffa.',
},
- correctRateError: 'Correggi l’errore nella tariffa distanza e riprova.',
+ correctRateError: 'Correggi l’errore di tariffa e riprova.',
AskToExplain: `. <a href="${CONST.CONCIERGE_EXPLAIN_LINK_PATH}"><strong>Spiega</strong></a> ✨`,
policyRulesModifiedFields: {
reimbursable: (value: boolean) => (value ? 'ha contrassegnato la spesa come "rimborsabile"' : 'ha contrassegnato la spesa come "non rimborsabile"'),
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 00f883b3..750fafab 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1507,7 +1507,7 @@ const translations: TranslationDeepObject<typeof en> = {
ratePreview: (rate: string) => `${rate} / 時間`,
amountTooLargeError: '合計金額が大きすぎます。時間を減らすか、レートを下げてください。',
},
- correctRateError: '距離レートのエラーを修正して、もう一度お試しください。',
+ correctRateError: 'レートのエラーを修正して、もう一度お試しください。',
AskToExplain: `. <a href="${CONST.CONCIERGE_EXPLAIN_LINK_PATH}"><strong>説明</strong></a> ✨`,
policyRulesModifiedFields: {
reimbursable: (value: boolean) => (value ? '経費を「精算対象」としてマークしました' : '経費を「非精算」としてマークしました'),
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 65cde8e2..2c8a66ab 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1512,7 +1512,7 @@ const translations: TranslationDeepObject<typeof en> = {
ratePreview: (rate: string) => `${rate} / uur`,
amountTooLargeError: 'Het totale bedrag is te hoog. Verlaag het aantal uren of verlaag het tarief.',
},
- correctRateError: 'Los het foutieve afstandstarief op en probeer het opnieuw.',
+ correctRateError: 'Herstel de koersfout en probeer het opnieuw.',
AskToExplain: `. <a href="${CONST.CONCIERGE_EXPLAIN_LINK_PATH}"><strong>Uitleggen</strong></a> ✨`,
policyRulesModifiedFields: {
reimbursable: (value: boolean) => (value ? 'heeft de uitgave gemarkeerd als „vergoedbaar”' : 'markeerde de uitgave als ‘niet-terugbetaalbaar’'),
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 5bdec84b..3d5a4b8c 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1511,7 +1511,7 @@ const translations: TranslationDeepObject<typeof en> = {
ratePreview: (rate: string) => `${rate} / godzinę`,
amountTooLargeError: 'Łączna kwota jest zbyt wysoka. Zmniejsz liczbę godzin lub obniż stawkę.',
},
- correctRateError: 'Napraw błąd stawki za dystans i spróbuj ponownie.',
+ correctRateError: 'Napraw błąd stawki i spróbuj ponownie.',
AskToExplain: `. <a href="${CONST.CONCIERGE_EXPLAIN_LINK_PATH}"><strong>Wyjaśnij</strong></a> ✨`,
policyRulesModifiedFields: {
reimbursable: (value: boolean) => (value ? 'oznaczył(a) wydatek jako „podlegający zwrotowi”' : 'oznaczył(a) wydatek jako „niepodlegający zwrotowi”'),
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 04cddca8..bbce39e2 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1509,7 +1509,7 @@ const translations: TranslationDeepObject<typeof en> = {
ratePreview: (rate: string) => `${rate} / hora`,
amountTooLargeError: 'O valor total é muito alto. Diminua as horas ou reduza a tarifa.',
},
- correctRateError: 'Corrija o erro na taxa de distância e tente novamente.',
+ correctRateError: 'Corrija o erro de taxa e tente novamente.',
AskToExplain: `. <a href="${CONST.CONCIERGE_EXPLAIN_LINK_PATH}"><strong>Explicar</strong></a> ✨`,
policyRulesModifiedFields: {
reimbursable: (value: boolean) => (value ? 'marcou a despesa como "reembolsável"' : 'marcou a despesa como “não reembolsável”'),
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 40097994..01f6f4c0 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1487,7 +1487,7 @@ const translations: TranslationDeepObject<typeof en> = {
ratePreview: (rate: string) => `${rate} / 小时`,
amountTooLargeError: '总金额过大。请减少工时或降低费率。',
},
- correctRateError: '修复距离费率错误后请重试。',
+ correctRateError: '修复费率错误后重试。',
AskToExplain: `。<a href="${CONST.CONCIERGE_EXPLAIN_LINK_PATH}"><strong>说明</strong></a> ✨`,
policyRulesModifiedFields: {
reimbursable: (value: boolean) => (value ? '已将该报销单标记为“可报销”' : '将该报销单标记为“不可报销”'),
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@jjcoffee could you add a checklist please? |
|
@JS00001 let me do the checklist |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-14.at.00.57.49.android.movAndroid: mWeb ChromeScreen.Recording.2026-02-14.at.00.53.35.android.c.moviOS: HybridAppScreen.Recording.2026-02-14.at.01.05.23.moviOS: mWeb SafariScreen.Recording.2026-02-14.at.00.59.17.ios.s.movMacOS: Chrome / SafariScreen.Recording.2026-02-14.at.00.51.29.web.mov |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Bug fix. Product behavior still in line with spec.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.20-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.20-6 🚀
|
Explanation of Change
We show the 'Fix the rate error' message for both per-diem and distance expenses, so we should not specify 'distance' for per-diem expenses. Lets make this message more generic
Fixed Issues
$ #82275
Tests
Create a per-diem expense
Delete all per-diem rates from the policy
Try to duplicate the expense
Ensure that the message says 'Fix the rate error and try again', and does not mention 'Distance'
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos