Repository navigation
Delete user MENTIONWHISPER when ADDCOMMENT is deleted #82720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
af2c7d0
Include 'deleted' in considering if a whisper is resolved
deetergp f14c9ae
Add a test to cover deleted marking whispers resolved
deetergp 11482d9
ESLint fix
deetergp 20be867
Include reportID
deetergp e7a4f2c
Update the comment to better explain what we're testing
deetergp c72739f
Merge branch 'main' into scott-deleteMentionWithAddComment
deetergp 78b64e7
Optimistically delete the mention whisper
deetergp 97fb8aa
TypeScript Checker fix
deetergp 10b7697
Merge branch 'main' into scott-deleteMentionWithAddComment
deetergp 957af9d
Optimistically hide actionable whisper when parent comment is deleted
deetergp 0595ce5
Add a test for offline deletion
deetergp 90d3ff2
ESLint fix
deetergp 20a9f90
Wrap whisper in getOriginalMessage
deetergp 6b765ca
Merge branch 'main' into scott-deleteMentionWithAddComment
deetergp 902943d
Make array of unresolved whisper IDs to delete
deetergp 3507c30
Add test for when multiple unresolved whispers present
deetergp 85a0d13
ESLint fixes
deetergp 2e1b218
Merge branch 'main' into scott-deleteMentionWithAddComment
deetergp 54aae53
Pass the report action for reverse checking deleted status
deetergp f7600a5
Add a test to ensure past whisper stays visible
deetergp fb54737
Pass all report actions to shouldReportActionBeVisible
deetergp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR missed a case (#86084). The offset-based whisper lookup only checks
parentID + 1andparentID + 2to find associated whispers. This works for whispers created on initial send, but when a message is edited to add a new mention, the backend creates a new whisper with a random ID (since the+1slot is already taken). These edit-created whispers are missed by both the optimistic deletion and theisResolvedActionableWhispervisibility check, which uses the reverse offset (whisperID - 1) to find the parent.Fix: #86264