Repository navigation
Attachments carousel loading optimizations #83185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cristipaval
merged 9 commits into
Expensify:main
from
callstack-internal:callstack-internal/szymonzalarski/attachments/images-load-extremely-slow-when-viewing-in-the-app-fix
Feb 25, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bfdc21b
Fix blank attachment preview on Android
szymonzalarski98 d34def9
Fix page fallback logic in Lightbox component to default to page 0 wh…
szymonzalarski98 28deb8e
Re-run CI checks
szymonzalarski98 e22ed5f
Merge remote-tracking branch 'origin/main' into callstack-internal/sz…
szymonzalarski98 7c9d7de
Re-run CI checks
szymonzalarski98 7afaaca
Re-run perf tests
szymonzalarski98 22cda9b
Re-run perf tests
szymonzalarski98 657db27
Merge branch 'main' into callstack-internal/szymonzalarski/attachment…
szymonzalarski98 a23ab8e
Re-run perf tests
szymonzalarski98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
findIndexcan return-1here when the current attachment is not present inpagerItems(for example on web carousels where the context only provides a singlesourceentry). In that case this component treats the visible item as inactive, andisImageLoadedshort-circuits totrue, so the loading indicator is skipped and users can see a blank frame until the image finishes loading. Please handle the-1case explicitly (e.g., fallback toactivePage/0) before deriving active/loading state.Useful? React with 👍 / 👎.