Repository navigation
fix: update the 2fa screen mapping screen #83552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b4425f8
fix: update the 2fa screen mapping screen
truph01 49b90db
fix: go back issue
truph01 364600d
fix: lint
truph01 1e928a1
fix: conflicts
truph01 436a76a
fix: conflicts
truph01 80b6a58
fix: address AI comment
truph01 a164072
fix: lint
truph01 16762b1
Merge branch 'Expensify:main' into fix/81694
truph01 1cef00a
merge main
truph01 0a63ac3
Merge branch 'Expensify:main' into fix/81694
truph01 19af15a
Merge branch 'Expensify:main' into fix/81694
truph01 c280a3b
fix: handle unvalidated case
truph01 19be517
Merge branch 'Expensify:main' into fix/81694
truph01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to do it without a dependency on backTo? Since we are moving away from the usage of backTo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShridharGoel I think we can remove the
backToparam on this screen by following the “separating routes for each screen instance” guideline:https://github.com/Expensify/App/blob/main/contributingGuides/NAVIGATION.md#separating-routes-for-each-screen-instance
However, since the
backToparam for this screen is also used in other places, do you think it would be better to perform that refactor in a separate PR?For this PR, we could focus only on fixing the navigation logic, and then address the
backToremoval and route separation as a follow-up to keep the scope smaller.