Repository navigation
Conversation
When the app is reloaded while a receipt/odometer preview is open during the expense creation flow, the draft transaction is not available. Instead of showing a not-found page, dismiss the modal so the user lands on the home page. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
|
@MelvinBot Close this PR |
Contributor
Author
|
PR closed as requested by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When the app is reloaded while a receipt or odometer preview is open during the expense creation flow (before a recipient is chosen), the
TransactionReceiptModalContentcomponent shows a not-found page because the draft transaction is unavailable after reload.This PR adds a
useEffectthat detects whenisDraftTransactionistruebut the draft transaction data has been loaded and is not available (i.e., the OnyxTRANSACTION_DRAFTkey resolved with no data). In this case, instead of rendering the not-found page, the modal is dismissed viaNavigation.dismissModal(), returning the user to the home page. This is consistent with how other expense types handle the reload case — draft preview data has no persisted state, so there is nothing to restore.The effect waits for the Onyx
statusto be'loaded'before acting, preventing false positives during the initial data loading phase.Fixed Issues
$ #81901
PROPOSAL: #81901 (comment)
Tests
Offline tests
N/A — This fix addresses app reload behavior. Offline state does not affect the draft transaction availability check on reload.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari