Repository navigation
Use LHN report count for focus mode auto-switch threshold #84074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f9c299d
Fix: Memoize PriorityModeController to prevent excessive re-renders
MelvinBot 696a92c
Fix: Resolve ESLint errors in PriorityModeController
MelvinBot 5be98a6
Fix: Add missing currentUserLogin to callGetOptionData test helper
MelvinBot 278457b
Restore PriorityModeController to initial PR state
MelvinBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelvinBot Why is this no longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
!accountIDguard was previously needed because this component usedaccountIDto computevalidReportCount— specifically inisReportParticipant(accountID ?? CONST.DEFAULT_NUMBER_ID, report). Without a validaccountID, the count would be wrong.Now that we use
orderedReportIDs.lengthfromuseSidebarOrderedReportsState(),accountIDis no longer used anywhere in this component. The sidebar context already handles user-specific filtering internally (it only populates with reports for the logged-in user), so there's no need to independently guard onaccountIDhere.