Repository navigation
[No QA] Add reasonAttributes to OptionsListSkeletonView usage sites - #84396
youssef-lr merged 4 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
| if (shouldShowLoadingPlaceholder) { | ||
| return customLoadingPlaceholder ?? <OptionsListSkeletonView shouldStyleAsTable={shouldUseUserSkeletonView} />; | ||
| const reasonAttributes: SkeletonSpanReasonAttributes = { | ||
| context: 'BaseSelectionList', |
There was a problem hiding this comment.
This is generic, but context is supposed to identify where this is rendered. Because this is a shared component, every caller will now emit the same value, so Sentry still won’t identify which actual screen is stuck. Is that expected?
There was a problem hiding this comment.
From one perspective you're right and this is the right way to do it. From the second point of view this would drastically enlarge the PR and at some point half of the application would have to pass this attribute.
I vote for not doing this as the golden mean between readability (we have these params everywhere) and sanity (we don't overwhelm the codebase with params needed only for observability). We can always change this later if we see problem with this exact component. WDYT?
There was a problem hiding this comment.
Yeah I think we can keep it as BaseSelectionList
|
Looks like we have conflicts |
|
@youssef-lr merge conflicts resolved |
|
🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.36-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
Explanation of Change
Added
reasonAttributesto all usage sites ofOptionsListSkeletonViewso Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.Part of #81683
Fixed Issues
$ #83397
PROPOSAL:
Tests
Offline tests
N/A — this change only adds telemetry metadata, no behavioral changes
QA Steps
N/A — this change only adds telemetry metadata, no behavioral changes
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari