Skip to content

Add increased distance violation display - #84453

Merged
neil-marcellini merged 25 commits into
mainfrom
neil-marcellini/add-modifiedDistance-violation
Mar 26, 2026
Merged

neil-marcellini merged 25 commits into
mainfrom
neil-marcellini/add-modifiedDistance-violation

Conversation

@neil-marcellini

@neil-marcellini neil-marcellini commented Mar 6, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Auth generates an increasedDistance violation when a user manually increases a distance expense beyond the calculated route. OldDot already displayed it, but NewDot silently ignored it.

This PR adds NewDot support by registering the violation in CONST.VIOLATIONS, mapping it to the waypoints field in useViolations, adding a translation case in ViolationsUtils.getViolationTranslation() that formats the original route distance, and passing routeDistanceMeters/distanceUnit from the transaction's customUnit through to all violation display sites (MoneyRequestView, MoneyRequestReceiptView, TransactionPreviewContent, ViolationMessages).

Related Issues

https://github.com/Expensify/Expensify/issues/605320

Tests

OldDot and NewDot - increase distance after creation

  1. Sign in on OldDot expensify.com.dev/settings
  2. Create a collect workspace if needed
  3. Create a distance expense from the map with any waypoints
  4. Save the expense
  5. Note the distance, then update the field to a larger value
  6. Open the expense report
  7. Verify there is a violation that says "Distance exceeds the calculated route of 10.46 km.", where the last part has the proper distance and unit that was initially calculated for the route
  8. Open NewDot dev.new.expensify.com:8082
  9. Open the policy expense chat and the report. Note that the violation won't currently live update. It will be implemented in this internal follow up issue.
  10. Got back to the policy expense chat
  11. Verify the expense preview displays "Review required" since the violation is too long to display there
  12. Open the single expense report
  13. Verify the expense view displays the violation properly
  14. Add an expense to the report
  15. Verify the multi-expense report view displays the violation properly
  16. Verify the distance is not editable from NewDot (matches behavior on main)
  17. On OldDot edit the distance for the expense with the violation below what it was originally calculated as
  18. Verify the violation disappears
  19. Go back to the NewDot tab and re-open the report.
  20. Verify the violation no longer appears
2026-03-10_16-44-15.mp4

OldDot only - increase distance after creation

  1. Sign in with a new account on expensify.com.dev
  2. When you are redirected to new Expensify, go to Account > Troubleshoot and choose Switch to Expensify Classic
  3. Create a control workspace
  4. Go to the workspace settings
  5. Set the policy as not expense chat enabled by opening the JS console and entering the following
const policy = Policy.getActive();
policy.policy.isPolicyExpenseChatEnabled = false;
policy.save();
  1. Run the test above but only the OldDot steps
2026-03-12_15-21-32.mp4

OldDot and NewDot - increase distance before creation

  1. Create a distance expense from map on OldDot
  2. Save the map
  3. Before saving the expense, increase the distance
  4. Save the expense
  5. Open the expense report
  6. Verify the violation displays on that expense
  7. Open the report in NewDot and verify the violation displays there too
2026-03-11_13-30-52.mp4

OldDot only - increase distance before creation

  1. Sign in to the account with a policy that is not expense chat enabled
  2. Run the test above but only the OldDot steps
2026-03-12_15-25-16.mp4

OldDot only - changing distance unit

  1. Create a distance expense from the map and save it.
  2. Change the distance unit of the policy from miles to kilometers.
  3. Verify the distance of the expense still displays in the original unit of 'mi'
  4. Update the distance above the original converted value
  5. Open the report
  6. Verify a violation appears explaining that the distance exceeds the original route
  7. Verify the violation shows the distance in the original distance unit of 'mi'
  8. Reduce the distance below the original value
  9. Verify the violation is removed

Note: Updating distance expenses between OldDot and NewDot is currently a bit buggy, so we only test on OldDot. For example see this internal issue OldDot distance edit breaks future NewDot waypoint updates.

2026-03-12_16-58-17.mp4
  • Verify that no errors appear in the JS console

Offline tests

N/A - Violations are fetched from the server; offline behavior is unchanged.

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

See the tests above on mac Chrome. I only tested on one platform because the changes should be platform independent. C+ will test all platforms.

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Made with Cursor

The modifiedDistance violation is generated by Auth when a distance expense
is manually increased beyond the calculated route, but NewDot was not
displaying it because the violation name was missing from the client-side
translation system.

Made-with: Cursor
@neil-marcellini
neil-marcellini requested review from a team as code owners March 6, 2026 20:31
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and arosiclair and removed request for a team March 6, 2026 20:32
@melvin-bot

melvin-bot Bot commented Mar 6, 2026

Copy link
Copy Markdown

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team March 6, 2026 20:32
@OSBotify

This comment has been minimized.

@neil-marcellini
neil-marcellini marked this pull request as draft March 6, 2026 20:36
@codecov

codecov Bot commented Mar 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 95.20% <ø> (ø)
...nents/ReportActionItem/MoneyRequestReceiptView.tsx 69.85% <ø> (ø)
...m/TransactionPreview/TransactionPreviewContent.tsx 77.08% <ø> (ø)
src/components/ViolationMessages.tsx 0.00% <ø> (ø)
src/libs/DebugUtils.ts 68.82% <ø> (ø)
src/libs/Violations/ViolationsUtils.ts 75.00% <100.00%> (+0.22%) ⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx 64.31% <0.00%> (ø)
src/hooks/useViolations.ts 50.00% <0.00%> (-0.77%) ⬇️
... and 26 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e368ad4e40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/libs/Violations/ViolationsUtils.ts Outdated
case 'modifiedDate':
return translate('violations.modifiedDate');
case 'modifiedDistance':
return translate('violations.modifiedDistance');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add modifiedDistance translation across all locale files

This new branch now always calls translate('violations.modifiedDistance'), but this commit only adds that key in en.ts and es.ts; other locales (for example de, fr, ja, pt-BR, nl, pl, it, zh-hans) still lack it. When a non-English/Spanish user hits this violation, the app will fall back to a raw key in production and throw in development per src/libs/Localize/index.ts, so the violation text is still broken outside en/es.

Useful? React with 👍 / 👎.

The violation was being received via Onyx but not displayed because
modifiedDistance was missing from the violationNameToField mapping
in useViolations.ts. Also added formattedRouteDistance to the
violation data type and updated translations to show the calculated
route distance.

Made-with: Cursor
@OSBotify

This comment has been minimized.

…ction

Map the violation to the waypoints field so it displays under the
distance row. Read routeDistanceMeters from the transaction's
customUnit instead of relying on data sent in the violation, and
convert to the transaction's distance unit on the client side.

Made-with: Cursor
The modifiedDistance violation text was inconsistent because
getRBRMessages was not passing the transaction, so the route
distance could not be resolved for the chat violation message.

Made-with: Cursor
…rs, fix ESLint

- Add modifiedDistance to de, fr, it, ja, nl, pl, pt-BR, zh-hans language files
- Add ViolationsModifiedDistanceParams import to language files
- Add routeDistanceMeters to DebugUtils pendingFields validation
- Fix ChangeReceiptBillingAccountPage: remove setState in effect (derive effectiveSelected)

Made-with: Cursor
This better describes the violation's purpose: it fires when a distance
expense's quantity has been increased above the original calculated route,
not for any arbitrary modification.

Made-with: Cursor
@OSBotify

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 9097aed0..4345901f 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7910,7 +7910,7 @@ Fordern Sie Spesendetails wie Belege und Beschreibungen an, legen Sie Limits und
         },
         modifiedDate: 'Datum weicht vom gescannten Beleg ab',
         increasedDistance: ({formattedRouteDistance}: ViolationsIncreasedDistanceParams) =>
-            formattedRouteDistance ? `Distance exceeds the calculated route of ${formattedRouteDistance}` : 'Distance exceeds the calculated route',
+            formattedRouteDistance ? `Die Entfernung übersteigt die berechnete Route von ${formattedRouteDistance}` : 'Entfernung übersteigt die berechnete Route',
         nonExpensiworksExpense: 'Nicht-Expensiworks-Ausgabe',
         overAutoApprovalLimit: ({formattedLimit}: ViolationsOverLimitParams) => `Ausgabe überschreitet das Auto-Genehmigungslimit von ${formattedLimit}`,
         overCategoryLimit: ({formattedLimit}: ViolationsOverCategoryLimitParams) => `Betrag über dem Kategorie-Limit von ${formattedLimit}/Person`,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 364b4410..b0f563d1 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7933,7 +7933,7 @@ Rendez obligatoires des informations de dépense comme les reçus et les descrip
         },
         modifiedDate: 'La date diffère du reçu scanné',
         increasedDistance: ({formattedRouteDistance}: ViolationsIncreasedDistanceParams) =>
-            formattedRouteDistance ? `Distance exceeds the calculated route of ${formattedRouteDistance}` : 'Distance exceeds the calculated route',
+            formattedRouteDistance ? `La distance dépasse l’itinéraire calculé de ${formattedRouteDistance}` : 'La distance dépasse l’itinéraire calculé',
         nonExpensiworksExpense: 'Dépense non Expensiworks',
         overAutoApprovalLimit: ({formattedLimit}: ViolationsOverLimitParams) => `La dépense dépasse la limite d’auto-approbation de ${formattedLimit}`,
         overCategoryLimit: ({formattedLimit}: ViolationsOverCategoryLimitParams) => `Montant dépassant la limite de catégorie de ${formattedLimit}/personne`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index aeeb9cb0..b10f367e 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7897,7 +7897,7 @@ Richiedi dettagli sulle spese come ricevute e descrizioni, imposta limiti e valo
         },
         modifiedDate: 'Data diversa dalla ricevuta scansionata',
         increasedDistance: ({formattedRouteDistance}: ViolationsIncreasedDistanceParams) =>
-            formattedRouteDistance ? `Distance exceeds the calculated route of ${formattedRouteDistance}` : 'Distance exceeds the calculated route',
+            formattedRouteDistance ? `La distanza supera il percorso calcolato di ${formattedRouteDistance}` : 'La distanza supera il percorso calcolato',
         nonExpensiworksExpense: 'Spesa non-Expensiworks',
         overAutoApprovalLimit: ({formattedLimit}: ViolationsOverLimitParams) => `La spesa supera il limite di approvazione automatica di ${formattedLimit}`,
         overCategoryLimit: ({formattedLimit}: ViolationsOverCategoryLimitParams) => `Importo superiore al limite di categoria di ${formattedLimit}/persona`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index c451c8c5..173a14fb 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7809,7 +7809,7 @@ ${reportName}
         },
         modifiedDate: '日付がスキャンしたレシートと異なります',
         increasedDistance: ({formattedRouteDistance}: ViolationsIncreasedDistanceParams) =>
-            formattedRouteDistance ? `Distance exceeds the calculated route of ${formattedRouteDistance}` : 'Distance exceeds the calculated route',
+            formattedRouteDistance ? `距離が計算されたルート距離(${formattedRouteDistance})を超えています` : '距離が計算されたルートを超えています',
         nonExpensiworksExpense: 'Expensiworks 以外の経費',
         overAutoApprovalLimit: ({formattedLimit}: ViolationsOverLimitParams) => `経費が自動承認限度額 ${formattedLimit} を超えています`,
         overCategoryLimit: ({formattedLimit}: ViolationsOverCategoryLimitParams) => `1人あたりのカテゴリ上限 ${formattedLimit} を超えた金額`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index a7c73c16..33381020 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7875,7 +7875,7 @@ Vereis onkostendetails zoals bonnen en beschrijvingen, stel limieten en standaar
         },
         modifiedDate: 'Datum wijkt af van gescande bon',
         increasedDistance: ({formattedRouteDistance}: ViolationsIncreasedDistanceParams) =>
-            formattedRouteDistance ? `Distance exceeds the calculated route of ${formattedRouteDistance}` : 'Distance exceeds the calculated route',
+            formattedRouteDistance ? `Afstand overschrijdt de berekende route van ${formattedRouteDistance}` : 'Afstand overschrijdt de berekende route',
         nonExpensiworksExpense: 'Niet-Expensiworks-uitgave',
         overAutoApprovalLimit: ({formattedLimit}: ViolationsOverLimitParams) => `Kosten overschrijden de automatische goedkeuringslimiet van ${formattedLimit}`,
         overCategoryLimit: ({formattedLimit}: ViolationsOverCategoryLimitParams) => `Bedrag boven de categorielimiet van ${formattedLimit} per persoon`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 60878222..27b43c7c 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7863,7 +7863,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
         },
         modifiedDate: 'Data różni się od zeskanowanego paragonu',
         increasedDistance: ({formattedRouteDistance}: ViolationsIncreasedDistanceParams) =>
-            formattedRouteDistance ? `Distance exceeds the calculated route of ${formattedRouteDistance}` : 'Distance exceeds the calculated route',
+            formattedRouteDistance ? `Dystans przekracza obliczoną trasę ${formattedRouteDistance}` : 'Dystans przekracza obliczoną trasę',
         nonExpensiworksExpense: 'Wydatek spoza Expensiworks',
         overAutoApprovalLimit: ({formattedLimit}: ViolationsOverLimitParams) => `Wydatek przekracza automatyczny limit zatwierdzania w wysokości ${formattedLimit}`,
         overCategoryLimit: ({formattedLimit}: ViolationsOverCategoryLimitParams) => `Kwota przekracza limit kategorii w wysokości ${formattedLimit}/osobę`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index a8b71517..6d6a9125 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7867,7 +7867,7 @@ Exija dados de despesas como recibos e descrições, defina limites e padrões e
         },
         modifiedDate: 'Data diferente do recibo digitalizado',
         increasedDistance: ({formattedRouteDistance}: ViolationsIncreasedDistanceParams) =>
-            formattedRouteDistance ? `Distance exceeds the calculated route of ${formattedRouteDistance}` : 'Distance exceeds the calculated route',
+            formattedRouteDistance ? `A distância excede a rota calculada de ${formattedRouteDistance}` : 'A distância excede a rota calculada',
         nonExpensiworksExpense: 'Despesa fora do Expensiworks',
         overAutoApprovalLimit: ({formattedLimit}: ViolationsOverLimitParams) => `Despesa excede o limite de aprovação automática de ${formattedLimit}`,
         overCategoryLimit: ({formattedLimit}: ViolationsOverCategoryLimitParams) => `Valor acima do limite de categoria de ${formattedLimit}/pessoa`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 0ec175a6..a0f896a4 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7674,7 +7674,7 @@ ${reportName}
         },
         modifiedDate: '日期与已扫描收据不符',
         increasedDistance: ({formattedRouteDistance}: ViolationsIncreasedDistanceParams) =>
-            formattedRouteDistance ? `Distance exceeds the calculated route of ${formattedRouteDistance}` : 'Distance exceeds the calculated route',
+            formattedRouteDistance ? `距离超过计算出的路线 ${formattedRouteDistance}` : '距离超过计算的路线',
         nonExpensiworksExpense: '非 Expensiworks 报销',
         overAutoApprovalLimit: ({formattedLimit}: ViolationsOverLimitParams) => `报销金额超出自动审批上限 ${formattedLimit}`,
         overCategoryLimit: ({formattedLimit}: ViolationsOverCategoryLimitParams) => `金额超出每人 ${formattedLimit} 的类别限额`,

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

…rimitives

getViolationTranslation only accesses transaction.comment.customUnit for
the increasedDistance violation. Passing the entire Transaction object forced
callers to include it in useMemo dependency arrays, causing unnecessary
recomputation whenever any unrelated field changed.

Made-with: Cursor
…hould be Unit

Changed routeDistanceMeters from number | string to just number in
Transaction.ts since the backend always returns a numeric value.
Updated distanceUnit parameter in getViolationTranslation from string
to Unit type to match the DistanceRequestUtils.getDistanceForDisplayLabel
signature.

Made-with: Cursor
…odifiedDistance-violation

Made-with: Cursor

# Conflicts:
#	Mobile-Expensify
#	src/languages/de.ts
#	src/languages/en.ts
#	src/languages/fr.ts
#	src/languages/it.ts
#	src/languages/ja.ts
#	src/languages/nl.ts
#	src/languages/params.ts
#	src/languages/pl.ts
#	src/languages/pt-BR.ts
#	src/languages/zh-hans.ts
…anslate

Replace the custom enTranslate helper and eslint-disable block with
IntlStore spies that load real English translations, allowing the
standard translateLocal to resolve actual English strings.

Made-with: Cursor
The --experimental-vm-modules flag in npm test enables dynamic imports,
so IntlStore.load(CONST.LOCALES.EN) works correctly. Remove the en,
flattenObject imports and IntlStore spy setup in favor of the simpler
IntlStore.load pattern matching the reviewer's suggestion.

Made-with: Cursor
@neil-marcellini

Copy link
Copy Markdown
Contributor Author

@situchan thank you for helping to clean that up. Changes have been made.

@melvin-bot
melvin-bot Bot requested a review from carlosmiceli March 25, 2026 21:24
@melvin-bot

melvin-bot Bot commented Mar 25, 2026

Copy link
Copy Markdown

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@neil-marcellini
neil-marcellini requested review from rlinoz and removed request for carlosmiceli, mjasikowski and stitesExpensify March 25, 2026 21:24
@neil-marcellini neil-marcellini changed the title [HOLD Web-E 51089] Add increased distance violation display Add increased distance violation display Mar 26, 2026
@neil-marcellini
neil-marcellini merged commit 00ddfe5 into main Mar 26, 2026
34 checks passed
@neil-marcellini
neil-marcellini deleted the neil-marcellini/add-modifiedDistance-violation branch March 26, 2026 16:17
@melvin-bot melvin-bot Bot added the Emergency label Mar 26, 2026
@melvin-bot

melvin-bot Bot commented Mar 26, 2026

Copy link
Copy Markdown

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 27, 2026
86 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.50-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here).

Failure details: https://github.com/Expensify/Expensify/actions/runs/23647042165

@IuliiaHerets

Copy link
Copy Markdown

Hi @neil-marcellini. Can this PR be implemented on the native apps, or will testing on the web be enough?

cc @rlinoz @JmillsExpensify @arosiclair

@situchan

Copy link
Copy Markdown
Contributor

For OD, web is enough.
For ND, native apps can also be tested.

@IuliiaHerets

Copy link
Copy Markdown

@situchan, how can we create distance expenses using the map? In the hybrid app, that option is not showing

WhatsApp.Video.2026-03-27.at.3.32.18.PM.mp4

@situchan

Copy link
Copy Markdown
Contributor

how can we create distance expenses using the map?

Please do this in OD web.

Just test violation visibility in native apps.

@IuliiaHerets

Copy link
Copy Markdown

@situchan When we run the command const policy = Policy.getActive(); policy.policy.isPolicyExpenseChatEnabled = false; policy.save(); from this test case, the expenses are not shown in the New hybrid app for the account.
QA team was only able to perform PR steps 1, 4, and 5 — steps 2 and 3 do not show the expenses in the New hybrid app

2b6a6cc7bf063f340ea3574d0eed9ad0.mp4

@situchan

Copy link
Copy Markdown
Contributor

@situchan When we run the command const policy = Policy.getActive(); policy.policy.isPolicyExpenseChatEnabled = false; policy.save(); from this test case, the expenses are not shown in the New hybrid app for the account. QA team was only able to perform PR steps 1, 4, and 5 — steps 2 and 3 do not show the expenses in the New hybrid app

2b6a6cc7bf063f340ea3574d0eed9ad0.mp4

That's expected.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants