Skip to content

Add Assign new cards option for direct card feeds v2 - #86032

Merged
carlosmiceli merged 26 commits into
Expensify:mainfrom
fedirjh:sync-feed-cards
Mar 26, 2026
Merged

carlosmiceli merged 26 commits into
Expensify:mainfrom
fedirjh:sync-feed-cards

Conversation

@fedirjh

@fedirjh fedirjh commented Mar 22, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Direct card feeds cache their accountList at initial connection. When banks issue new cards, they don't appear in NewDot's assignment UI. This PR adds an "Assign new cards" menu item in the feed settings page (only for direct feeds) that triggers the existing OAuth/Plaid reconnection flow to refresh the card list.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/594594
$ #79383
$ #85676
PROPOSAL:

Tests

Test 1 :

  1. Create a new unvalidated account
  2. Create a new workspace and navigate to the company cards page
  3. Click add new cards to set up a new feed
  4. Verify the validate account page appears
  5. Validate account and verify you are navigated to set up a new feed
  6. Verify you can add a new direct feed

Test 2 :

  1. Navigate to a workspace with a direct (OAuth) card feed
  2. Go to Settings for that feed
  3. Verify "Assign new cards" menu item appears with the Sync icon and the description "Get the latest cards to assign from your bank"
  4. Tap "Assign new cards" → verify bank auth opens
  5. Complete re-auth → verify modal dismisses
  6. Navigate to a workspace with a commercial card feed → Settings → verify "Assign new cards" does NOT appear
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline
  2. Navigate to feed settings → tap "Assign new cards"
  3. Verify the offline blocking view is shown
  4. Go back online → verify the flow resumes

QA Steps

Test 1 :

  1. Create a new unvalidated account
  2. Create a new workspace and navigate to the company cards page
  3. Click add new cards to set up a new feed
  4. Verify the validate account page appears
  5. Validate account and verify you are navigated to set up a new feed
  6. Verify you can add a new direct feed

Test 2 :

  1. Navigate to a workspace with a direct card feed → Settings
  2. Verify "Assign new cards" appears only for direct feeds (OAuth/Plaid)
  3. Tap "Assign new cards" and complete re-auth
  4. Verify modal dismisses after re-auth
  5. Verify no errors in the JS console
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

CleanShot.2026-03-23.at.17.15.08-converted.mp4
CleanShot.2026-03-23.at.17.15.08.mp4
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

fedirjh added 6 commits March 21, 2026 22:09
- Introduced a new route for refreshing the company card feed connection in ROUTES.ts.
- Added corresponding screen identifier in SCREENS.ts.
- Updated navigation types to include parameters for the new screen.
- Registered the new screen in the modal stack navigator.
- Updated linking configuration to support the new route.
- Added new translation keys for 'Assign new cards' and its description in both en.ts and es.ts files.
…CardsSettingsPage

- Created a new RefreshCardFeedConnectionPage component to handle the card feed connection process.
- Implemented logic to manage navigation based on the current step of the card assignment process.
- Updated WorkspaceCompanyCardsSettingsPage to include a menu item for assigning new cards, linking it to the new refresh card feed connection page.
- Enhanced the user experience by conditionally displaying the new menu item based on the feed type.
- Updated the AssignCard type to include an isRefreshing property to track the refresh state.
- Modified setAssignCardStepAndData function to accept and merge the isRefreshing state.
- Implemented logic in RefreshCardFeedConnectionPage to prevent navigation during refresh.
- Adjusted WorkspaceCompanyCardsSettingsPage to set the isRefreshing state when initiating card assignment.
- Introduced usePrevious hook to track the previous isRefreshing state.
- Updated navigation logic to close the RHP flow only when transitioning from refreshing to not refreshing.
- Adjusted useEffect dependencies for better state management.
- Added a title prop to BankConnection and PlaidConnectionStep components for better header customization.
- Updated RefreshCardFeedConnectionPage to utilize the new title prop, improving consistency in header titles across components.
- Refactored LoadingPage to use the title prop for a unified user experience.
@melvin-bot

melvin-bot Bot commented Mar 22, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

fedirjh added 7 commits March 22, 2026 02:10
- Integrated useCardFeeds hook to manage card feed data and expiration.
- Added logic to trigger setFeedRefreshComplete on feed expiration changes during refresh.
- Improved state management in RefreshCardFeedConnectionPage for better user experience.
- Refactored imports in WorkspaceCompanyCardsSettingsPage for clarity and organization.
- Created comprehensive tests for the RefreshCardFeedConnectionPage component to validate rendering based on different states.
- Included tests for loading state, bank connection, and plaid connection steps.
- Verified that the correct actions are called on component unmount and when feed expiration updates.
- Enhanced test coverage to ensure robust handling of card feed connection scenarios.
- Introduced a new page for verifying company card accounts, enhancing the user flow for account validation.
- Updated ROUTES.ts and SCREENS.ts to include the new verification route and screen identifier.
- Modified navigation logic in existing components to redirect users to the verification page when account validation is required.
- Ensured proper linking configuration for the new route to maintain navigation integrity.
- Introduced seedCardFeedRefresh and startCardFeedRefresh functions to manage the card feed refresh flow.
- Updated WorkspaceCompanyCardsVerifyAccountPage to utilize the new refresh logic upon successful account validation.
- Refactored WorkspaceCompanyCardsSettingsPage to initiate the card feed refresh process using the new functions.
- Improved import organization across multiple components for better clarity and maintainability.
…ngsPage for improved state handling

- Updated RefreshCardFeedConnectionPage to enhance the logic for closing the RHP flow and setting feed refresh completion based on state changes.
- Refactored useEffect dependencies to prevent unnecessary executions and improve clarity.
- Moved the import statement for isUserValidatedSelector in WorkspaceCompanyCardsSettingsPage for better organization.
@fedirjh
fedirjh marked this pull request as ready for review March 23, 2026 16:26
@fedirjh
fedirjh requested review from a team as code owners March 23, 2026 16:26
@melvin-bot
melvin-bot Bot requested review from hungvu193 and joekaufmanexpensify and removed request for a team March 23, 2026 16:26
@melvin-bot

melvin-bot Bot commented Mar 23, 2026

Copy link
Copy Markdown

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team March 23, 2026 16:26
@fedirjh
fedirjh requested a review from carlosmiceli March 23, 2026 16:31
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 6eeb121a..5920f8dc 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5124,6 +5124,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
                 flipAmountSign: 'Betragsvorzeichen umkehren',
                 importButton: 'Transaktionen importieren',
             },
+            assignNewCards: {title: 'Neue Karten zuweisen', description: 'Holen Sie die neuesten Karten zum Zuweisen von Ihrer Bank'},
         },
         expensifyCard: {
             issueAndManageCards: 'Geben Sie Expensify Karten aus und verwalten Sie sie',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index af591fc4..a11ab734 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5135,6 +5135,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
                 flipAmountSign: 'Inverser le signe du montant',
                 importButton: 'Importer des transactions',
             },
+            assignNewCards: {title: 'Assigner de nouvelles cartes', description: 'Obtenez les dernières cartes à assigner depuis votre banque'},
         },
         expensifyCard: {
             issueAndManageCards: 'Émettre et gérer vos Cartes Expensify',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index fb28455e..48f268a1 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5106,6 +5106,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
                 flipAmountSign: 'Inverti segno importo',
                 importButton: 'Importa transazioni',
             },
+            assignNewCards: {title: 'Assegna nuove carte', description: 'Ottieni le ultime carte da assegnare dalla tua banca'},
         },
         expensifyCard: {
             issueAndManageCards: 'Emetti e gestisci le tue Carte Expensify',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index bf1b0260..c7d1f37f 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5058,6 +5058,7 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
                 flipAmountSign: '金額の符号を反転',
                 importButton: '取引をインポート',
             },
+            assignNewCards: {title: '新しいカードを割り当てる', description: '銀行から割り当て可能な最新のカードを取得します'},
         },
         expensifyCard: {
             issueAndManageCards: 'Expensify カードを発行して管理する',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 1ce90337..cc321dce 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5097,6 +5097,7 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
                 flipAmountSign: 'Teken van bedrag omdraaien',
                 importButton: 'Transacties importeren',
             },
+            assignNewCards: {title: 'Nieuwe kaarten toewijzen', description: 'Haal de nieuwste kaarten op om toe te wijzen vanuit je bank'},
         },
         expensifyCard: {
             issueAndManageCards: 'Geef Expensify Kaarten uit en beheer ze',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 894305d7..688658df 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5089,6 +5089,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
                 flipAmountSign: 'Odwróć znak kwoty',
                 importButton: 'Importuj transakcje',
             },
+            assignNewCards: {title: 'Przydziel nowe karty', description: 'Pobierz z banku najnowsze karty do przypisania'},
         },
         expensifyCard: {
             issueAndManageCards: 'Wydawaj i zarządzaj Kartami Expensify',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 0ac1a3cd..a8ffd092 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5089,6 +5089,7 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
                 flipAmountSign: 'Inverter sinal do valor',
                 importButton: 'Importar transações',
             },
+            assignNewCards: {title: 'Atribuir novos cartões', description: 'Obtenha do seu banco os cartões mais recentes para atribuir'},
         },
         expensifyCard: {
             issueAndManageCards: 'Emita e gerencie seus Cartões Expensify',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index db6b1776..d3a55f6d 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4978,6 +4978,7 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
                 flipAmountSign: '翻转金额符号',
                 importButton: '导入交易',
             },
+            assignNewCards: {title: '分配新卡', description: '从您的银行获取可分配的最新银行卡'},
         },
         expensifyCard: {
             issueAndManageCards: '发放并管理您的 Expensify 卡',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

fedirjh added 3 commits March 23, 2026 16:46
…te function and updating imports in related components.
…nectionPageTest and update related test cases to reflect this change.
@fedirjh

fedirjh commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Can you try with this url?

@hungvu193

Screenshot 2026-03-25 at 5 51 54 PM

@hungvu193

Copy link
Copy Markdown
Contributor

That's really weird, it doesn't work for me

Screen.Recording.2026-03-25.at.23.56.33.mov

@hungvu193

Copy link
Copy Markdown
Contributor

just checked and with my case, currentStep is undefined, so it 's fallback to LoadingPage.

Screenshot 2026-03-26 at 00 01 20

@fedirjh

fedirjh commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

@hungvu193 Can you retry now ?

@hungvu193

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-03-24.at.22.53.09.mov
Screen.Recording.2026-03-24.at.22.53.34.mov
Screen.Recording.2026-03-24.at.22.54.21.mov

@melvin-bot

melvin-bot Bot commented Mar 26, 2026

Copy link
Copy Markdown

🎯 @hungvu193, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #86386.

@hungvu193

Copy link
Copy Markdown
Contributor

For the QA team ,please note that this issue for Mock Card. We've mentioned here:

#86032 (comment)

@hungvu193

Copy link
Copy Markdown
Contributor

Oh we need to resolve the test failed @fedirjh

@hungvu193

Copy link
Copy Markdown
Contributor

All yours @carlosmiceli

@carlosmiceli
carlosmiceli merged commit 0f06fb3 into Expensify:main Mar 26, 2026
32 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

@fedirjh
fedirjh deleted the sync-feed-cards branch March 26, 2026 15:07
@OSBotify OSBotify mentioned this pull request Mar 27, 2026
86 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.50-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help Site Review Complete

Yes, changes are required. PR #86032 adds an Assign new cards option for direct card feeds, which is not documented in the existing help site articles.

Changes made:

  1. docs/articles/new-expensify/connect-credit-cards/Company-Card-Settings.md — Added the Assign new cards action to the settings page available actions list, noting it's only available for direct feeds.

  2. docs/articles/new-expensify/connect-credit-cards/Direct-feeds.md — Added a new FAQ entry: "Why don't newly issued cards appear in the assignment list?" with step-by-step instructions on how to use the new feature.

Help site PR: #86531

Please review and mark it as "Ready for review" when it looks good.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants