Repository navigation
Fix tooltip position when recipients list is filtered - #86094
Conversation
When filtering the recipients list, the EducationalTooltip on the Manager McTest item stays at its original position because the uniqueID never changes. ListItemRenderer has the index prop but doesn't forward it to the ListItem. InviteMemberListItem uses index to build uniqueID for the tooltip re-measurement effect, but falls back to 0 since it never receives the actual value. Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.movAndroid: mWeb Chromemweb-chrome.moviOS: HybridAppios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.mov |
|
@MelvinBot Include an extra step at step 3 in QA steps/Tests requiring the user to delete the workspace. |
|
Updated the PR description — added "Delete the workspace" as step 3 in both the Tests and QA Steps sections, and renumbered the subsequent steps accordingly. |
|
@MelvinBot Please mark it as "Ready for review" |
|
Marked this PR as Ready for review as requested. |
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #85799 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
|
🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR and checked the help site articles under No help site changes are required. This PR is a one-line bug fix that passes the
I also confirmed that no existing help site articles reference tooltips, "Try it out" educational prompts, or the |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|
Explanation of Change
ListItemRendererreceives theindexprop but never passes it through to the<ListItem>component.InviteMemberListItemusesindexto compute auniqueIDfor theEducationalTooltip(uniqueID={${sectionIndex}-${index}}), which triggers tooltip re-measurement when it changes. Sinceindexwas never forwarded, it always defaulted to0, souniqueIDstayed"0-0"even when filtering moved the Manager McTest item to a different position. The tooltip then remained at its original coordinates instead of following the item.This one-line fix passes
indexfromListItemRenderertoListItem, allowing the tooltip's existing re-measurement effect to fire when the item's position changes due to filtering.Fixed Issues
$ #85799
PROPOSAL: #85799 (comment)
Tests
Offline tests
N/A - This change only affects tooltip positioning during list filtering, which is a client-side UI operation that does not involve network requests.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari