Repository navigation
[No QA] Remove the restate the issue from proposal template - #86132
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed87b140dc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ## Proposal | ||
|
|
||
| ### Please re-state the problem that we are trying to solve in this issue. | ||
|
|
||
| ### What is the root cause of that problem? |
There was a problem hiding this comment.
Restore the explicit problem statement prompt
Removing the first question means a proposal can now follow the template without ever defining the problem it is solving, which makes the next header (What is the root cause of that problem?) ambiguous on issues that mention multiple symptoms or workarounds. That conflicts with our own contributor guidance in contributingGuides/HOW_TO_CREATE_A_PLAN.md:5-18 and with the reviewer note later in this same file (contributingGuides/PROPOSAL_TEMPLATE.md:15-19), both of which require the problem to be established before reviewers evaluate root cause and solution.
Useful? React with 👍 / 👎.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@iwiznia should we wait for @Beamanator here or am I okay to merge? |
|
thanks for waiting! feel free to merge now @dangrous ! |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
Hi @iwiznia. Any QA steps here? |
|
@IuliiaHerets no QA steps needed here 🙏 |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|
Explanation of Change
I finally got tired enough of this to remove it.
Conversation here https://expensify.slack.com/archives/C03TQ48KC/p1748251297102439
Tests
No
Offline tests
No
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
No
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari