Repository navigation
Use ActivityIndicator in ConfirmCustomListStep - #86268
Conversation
…ustomListStep Swap FullscreenLoadingIndicator for an ActivityIndicator wrapped in a View with identical layout and background styling (absoluteFillObject, fullScreenLoading, w100). This prevents a duplicate back control when shouldUseGoBackButton is later enabled by default. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
….absoluteFill Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
|
Fixed the failing ESLint check: replaced deprecated |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb Safari |
| if (!values.mapping) { | ||
| return <FullScreenLoadingIndicator reasonAttributes={{context: 'ConfirmCustomListStep'}} />; | ||
| return ( | ||
| <View style={[StyleSheet.absoluteFill, styles.fullScreenLoading, styles.w100]}> |
There was a problem hiding this comment.
| <View style={[StyleSheet.absoluteFill, styles.fullScreenLoading, styles.w100]}> | |
| <View style={[styles.flex1, styles.fullScreenLoading]}> |
Co-authored-by: Situ Chandra Shil <nicshil19@gmail.com> Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here). Failure details: https://github.com/Expensify/Expensify/actions/runs/23647089056 |
|
This PR is failing due to #86567 |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|

Explanation of Change
As part of the loading indicator standardization, this replaces
FullscreenLoadingIndicatorwithActivityIndicator(wrapped in aViewwith identical styling) inConfirmCustomListStep.tsx.ConfirmCustomListStepis rendered insideNetSuiteImportAddCustomListContent, which usesConnectionLayoutwith a back button in the header. WhenshouldUseGoBackButtonis later enabled by default onFullscreenLoadingIndicator, users would see two back controls. By switching toActivityIndicatorwith a manually styled wrapperView, we preserve the exact same visual appearance (same background color, opacity, centered large spinner) while avoiding the future duplicate back button.The wrapper
ViewappliesStyleSheet.absoluteFillObject,styles.fullScreenLoading, andstyles.w100— the same styles thatFullscreenLoadingIndicatoruses internally on its outer container.Fixed Issues
$ #85374
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - No visual change; the loading indicator appearance is identical before and after.
Android: mWeb Chrome
N/A - No visual change.
iOS: Native
N/A - No visual change.
iOS: mWeb Safari
N/A - No visual change.
MacOS: Chrome / Safari
N/A - No visual change.