Repository navigation
Collect and persist aaguid and transports - #86292
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/Videos |
|
🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help Site Review: No changes required I reviewed the changes in this PR against all existing help site articles under What this PR does: Collects and persists internal passkey metadata ( Relevant articles reviewed:
Why no changes are needed:
|
|
Hi @rafecolton. Can you please share QA steps? |
|
Hi @IuliiaHerets, this should've been marked [No QA]. Please just pass it along. Thanks! |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|
Explanation of Change
Collect transports and aaguid from passkeys and send them to Auth. Relates to https://github.com/Expensify/Auth/pull/20649/ but does not need to be held for it, since deploy order does not matter.
Fixed Issues
Part of #86065
PROPOSAL: N/A
Tests
Offline tests
N/A online only
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
There's not much to show in the UI for this, but here you can see the values being sent, persisted in auth, and returned
