Skip to content

[WIP] feat: Allow pasting multiple files of any type into the composer - #86677

Draft
chrispader wants to merge 25 commits into
Expensify:mainfrom
margelo:@chrispader/multi-file-paste-regressions
Draft

chrispader wants to merge 25 commits into
Expensify:mainfrom
margelo:@chrispader/multi-file-paste-regressions

Conversation

@chrispader

@chrispader chrispader commented Mar 30, 2026 •

Copy link
Copy Markdown
Contributor

Pasting into the composer on iOS and Android only picks up one file. iOS only accepts images, so a PDF copied from the Files app never arrives, and neither platform keeps the original file name. This PR lets the composer receive every pasted file of any type with its original name, MIME type and size. Text still pastes as text.

@dangrous @MonilBhavsar @grgia @parasharrajat

Explanation of Change

The React Native onPaste patch now sends a files array with the uri, type, name and size of each pasted file. It copies every file to a temporary file first, so the file stays readable after the clipboard changes. On iOS it reads the pasteboard's item providers and keeps the name the source app suggests, like the document name from Files or IMG_0002.jpeg from Photos. On Android it uses OnReceiveContentListener and reads the name and type from the content provider. The listener also receives images that keyboards like Gboard insert from their clipboard.

The patch skips content that has neither a known type nor a file name, and only inputs with an onPaste callback handle files. Text never reaches onPaste, so pasting text keeps the keyboard open. That was the regression in #86578. The composer passes the files straight to the existing attachment flow.

Fixed Issues

$
PROPOSAL:

Tests

iOS: Native

Prerequisite: the Files app has a PDF and a CSV file in the same folder.

  1. In the Files app, select the PDF and the CSV file.
  2. Long-press one of the selected files.
  3. Tap Copy 2 Items.
  4. Open any chat in Expensify.
  5. Paste into the composer and verify that the PDF and the CSV file are sent to the chat and the CSV shows its original file name.
  6. In the Photos app, open a photo.
  7. Tap Share.
  8. Tap Copy Photo.
  9. Switch back to the Expensify chat.
  10. Paste into the composer and verify that the photo is sent to the chat.
  11. Long-press a text message in the chat.
  12. Tap Copy message.
  13. Paste into the composer and verify that the text is inserted and the keyboard stays open.

Android: Native

Prerequisite: Gboard is the keyboard.

  1. In Chrome, open https://upload.wikimedia.org/wikipedia/commons/a/a9/Example.jpg.
  2. Long-press the image.
  3. Tap Copy image.
  4. Open any chat in Expensify.
  5. Tap the composer.
  6. Tap the copied image in Gboard's suggestion strip and verify that the image is sent to the chat.
  7. Paste into the composer and verify that the image is sent to the chat again.
  8. Long-press a text message in the chat.
  9. Tap Copy message.
  10. Paste into the composer and verify that the text is inserted.
  • Verify that no errors appear in the JS console

Offline tests

  1. Turn off the network connection.
  2. Paste a file into the composer as in the steps above and verify that it shows up in the chat right away.
  3. Turn the network connection back on and verify that the file finishes uploading.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@chrispader
chrispader marked this pull request as draft March 30, 2026 18:23
@chrispader chrispader changed the title fix: Prevent firing onPaste event for text based content and no files [WIP] fix: Prevent firing onPaste event for text based content and no files Mar 30, 2026
@codecov

codecov Bot commented Apr 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...omponents/Composer/implementation/index.native.tsx 95.83% <100.00%> (-0.72%) ⬇️
... and 15 files with indirect coverage changes

@chrispader

Copy link
Copy Markdown
Contributor Author

Okay so here's a quick update after working on this follow-up for the recently reverted Multi file clipboard paste PR:

In general, it is already possible to paste multiple files of any data type to the clipboard on both Android and iOS, but there are some caveats that i'm still working on and haven't found a holistic solution yet:

iOS

  • File name cannot be preserved through the clipboard data:
    • When a file from the image gallery or iOS Files app is pasted to the clipboard, it is pasted in two different forms
      1. The actual data of the content. If it is a text-based file, this willl be the actual string, without any file metadata
      2. A file item used by the iOS Files app that is part of a private API, therefore cannot be used to retrieve the information about the file
    • Since we cannot really read the file metadata from the pasteboard item, it is currently impossible to re-create the file with the correct filename. A new temporary file with the correct extension and content of the pasteboard item is created on the phone and the URI of it is sent to the JS event.

Android

  • Issues with Android SecurityException's
    • Sometimes, items that were added to the clipboard have a expiration date or it is not guaranteed, that the content of the clipboard item is readable, since the app that copies the content is in control of that data.
      • In cases where we cannot read the data, we have no other option to omit the item from the pasted item list and potentially show an error in the UI with the specific error message. I think this will creep the scope of this PR though, so i'd just send whatever clipboard items are valid to the JS event.
  • Reading content://media... URIs
    • Usually, the app that copies content to the clipboard provides a specific ContentProvider in the content URI, but sometimes, the content URI represents a MediaStore item, for which it is a bit vague to read the data. I still have to work on a solution to support all these different types of content URIs.

@chrispader chrispader changed the title [WIP] fix: Prevent firing onPaste event for text based content and no files [WIP] feat: Allow pasting any number of files of any type into the Composer Apr 3, 2026
@chrispader chrispader changed the title [WIP] feat: Allow pasting any number of files of any type into the Composer [WIP] feat: Allow pasting multiple files of any type into the composer Apr 3, 2026
chrispader and others added 6 commits September 9, 2026 13:58
The new-file headers used `diff --git b/... b/...`, which patch-package
cannot parse, so postinstall failed on a fresh install.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rewrite the TextInput onPaste patch so native code resolves each pasted
file's MIME type, name and size, copies it to a temporary file, and only
then calls onPaste. iOS reads pasteboard item providers, and Android uses
OnReceiveContentListener, which also receives images from the keyboard's
clipboard. Text always goes through the default paste, and only inputs
with an onPaste callback handle files.

The Composer passes the files straight to the attachment flow, so the
getFileSize lookup and the react-native-fs patch it needed are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrispader and others added 4 commits October 28, 2026 23:54
react-native-live-markdown replaces the text view's delegate and only
forwards `textInputDidPaste:`, so the composer never received pasted
files. Use that method name. Also treat items from the Files app as files
on iOS 26, which marks them with com.apple.DocumentManager.FINode.File,
and items offered for opening in place.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`ContentInfo.releasePermissions()` is not part of the public SDK, so
ReactAndroid failed to compile. The copy task already holds on to the
content until the files are copied.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The merge of main rebuilt them from outdated dependencies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ReportActionCompose and ConciergePromptBox tests still pasted the old items payload.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant