Repository navigation
fix: prevent Concierge redirect and LHN disappearance when vacation delegate splits expense #86869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AndrewGable
merged 1 commit into
Expensify:main
from
neerajbachani:fix/84248-vacation-delegate-lhn-clean
Apr 22, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import {useRef} from 'react'; | ||
| import type {OnyxEntry} from 'react-native-onyx'; | ||
| import type * as OnyxTypes from '@src/types/onyx'; | ||
|
|
||
| /** | ||
| * Returns a ref that tracks whether the currently-open report is an own workspace chat. | ||
| * | ||
| * Must be updated synchronously during render — after a vacation delegate splits an expense | ||
| * the server sends an Onyx SET that wipes the report object. By the time any useEffect fires, | ||
| * `report` is already undefined, so live state and usePrevious both fail. The ref persists | ||
| * the last known value through that wipe window so navigation guards and re-fetch effects | ||
| * can still make the correct decision. See issue #84248. | ||
| */ | ||
| function useIsOwnWorkspaceChatRef(report: OnyxEntry<OnyxTypes.Report> | undefined, reportIDFromRoute: string | undefined) { | ||
| const isOwnWorkspaceChatRef = useRef(false); | ||
|
|
||
| if (report?.reportID && report.reportID === reportIDFromRoute) { | ||
| // Valid, matching report — update the ref. | ||
| isOwnWorkspaceChatRef.current = !!report.isOwnPolicyExpenseChat; | ||
| } else if (!report?.reportID) { | ||
| // Report wiped by Onyx SET — intentionally keep the last known value. | ||
| } else { | ||
| // Different report loaded — reset. | ||
| isOwnWorkspaceChatRef.current = false; | ||
| } | ||
|
|
||
| return isOwnWorkspaceChatRef; | ||
| } | ||
|
|
||
| export default useIsOwnWorkspaceChatRef; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ CONSISTENCY-5 (docs)
The
eslint-disable-next-line react-hooks/exhaustive-depson line 183 lacks a justification comment explaining why certain dependencies (likelyfetchReport) are omitted. Even thoughfetchReportis created viauseEffectEvent(and is therefore stable), this should be documented for future readers.Add a comment above or on the same line, for example:
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added justification comment above the eslint-disable line. Updated