Repository navigation
BT - Migrate Tasks and Notes - #86941
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 698c0258a7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
trjExpensify
left a comment
There was a problem hiding this comment.
backTo project PR 👍
|
@mananjadhav Could you please review the Codex comment? |
|
What about |
I'll add as a follow up. |
TASK_TITLE, REPORT_DESCRIPTIONTasks and Notes
|
Tag me when this PR is ready for review. Thank you 😄 |
|
It's still work in progress. I'll keep you posted. |
6c89e25 to
17a6ee2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17a6ee245b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@huult This is ready for your review. |
|
Reviewing... |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-05-22.at.09.40.21.mov |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.80-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. This is a purely internal navigation/routing refactor — it migrates Tasks and Notes routes from static There are no user-facing changes to features, UI labels, button text, or behavior. The existing help site article (Assign a Task via Chat) describes task workflows in terms of UI actions, not internal URL paths. No help site documentation changes are required for this PR. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|
Explanation of Change
Fixed Issues
$ #83371
PROPOSAL:
Tests
Task title (r/:reportID/title)
Report / task description (r/:reportID/description)
Observe the URL ending with /description after the report segment (e.g. r//description).
Task description (
description)/descriptionon the current base path (e.g.r/<reportID>/descriptionfrom chat, orr/<reportID>/details/descriptionif you opened details first)./description./description./descriptionin the URL).Task assignee (
assignee)/assignee(e.g.r/<reportID>/assigneefrom chat, orsearch/view/<reportID>/assigneefrom search RHP)./assignee./assignee.Private notes (
notes,notes-edit/:accountID)Note: This cannot be tested by QA, can only be tested by updating the
canUsePrivateNotes(): truein the code/notes-edit/<yourAccountID>(e.g.r/<reportID>/details/notes-edit/<accountID>)./notesor/notes-edit./notes(nonotes-editsegment)./notes-edit/<accountID>.…/notes)./notesor/notes-edit)./notes-edit/<accountID>./notesor/notes-edit/...andreportIDas a query param on the profile path. Back should return to profile without/notesin the path.Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-bt-task-title-desc.mov
Android: mWeb Chrome
mweb-chrome-bt-task-title-desc.mov
iOS: Native
ios-bt-task-title-desc.mov
iOS: mWeb Safari
mweb-safari-bt-task-title-desc.mov
MacOS: Chrome / Safari
web-bt-task-title-desc.mov
Screen.Recording.2026-05-21.at.9.42.21.AM.mov
Screen.Recording.2026-05-21.at.9.38.51.AM.mov
Screen.Recording.2026-05-21.at.9.15.25.AM.mov