Skip to content

BT - Migrate Tasks and Notes - #86941

Merged
mjasikowski merged 5 commits into
Expensify:mainfrom
mananjadhav:mj-83371-bt-task-title-description
May 22, 2026
Merged

mjasikowski merged 5 commits into
Expensify:mainfrom
mananjadhav:mj-83371-bt-task-title-description

Conversation

@mananjadhav

@mananjadhav mananjadhav commented Apr 2, 2026 •

Copy link
Copy Markdown
Collaborator

Explanation of Change

Fixed Issues

$ #83371
PROPOSAL:

Tests

Task title (r/:reportID/title)

  1. Open the Expensify App and sign in.
  2. Open a chat that contains a task (or create a task in a report).
  3. Open the task so you see the task view (title, description, assignee).
  4. Tap Task title (or the title row) to edit the title.
  5. Observe the URL ending with /title after the report segment (e.g. r//title).
  6. Tap Back (or use the header back control).
  7. It should return to the report/task view (URL should not keep /title).
  8. Open the task title editor again, then refresh the page (browser reload).
  9. The title editor should load again and the URL should still end with /title.
  10. Tap Back again and confirm you return to the report/task view as in step 6.

Report / task description (r/:reportID/description)

  1. Open the Expensify App and sign in.
  2. Open a report or task where description is editable (room report or task).
  3. Open Description (task description row or room description from report details).
    Observe the URL ending with /description after the report segment (e.g. r//description).
  4. Tap Back. It should return to the previous report view (URL should not keep /description).
  5. Open the description editor again, then refresh the page.
  6. The description screen should load and the URL should still end with /description.
  7. Tap Back and confirm navigation matches step 5.

Task description (description)

  1. Open the Expensify App and sign in.
  2. Open a task where description is editable.
  3. From the report chat: open description (task: description row in task preview; room: description row on report details after opening details).
  4. Confirm the URL ends with /description on the current base path (e.g. r/<reportID>/description from chat, or r/<reportID>/details/description if you opened details first).
  5. Tap Back. You should return to the previous report view and the URL should not still end with /description.
  6. Open the description editor again.
  7. Refresh the page. The description screen should load and the URL should still end with /description.
  8. Tap Back and confirm you return to the same place as in step 5 (no /description in the URL).

Task assignee (assignee)

  1. Open the Expensify App and sign in.
  2. Open a task report you can edit (from chat or search).
  3. In the task preview, tap Assignee (or the assignee row).
  4. Confirm the URL ends with /assignee (e.g. r/<reportID>/assignee from chat, or search/view/<reportID>/assignee from search RHP).
  5. Tap Back. You should return to the report/task view and the URL should not still end with /assignee.
  6. Open assignee again, change assignee or cancel without changing, then tap Back once more to confirm behavior is consistent.
  7. Open assignee again, then refresh the page. The assignee selector should load and the URL should still end with /assignee.
  8. Tap Back and confirm navigation matches step 5.

Private notes (notes, notes-edit/:accountID)

Note: This cannot be tested by QA, can only be tested by updating the canUsePrivateNotes(): true in the code

  1. Open the Expensify App and sign in (with private notes enabled locally if needed).
  2. Open a normal chat report (not a thread, task, expense report, or invoice).
  3. Open Report details.
  4. Tap Private notes.
  5. First note: if you have no note yet, you should land on the edit screen. Confirm the URL ends with /notes-edit/<yourAccountID> (e.g. r/<reportID>/details/notes-edit/<accountID>).
  6. Enter text, tap Save. You should leave the edit screen and return to report details (or profile for a 1:1 chat opened from profile). The URL should not contain /notes or /notes-edit.
  7. Open Private notes again. With at least one note, you should see the list screen. Confirm the URL ends with /notes (no notes-edit segment).
  8. Tap a note (or your note) to open edit. Confirm the URL ends with /notes-edit/<accountID>.
  9. Tap Back. You should return to the notes list (…/notes).
  10. Tap Back again. You should return to report details (URL should not end with /notes or /notes-edit).
  11. From report details, open Private notes → list → edit, then refresh on the edit screen. Edit should load; the URL should still include /notes-edit/<accountID>.
  12. Tap Back to list, then Back to details; confirm URLs match steps 9–10.
  13. Profile entry (1:1): open another user's profile from a 1:1 chat, tap Private notes. The URL should include /notes or /notes-edit/... and reportID as a query param on the profile path. Back should return to profile without /notes in the path.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-bt-task-title-desc.mov
Android: mWeb Chrome
mweb-chrome-bt-task-title-desc.mov
iOS: Native
ios-bt-task-title-desc.mov
iOS: mWeb Safari
mweb-safari-bt-task-title-desc.mov
MacOS: Chrome / Safari
web-bt-task-title-desc.mov
Screen.Recording.2026-05-21.at.9.42.21.AM.mov
Screen.Recording.2026-05-21.at.9.38.51.AM.mov
Screen.Recording.2026-05-21.at.9.15.25.AM.mov

@mananjadhav
mananjadhav marked this pull request as ready for review April 2, 2026 07:35
@mananjadhav
mananjadhav requested review from a team as code owners April 2, 2026 07:35
@melvin-bot
melvin-bot Bot requested review from huult and trjExpensify and removed request for a team April 2, 2026 07:35
@melvin-bot

melvin-bot Bot commented Apr 2, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team April 2, 2026 07:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 698c0258a7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/ReportDetailsPage.tsx Resolved
@codecov

codecov Bot commented Apr 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/SCREENS.ts 100.00% <ø> (ø)
src/components/ReportActionItem/TaskView.tsx 0.00% <ø> (ø)
src/libs/Navigation/linkingConfig/OldRoutes.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 76.92% <ø> (ø)
src/pages/ReportDescriptionPage.tsx 0.00% <ø> (ø)
src/pages/inbox/ReportNavigateAwayHandler.tsx 70.66% <ø> (ø)
src/pages/inbox/report/withReportOrNotFound.tsx 97.14% <ø> (ø)
src/pages/ProfilePage.tsx 0.00% <0.00%> (ø)
src/ROUTES.ts 19.05% <0.00%> (+1.52%) ⬆️
src/pages/ReportDetailsPage.tsx 55.61% <0.00%> (ø)
... and 9 more
... and 130 files with indirect coverage changes

trjExpensify
trjExpensify previously approved these changes Apr 2, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backTo project PR 👍

@huult

huult commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

@mananjadhav Could you please review the Codex comment?

Comment thread src/ROUTES.ts Resolved
Comment thread src/ROUTES.ts Resolved
Comment thread src/ROUTES.ts Resolved
Comment thread src/libs/Navigation/types.ts Resolved
Comment thread src/libs/TaskUtils.ts Resolved
Comment thread src/libs/TaskUtils.ts Resolved
Comment thread src/libs/TaskUtils.ts Resolved
Comment thread src/pages/tasks/TaskDescriptionPage.tsx Resolved
@huult

huult commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

What about TASK_ASSIGNEE, PRIVATE_NOTES_LIST, and PRIVATE_NOTES_EDIT? I think these can be migrated as well.

@mananjadhav

Copy link
Copy Markdown
Collaborator Author

What about TASK_ASSIGNEE, PRIVATE_NOTES_LIST, and PRIVATE_NOTES_EDIT? I think these can be migrated as well.

I'll add as a follow up.

Comment thread src/SCREENS.ts Resolved
Comment thread src/libs/Navigation/types.ts Resolved
@mananjadhav mananjadhav changed the title BT - Migrate TASK_TITLE, REPORT_DESCRIPTION BT - Migrate Tasks and Notes Apr 15, 2026
Comment thread src/ROUTES.ts Resolved
@huult

huult commented May 12, 2026

Copy link
Copy Markdown
Contributor

Tag me when this PR is ready for review. Thank you 😄

@mananjadhav

Copy link
Copy Markdown
Collaborator Author

It's still work in progress. I'll keep you posted.

@mananjadhav
mananjadhav marked this pull request as draft May 12, 2026 04:56
@mananjadhav
mananjadhav force-pushed the mj-83371-bt-task-title-description branch from 6c89e25 to 17a6ee2 Compare May 21, 2026 04:08
@mananjadhav
mananjadhav marked this pull request as ready for review May 21, 2026 04:10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17a6ee245b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@mananjadhav

Copy link
Copy Markdown
Collaborator Author

@huult This is ready for your review.

@huult

huult commented May 21, 2026

Copy link
Copy Markdown
Contributor

Reviewing...

@huult

huult commented May 22, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-22.at.09.40.21.mov

@huult huult left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot
melvin-bot Bot requested a review from mjasikowski May 22, 2026 02:43
@mjasikowski
mjasikowski merged commit edc4739 into Expensify:main May 22, 2026
38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request May 22, 2026
71 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.80-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

I reviewed the changes in this PR. This is a purely internal navigation/routing refactor — it migrates Tasks and Notes routes from static ROUTES to DYNAMIC_ROUTES, updates screen names, and adjusts navigation calls to use createDynamicRoute.

There are no user-facing changes to features, UI labels, button text, or behavior. The existing help site article (Assign a Task via Chat) describes task workflows in terms of UI actions, not internal URL paths.

No help site documentation changes are required for this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@melvin-bot melvin-bot Bot mentioned this pull request May 25, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants