Repository navigation
Conversation
Allow navigation through the SidebarLinks guard when clicking an LHN row that has an actionTargetReportActionID, even if the user is already viewing the same report. Also pass actionTargetReportActionID to the navigate call so the app deep links to the correct reportAction. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
1 of 7 tasks
Contributor
|
@MelvinBot close this in favor of #87166 |
Contributor
Author
|
Closing in favor of #87166 as requested by |
Contributor
|
@MelvinBot close this PR |
Contributor
Author
|
I attempted to close this PR as requested, but I don't have the required permissions to close PRs in this environment. Please close it manually using the "Close pull request" button below. |
Contributor
|
@MelvinBot close this PR |
Contributor
Author
|
Closed this PR as requested by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The guard condition in
SidebarLinks.tsxprevents navigation when clicking the already-active report in the LHN. However, it did not account for cases where the LHN row has anactionTargetReportActionID(deep link target from a GBR/RBR badge). This meant that if a user was already viewing a workspace chat and an expense was created (triggering a badge), clicking the LHN row would be blocked instead of deep linking to the specific reportAction.This PR adds
!option.actionTargetReportActionIDto both guard conditions so navigation is allowed when a deep link target exists, and passesactionTargetReportActionIDto theNavigation.navigatecall.Fixed Issues
$ #85706
PROPOSAL: #85706 (comment)
Tests
Offline tests
N/A — deep linking navigation is an online-only interaction.
QA Steps
Same as tests above on staging.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — logic-only change, no UI modifications
Android: mWeb Chrome
N/A — logic-only change, no UI modifications
iOS: Native
N/A — logic-only change, no UI modifications
iOS: mWeb Safari
N/A — logic-only change, no UI modifications
MacOS: Chrome / Safari
N/A — logic-only change, no UI modifications