Repository navigation
Update copy #87419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy #87419
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,7 +84,7 @@ function SpendRuleCardPage({route}: SpendRuleCardPageProps) { | |
| const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${defaultFundID}_${CONST.EXPENSIFY_CARD.BANK}`, {selector: filterInactiveCards}); | ||
| const [expensifyCardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${defaultFundID}`); | ||
| const [spendRuleForm] = useOnyx(ONYXKEYS.FORMS.SPEND_RULE_FORM); | ||
| const illustrations = useMemoizedLazyIllustrations(['Telescope']); | ||
| const illustrations = useMemoizedLazyIllustrations(['HandCard']); | ||
| const themeIllustrations = useThemeIllustrations(); | ||
| const companyCardFeedIcons = useCompanyCardFeedIcons(); | ||
|
|
||
|
|
@@ -235,10 +235,13 @@ function SpendRuleCardPage({route}: SpendRuleCardPageProps) { | |
| shouldPreventDefaultFocusOnSelectRow={!canUseTouchScreen()} | ||
| listEmptyContent={ | ||
| <BlockingView | ||
| icon={illustrations.Telescope} | ||
| iconWidth={variables.emptyListIconWidth} | ||
| iconHeight={variables.emptyListIconHeight} | ||
| title={inputValue.trim() ? translate('common.noResultsFound') : translate('workspace.companyCards.noActiveCards')} | ||
| icon={illustrations.HandCard} | ||
| iconWidth={variables.iconSection} | ||
| iconHeight={variables.iconSection} | ||
| title={inputValue.trim() ? translate('common.noResultsFound') : translate('workspace.companyCards.noAvailableCards')} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will always display "All cards already have a rule" — even when no cards exist in the workspace. We have a fix in this PR #88256 More details: #87800 (comment) |
||
| titleStyles={styles.mb2} | ||
| subtitle={translate('workspace.companyCards.noAvailableCardsSubtitle')} | ||
|
Comment on lines
+241
to
+243
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The empty-state title already distinguishes search misses ( Useful? React with 👍 / 👎.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It displays like that. @shawnborton Do you think if we need to change?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given the current requirements, I think the existing display is fine |
||
| subtitleStyle={styles.textSupporting} | ||
| /> | ||
| } | ||
| footerContent={ | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This empty state is rendered in the card assignment flow (
headerTitleisworkspace.companyCards.assignCard), but it now usesworkspace.companyCards.noAvailableCards(“All cards already have a rule”). In this context, cards can be missing because there are no active/unassigned cards in the feed, not because spend rules exist, so users are shown incorrect guidance whenever the assign-card list is empty.Useful? React with 👍 / 👎.