Repository navigation
Don't show non-reimbursable reports in the Pay to-do queu - #87459
Conversation
PR ReviewChange: Filters non-reimbursable-only reports out of the Pay to-do queue by adding a CorrectnessThe logic is correct. The Failing CheckThe SuggestionThe existing tests in VerdictThe change is minimal, well-scoped, and uses an existing utility correctly. Looks good to merge once the flaky CI job passes. 👍 |
|
@situchan working on recordings currently, will ping you once done |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb Chromemchrome.moviOS: HybridAppios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.mov |
|
Rerunning hopefully fix job 8 |
|
Kicked off a quick adhoc |
|
🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
@JmillsExpensify We still show Pay button as primary action in report preview.
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
Ok that's a really fair point. Ok, works for me! Approving.
|
cc @joekaufmanexpensify in case you want to take a look at this PR (and for visibility). |
If an admin never pays a report, that means the report will be pinned to the LHN in perpetuity though, right? Many, if not most, of our customers won't pay entirely non-reimbursable reports. IMO, leaving this pay badge is setting up the LHN to be unusable for these admins. I checked OldDot, and we don't flag entirely non-reimbursable reports for payment in guided review. I don't think it would be inconsistent with that precedent to hide the badge here. 2026-04-09_08-25-33.mp4 |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
codewise this looks good. Do we need a follow up based on @joekaufmanexpensify's comment? cc: @JmillsExpensify |
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
My 2c is people are still going to write in about this if we do not. But we could also wait and see if that happens before changing it further. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.58-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The existing help articles already describe the Pay to-do as surfacing reports ready for reimbursement:
This PR filters non-reimbursable reports out of the Pay queue, which aligns the product with what the docs already say. No article references non-reimbursable reports appearing in Pay, so no updates are needed. |
I don't feel strongly on this one. @joekaufmanexpensify can you create a follow-up issue since this PR is merged? |
|
Thanks |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀
|



Explanation of Change
Don't show non-reimbursable reports in the Pay to-do queu
Fixed Issues
$ #87351
PROPOSAL: #87351 (comment)
Tests
same as QA
Offline tests
Same as QA
QA Steps
/searchand selectPayfrom the Todo sectionVerify that the non-reimbursable report is not visible in the list
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-09.at.12.55.38.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-04-09.at.1.00.21.PM.mov
iOS: Native
Screen.Recording.2026-04-09.at.12.45.25.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-04-09.at.12.46.07.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-09.at.12.12.38.PM.mov