Skip to content

[No QA] Update Home Overview help article for Getting started section - #87572

Merged
zanyrenney merged 3 commits into
mainfrom
claude-addGettingStartedSectionToHomeOverview
Apr 22, 2026
Merged

zanyrenney merged 3 commits into
mainfrom
claude-addGettingStartedSectionToHomeOverview

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Updates the Expensify Home Overview help article to document the new Getting started onboarding checklist section added in #86663. This section guides new Workspace Admins through key setup steps during their free trial.

Changes to Expensify-Home-Overview.md:

  • Added Getting started to the keywords and internalScope metadata
  • Added Getting started to the "What Home shows" section list
  • Added a new "How the Getting started section works on Home" section describing visibility rules and checklist items
  • Added a FAQ entry explaining why the section may not be visible

Fixed Issues

$ #86663

Tests

  1. Open the help article at docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md
  2. Verify the Getting started section is listed under "What Home shows"
  3. Verify the new section describes visibility rules (manage my team intent, free trial period, active paid workspace)
  4. Verify the checklist items match the PR implementation (Create a workspace, Connect to accounting/Customize categories, Link company cards, Set up spend rules)
  5. Verify the FAQ includes an entry about why the Getting started section may not appear
  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation-only change.

QA Steps

[No QA]

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — documentation-only change.

Android: mWeb Chrome

N/A — documentation-only change.

iOS: Native

N/A — documentation-only change.

iOS: mWeb Safari

N/A — documentation-only change.

MacOS: Chrome / Safari

N/A — documentation-only change.

Add the new Getting started onboarding checklist section to the
Expensify Home Overview help article, including visibility rules,
checklist items, and an FAQ entry.

Co-authored-by: Adam Grzybowski  <adamgrzybowski@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team April 10, 2026 08:31
@github-actions github-actions Bot changed the title Update Home Overview help article for Getting started section [No QA] Update Home Overview help article for Getting started section Apr 10, 2026
@OSBotify

OSBotify commented Apr 10, 2026 •

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://4742fa4b.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott marked this pull request as ready for review April 22, 2026 00:26
@melvin-bot

melvin-bot Bot commented Apr 22, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @zanyrenney

@melvin-bot
melvin-bot Bot requested a review from zanyrenney April 22, 2026 00:26
@melvin-bot

melvin-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown

@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team April 22, 2026 00:26
Comment on lines +85 to +91
The **Getting started** section shows a checklist of key setup steps to help Workspace Admins configure their workspace during onboarding.

This section appears only if:

- The workspace is on a free trial
- The workspace owner selected **manage my team** during setup

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content inconsistency: The conditions listed here (free trial + selected "manage my team" during setup) do not match the conditions in the FAQ answer below ("manage my team" intent + within 60 days of free trial start date + active paid workspace). The FAQ lists three conditions while this section lists only two. These should be aligned so users get consistent information. Consider updating one or both to reflect the complete, accurate set of conditions.

- **Spend over time** (when applicable)
- **Discover** (when applicable)
- **Getting started** (when applicable)
- **Discover**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability / accuracy: The "(when applicable)" qualifier was removed from Discover, but the Discover section later in the article states it is "automatically hidden from Home" once the user watches the demo. This means Discover is conditional and does not always appear. Consider keeping "(when applicable)" to stay consistent with the section's described behavior.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds documentation for the new Getting started section on Home, including a content section explaining how it works and a corresponding FAQ entry. The additions follow the established patterns in the article well. However, there is an internal consistency issue between the main section and the FAQ that must be resolved before merging.

Scores Summary

  • Readability: 8/10 - Clear, concise prose that matches the tone and structure of surrounding sections. Bullet-pointed conditions are easy to scan.
  • AI Readiness: 8/10 - Keywords and internalScope updated appropriately. The new heading includes the feature name and follows the "How ... works" pattern used throughout the article.
  • Style Compliance: 7/10 - Deducted for an internal inconsistency in visibility conditions and use of developer-facing language ("intent") in the FAQ.

Key Findings

Must fix -- Conflicting visibility conditions:
The main section ("How the Getting started section works on Home") states two conditions:

  1. The workspace is on a free trial
  2. The workspace owner selected manage my team during setup

The FAQ ("Why don't I see the Getting started section?") states three conditions:

  1. You selected the manage my team intent during onboarding
  2. You are within 60 days of your free trial start date
  3. You have an active paid workspace

These do not align. The FAQ adds a 60-day window and an "active paid workspace" requirement not mentioned in the main section. One of these needs to be corrected so both locations describe the same conditions.

Should fix -- Avoid internal language:
The FAQ uses the phrase "manage my team intent," where "intent" is developer/internal terminology. Users would not recognize this term. Consider rephrasing to something like: "you selected manage my team during onboarding."

Should fix -- Discover conditional qualifier removed:
The diff changes Discover from "(when applicable)" to unconditional in the bullet list under "What Home shows." However, the existing content and FAQ both state that Discover auto-hides after watching the demo, which means it is conditional. The "(when applicable)" qualifier should likely remain.

Positive aspects:

  • The new heading "How the Getting started section works on Home" follows the exact pattern of all other section headings in the article -- consistent and compliant.
  • The FAQ heading "Why don't I see the Getting started section?" follows the question-word pattern used by other FAQ entries.
  • Keywords and internalScope metadata are properly updated to reflect the new content.
  • The new section is placed in logical order between "Spend over time" and "Discover."

Recommendations

  1. Reconcile the visibility conditions between the main section and the FAQ so they describe the same requirements. Determine whether the conditions are (a) free trial + manage my team, or (b) manage my team + within 60 days + active paid workspace, and update both locations to match.
  2. Remove "intent" from the FAQ phrasing -- replace with user-facing language.
  3. Re-evaluate removing "(when applicable)" from Discover in the bullet list, since the section does conditionally disappear.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md -- New "Getting started" section and FAQ entry added; metadata updated. Requires fixes for internal consistency before approval.

Review based on governance rules in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95709ad664

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +89 to +90
- The workspace is on a free trial
- The workspace owner selected **manage my team** during setup

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct Getting started visibility window

This section says Getting started appears only while a workspace is on a free trial, but the product logic shows it for up to 60 days after NVP_FIRST_DAY_FREE_TRIAL (isWithinGettingStartedPeriod in src/pages/home/GettingStartedSection/utils/isWithinGettingStartedPeriod.ts), alongside paid-policy/admin checks in useGettingStartedItems. For admins past day 30 but before day 60, this article currently explains the opposite of what they see in-app, which will drive avoidable support confusion.

Useful? React with 👍 / 👎.

@stephanieelliott stephanieelliott self-assigned this Apr 22, 2026

@zanyrenney zanyrenney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, solid updates.

@zanyrenney
zanyrenney merged commit 43b4bf2 into main Apr 22, 2026
25 checks passed
@zanyrenney
zanyrenney deleted the claude-addGettingStartedSectionToHomeOverview branch April 22, 2026 09:30
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.3.62-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.3.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@arosiclair arosiclair mentioned this pull request Apr 29, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants