Repository navigation
[No QA] Update Home Overview help article for Getting started section - #87572
Conversation
Add the new Getting started onboarding checklist section to the Expensify Home Overview help article, including visibility rules, checklist items, and an FAQ entry. Co-authored-by: Adam Grzybowski <adamgrzybowski@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://4742fa4b.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @zanyrenney |
|
@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| The **Getting started** section shows a checklist of key setup steps to help Workspace Admins configure their workspace during onboarding. | ||
|
|
||
| This section appears only if: | ||
|
|
||
| - The workspace is on a free trial | ||
| - The workspace owner selected **manage my team** during setup | ||
|
|
There was a problem hiding this comment.
Content inconsistency: The conditions listed here (free trial + selected "manage my team" during setup) do not match the conditions in the FAQ answer below ("manage my team" intent + within 60 days of free trial start date + active paid workspace). The FAQ lists three conditions while this section lists only two. These should be aligned so users get consistent information. Consider updating one or both to reflect the complete, accurate set of conditions.
| - **Spend over time** (when applicable) | ||
| - **Discover** (when applicable) | ||
| - **Getting started** (when applicable) | ||
| - **Discover** |
There was a problem hiding this comment.
Readability / accuracy: The "(when applicable)" qualifier was removed from Discover, but the Discover section later in the article states it is "automatically hidden from Home" once the user watches the demo. This means Discover is conditional and does not always appear. Consider keeping "(when applicable)" to stay consistent with the section's described behavior.
HelpDot Documentation ReviewOverall AssessmentThis PR adds documentation for the new Getting started section on Home, including a content section explaining how it works and a corresponding FAQ entry. The additions follow the established patterns in the article well. However, there is an internal consistency issue between the main section and the FAQ that must be resolved before merging. Scores Summary
Key FindingsMust fix -- Conflicting visibility conditions:
The FAQ ("Why don't I see the Getting started section?") states three conditions:
These do not align. The FAQ adds a 60-day window and an "active paid workspace" requirement not mentioned in the main section. One of these needs to be corrected so both locations describe the same conditions. Should fix -- Avoid internal language: Should fix -- Discover conditional qualifier removed: Positive aspects:
Recommendations
Files Reviewed
Review based on governance rules in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95709ad664
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - The workspace is on a free trial | ||
| - The workspace owner selected **manage my team** during setup |
There was a problem hiding this comment.
Correct Getting started visibility window
This section says Getting started appears only while a workspace is on a free trial, but the product logic shows it for up to 60 days after NVP_FIRST_DAY_FREE_TRIAL (isWithinGettingStartedPeriod in src/pages/home/GettingStartedSection/utils/isWithinGettingStartedPeriod.ts), alongside paid-policy/admin checks in useGettingStartedItems. For admins past day 30 but before day 60, this article currently explains the opposite of what they see in-app, which will drive avoidable support confusion.
Useful? React with 👍 / 👎.
zanyrenney
left a comment
There was a problem hiding this comment.
This all looks good, solid updates.
|
🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.3.62-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.3.64-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀
|
Explanation of Change
Updates the Expensify Home Overview help article to document the new Getting started onboarding checklist section added in #86663. This section guides new Workspace Admins through key setup steps during their free trial.
Changes to
Expensify-Home-Overview.md:Fixed Issues
$ #86663
Tests
docs/articles/new-expensify/getting-started/Expensify-Home-Overview.mdOffline tests
N/A — documentation-only change.
QA Steps
[No QA]
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — documentation-only change.
Android: mWeb Chrome
N/A — documentation-only change.
iOS: Native
N/A — documentation-only change.
iOS: mWeb Safari
N/A — documentation-only change.
MacOS: Chrome / Safari
N/A — documentation-only change.