Skip to content

fix "QuickBooks Desktop setup" page is not scrollable #87788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangrous merged 4 commits into from
Apr 16, 2026
Merged

fix "QuickBooks Desktop setup" page is not scrollable #87788

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d23a80a
add ScrollView to RequireQuickBooksDesktopPage
jakubstec Apr 13, 2026
aacdd74
apply review changes and add gap between components
jakubstec Apr 14, 2026
245477c
rerun tests
jakubstec Apr 15, 2026
8f04f8f
Merge remote-tracking branch 'origin/main' into jakubstec/fix-QBD-pag…
jakubstec Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/pages/workspace/accounting/qbd/RequireQuickBooksDesktopPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import FixedFooter from '@components/FixedFooter';
import HeaderWithBackButton from '@components/HeaderWithBackButton';
import ImageSVG from '@components/ImageSVG';
import ScreenWrapper from '@components/ScreenWrapper';
import ScrollView from '@components/ScrollView';
import Text from '@components/Text';
import {useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
import useLocalize from '@hooks/useLocalize';
Expand All @@ -28,16 +29,16 @@ function RequireQuickBooksDesktopModal() {
shouldShowBackButton
onBackButtonPress={() => Navigation.goBack()}
/>
<View style={[styles.flex1]}>
<View style={[styles.flex1, styles.justifyContentCenter, styles.ph5]}>
<View style={[styles.flex1, styles.gap2]}>
<ScrollView contentContainerStyle={[styles.flexGrow1, styles.justifyContentCenter, styles.ph5]}>
<View style={[styles.alignSelfCenter, styles.pendingStateCardIllustration]}>
<ImageSVG src={illustrations.LaptopWithSecondScreenX} />
</View>

<Text style={[styles.textAlignCenter, styles.textHeadlineH1, styles.pt5]}>{translate('workspace.qbd.requiredSetupDevice.title')}</Text>
<Text style={[styles.textAlignCenter, styles.textSupporting, styles.textNormal, styles.pt3]}>{translate('workspace.qbd.requiredSetupDevice.body1')}</Text>
<Text style={[styles.textAlignCenter, styles.textSupporting, styles.textNormal, styles.pt4]}>{translate('workspace.qbd.requiredSetupDevice.body2')}</Text>
</View>
</ScrollView>
<FixedFooter addBottomSafeAreaPadding>
<Button
success
Expand Down
Loading