Repository navigation
Use accounting integration bank accounts for reconciliation #87916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e7a1d1b
using connection accounts
rlinoz 7ebdfba
add SetCardReconciliationBankAccount
rlinoz 4bec378
actually select the bank account
rlinoz 7b8db11
correct api
rlinoz 5d300bc
failure data
rlinoz 98e78e6
cleanup and typecheck
rlinoz 5e38a49
more cleanup
rlinoz cb126ab
merge main
rlinoz 3a1d622
add tests
rlinoz 310a20e
merge main
rlinoz 58d9f8c
fix mobile-expensify
rlinoz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
src/libs/API/parameters/SetCardReconciliationBankAccountParams.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| type SetCardReconciliationBankAccountParams = { | ||
| domainName: string; | ||
| expensifyCardIntegrationWithdrawalID: string; | ||
| }; | ||
|
|
||
| export default SetCardReconciliationBankAccountParams; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This screen reads/writes
EXPENSIFY_CARD_RECONCILIATION_BANK_ACCOUNT_IDusingworkspaceAccountID, butCardReconciliationPagereads the same setting usingeffectiveDomainID(derived from the active card feed/domain). When those IDs differ (for example, domain-linked feeds whereworkspaceAccountIDcan be0), the selected reconciliation account is stored under a different Onyx key than the one the parent page consumes, so the chosen account won’t appear selected/titled correctly after navigation and optimistic updates can be applied to the wrong entry.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this could be a legit concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this, will probably update tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole backend is wired looking at
workspaceAccountIDsee https://github.com/Expensify/Auth/blob/3ff45143231e21f4c387bc5a07b3ea9ea401ede3/auth/command/OpenPolicyAccountingPage.cpp#L45 and https://github.com/Expensify/Auth/blob/3ff45143231e21f4c387bc5a07b3ea9ea401ede3/auth/command/ToggleCardContinuousReconciliation.cpp#L53
I think there was an effort to try to make this sync with OldDot, but didn't finish or wasn't mantained? Not sure #61605
But regarding this PR I think this is fine to use
workspaceAccountIDhere and if we want to make this cross compatible we should get an issue for it to update everything that is necessary.