Repository navigation
Use a larger button for multi-select on web #88146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4900,8 +4900,10 @@ const staticStyles = (theme: ThemeColors) => | |
| minHeight: variables.componentSizeSmall, | ||
| }, | ||
|
|
||
| // The filter bar row is 34px tall, but the default (larger) bulk-action button is 40px. | ||
| // To keep the bar from growing, we pull the button up/down by half the difference: (40 - 34) / 2 = 3. | ||
| searchBulkActionsButton: { | ||
| marginVertical: 3, | ||
| marginVertical: -3, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❌ CONSISTENCY-2 (docs)The value Define a named constant or add a comment explaining why // Negative margin compensates for the larger default button size
// to keep the bulk actions bar at the same height
const SEARCH_BULK_ACTIONS_BUTTON_VERTICAL_OFFSET = -3;
searchBulkActionsButton: {
marginVertical: SEARCH_BULK_ACTIONS_BUTTON_VERTICAL_OFFSET,
},Reviewed at: ed27170 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MelvinBot can you implement that suggestion? Can you also explain in that comment that we arrived at that number because the current height of the view is 34. The bigger button is 40, which is 6 more. That means we need to pull the button up by half of the difference, so 6/2 is 3.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MelvinBot you are an assignee now, please retry this request |
||
| }, | ||
|
|
||
| filtersBar: { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
buttonSize={CONST.DROPDOWN_BUTTON_SIZE.SMALL}here makesButtonWithDropdownMenufall back toMEDIUMfor every wide-layout client, not just web.SearchPagechooses wide vs narrow usingshouldUseNarrowLayout(width-based), so iOS/Android tablets also execute this path and get the larger control (plus the accompanying spacing offset instyles.searchBulkActionsButton), which conflicts with the stated goal of a web-only visual tweak and can regress native tablet layout consistency.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I don't mean web-only, I actually mean wide screen only. So I think we're good here.