Repository navigation
Fix stale duplicate violation persisting after editing transaction amount offline #88298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 12 commits into
Expensify:main
from
fedirjh:fedy/fix-bidirectional-duplicate-violation-cleanup
Apr 27, 2026
+156
−3
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f776c3b
fix: filter one-sided duplicate violations at display time
fedirjh 02231e3
test: add unit tests for shouldShowDuplicateViolation
fedirjh 3cea558
refactor: simplify isDuplicate to derive violations from collection
fedirjh fc3e0b4
fix: avoid defaulting string ID to empty value in useTransactionViola…
fedirjh f6bb7e7
fix: add bidirectional violation data to tests and document collectio…
fedirjh e7f7849
revert: remove display-time bidirectional filter approach
fedirjh 2ca772d
fix: re-apply cleaned partner violations via successData to prevent s…
fedirjh 10c2c41
test: add unit tests for successData in removeTransactionFromDuplicat…
fedirjh 6080693
Merge branch 'Expensify:main' into fedy/fix-bidirectional-duplicate-v…
fedirjh fa419eb
fix: preserve non-duplicate violations when cleaning partner successData
fedirjh 3a3e640
Merge branch 'Expensify:main' into fedy/fix-bidirectional-duplicate-v…
fedirjh 8396ac6
Merge branch 'Expensify:main' into fedy/fix-bidirectional-duplicate-v…
fedirjh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.