Repository navigation
Conversation
When a user leaves a report, the Pusher round-trip for REPORT_USER_IS_LEAVING_ROOM can be slower than the API success response that wipes the report data. This creates a window where ReportNotFoundGuard sees reportExists=false and shows the "Not here" page. Setting the leaving status optimistically in Onyx as part of leaveRoom's optimistic data ensures the guard always has at least one true signal during the leave transition. Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
2 of 7 tasks
Contributor
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a user leaves an IOU report,
leaveRoom()relies on a Pusher round-trip to setREPORT_USER_IS_LEAVING_ROOMin Onyx. However, the API success response can arrive before the Pusher event completes, wiping the report data (reportIDandstatusNum) viaOnyx.METHOD.SET. This creates a window whereReportNotFoundGuardseesreportExists = false(all three conditions —!!reportID,isOptimisticDelete,userLeavingStatus— are false), causing the "Not here" page to flash.This PR sets
REPORT_USER_IS_LEAVING_ROOMoptimistically as part ofleaveRoom()'s Onyx optimistic data, ensuring the guard always has at least onetruesignal during the entire leave transition regardless of Pusher timing. On API failure, it resets back tofalse.Fixed Issues
$ #88420
PROPOSAL: #88420 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.AI Tests
npm run typecheck-tsgonpm run lint-changednpm test -- --testPathPattern="tests/.*Report"npx prettierPre-existing lint warnings (4x
rulesdir/no-onyx-connect) are unrelated to this change.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari