Skip to content

Revert "Show migrated user welcome modal immediately and navigate to Home on dismiss" - #88687

Merged
rlinoz merged 1 commit into
mainfrom
revert-86733-claude-fixMigratedUserWelcomeModal
Apr 24, 2026
Merged

rlinoz merged 1 commit into
mainfrom
revert-86733-claude-fixMigratedUserWelcomeModal

Conversation

@roryabraham

@roryabraham roryabraham commented Apr 24, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #86733

$ #88686

@roryabraham
roryabraham requested review from a team as code owners April 24, 2026 06:39
@melvin-bot
melvin-bot Bot requested review from AndrewGable and trjExpensify and removed request for a team April 24, 2026 06:39
@melvin-bot

melvin-bot Bot commented Apr 24, 2026

Copy link
Copy Markdown

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@roryabraham roryabraham changed the title Revert "Show migrated user welcome modal immediately and navigate to Home on dismiss" [HOLD] Revert "Show migrated user welcome modal immediately and navigate to Home on dismiss" Apr 24, 2026
@roryabraham

Copy link
Copy Markdown
Contributor Author

hold for testing

@github-actions

This comment has been minimized.

@IuliiaHerets

Copy link
Copy Markdown

@roryabraham issue is not repro, comment

@rlinoz

rlinoz commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Removing HOLD and merging

@rlinoz rlinoz changed the title [HOLD] Revert "Show migrated user welcome modal immediately and navigate to Home on dismiss" Revert "Show migrated user welcome modal immediately and navigate to Home on dismiss" Apr 24, 2026
@rlinoz
rlinoz merged commit 7e55b29 into main Apr 24, 2026
45 of 50 checks passed
@rlinoz
rlinoz deleted the revert-86733-claude-fixMigratedUserWelcomeModal branch April 24, 2026 14:10
@melvin-bot

melvin-bot Bot commented Apr 24, 2026

Copy link
Copy Markdown

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@rlinoz

rlinoz commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

straight revert

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Apr 24, 2026
…tedUserWelcomeModal

Revert "Show migrated user welcome modal immediately and navigate to Home on dismiss"

(cherry picked from commit 7e55b29)

(cherry-picked to staging by roryabraham)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 24, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.62-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

This is a revert of internal navigation behavior (proactively showing the migrated user welcome modal and navigating to Home on dismiss). The help site has no articles documenting this modal's behavior, and the changes are purely implementation-level — no user-facing feature, setting, or workflow was added or removed.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.62-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@m-natarajan

Copy link
Copy Markdown

@roryabraham @rlinoz Revert PR, OK to checkoff?

@rlinoz

rlinoz commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

yep just did.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@arosiclair arosiclair mentioned this pull request Apr 29, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants