Skip to content

Revert "perf: navigate before optimistic writes in Search onSelectRow" - #88980

Merged
rlinoz merged 1 commit into
mainfrom
revert-87982-search-open-report/start-transition
Apr 27, 2026
Merged

rlinoz merged 1 commit into
mainfrom
revert-87982-search-open-report/start-transition

Conversation

@rlinoz

@rlinoz rlinoz commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #87982

$ #88974

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88980.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://88980.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Apr 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/Search/index.tsx 0.92% <0.00%> (+<0.01%) ⬆️
... and 11 files with indirect coverage changes

@rlinoz
rlinoz marked this pull request as ready for review April 27, 2026 18:22
@rlinoz
rlinoz requested review from a team as code owners April 27, 2026 18:22
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team April 27, 2026 18:22
@melvin-bot
melvin-bot Bot requested a review from chiragsalian April 27, 2026 18:23
@melvin-bot
melvin-bot Bot removed the request for review from a team April 27, 2026 18:23
@melvin-bot

melvin-bot Bot commented Apr 27, 2026

Copy link
Copy Markdown

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rlinoz
rlinoz merged commit e07f6f6 into main Apr 27, 2026
49 of 55 checks passed
@rlinoz
rlinoz deleted the revert-87982-search-open-report/start-transition branch April 27, 2026 18:23
@melvin-bot

melvin-bot Bot commented Apr 27, 2026

Copy link
Copy Markdown

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Apr 27, 2026
@rlinoz

rlinoz commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

no emergency, straight revert

@rlinoz rlinoz removed the Emergency label Apr 27, 2026
OSBotify pushed a commit that referenced this pull request Apr 27, 2026
…ort/start-transition

Revert "perf: navigate before optimistic writes in Search onSelectRow"

(cherry picked from commit e07f6f6)

(cherry-picked to staging by roryabraham)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 27, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.62-13 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

I reviewed the changes in this PR. It reverts a performance optimization in src/components/Search/index.tsx (reordering navigation calls, replacing startTransition with requestAnimationFrame). These are purely internal code changes with no impact on user-facing features, UI labels, or workflows.

No help site documentation changes are required.

@m-natarajan

Copy link
Copy Markdown

@rlinoz @srikarparsi No QA steps and revert PR, Ok to check off this one?

@srikarparsi

Copy link
Copy Markdown
Contributor

Yes okay to check this one off, it's a straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.63-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@arosiclair arosiclair mentioned this pull request Apr 29, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants