[mohammadjafarinejad]

This reverts commit 78be79e.

Explanation of Change

This PR reapplies #83127 (inline editing for tables on desktop), which was reverted in #88751, with the original issues fixed and additional improvements.

Fixed Issues

$ #82534
$ #88711
PROPOSAL: #82534 (comment)

Tests

1. Open the app and navigate to the Search/Expenses table on desktop (wide layout)
2. Click a date cell on any transaction row — verify a date picker popover appears anchored to the cell
3. Select a new date — verify the cell updates and the popover closes
4. Click a merchant cell — verify it becomes an inline text input with the current value pre-filled
5. Edit the text and click away (blur) — verify the new value is saved and the cell returns to display mode
6. Repeat steps 4–5 for description and amount cells
7. Click a category cell — verify the category picker popover appears
8. Select a category — verify the cell updates and the popover closes
9. Click a cell on a row where editing is not permitted (e.g. no policy) — verify no edit mode is triggered

• Verify that no errors appear in the JS console

Offline tests

1. Disable network connection
2. Edit a cell value — verify the optimistic update is reflected immediately in the UI
3. Re-enable network — verify the value syncs correctly with the backend

QA Steps

Same as tests.

Please follow the deploy blocker steps outlined in:

• [Tracking]] In-line table editing deploy blockers. #88711

The following issues will be addressed in follow-up PRs, so QA can be skipped for them:

• [Due for payment 2026-10-27] [$175] Reports - Category picker is opened overlapping the "Category" cell during inline editing. #88681

• Spend-The newly added expense highlights every time updating other expense #88659

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/App.tsx	100.00% <ø> (ø)
src/CONST/index.ts	92.30% <ø> (ø)
src/components/CategoryPicker/index.tsx	3.44% <ø> (ø)
src/components/DatePicker/CalendarPicker/index.tsx	96.57% <100.00%> (+0.02%)	⬆️
src/components/Modal/BaseModal.tsx	87.68% <100.00%> (+0.18%)	⬆️
src/components/MoneyRequestAmountInput.tsx	74.07% <100.00%> (+0.48%)	⬆️
src/components/Search/SearchContext.tsx	50.00% <100.00%> (+0.42%)	⬆️
...components/Search/SearchList/ListItem/DateCell.tsx	100.00% <100.00%> (ø)
src/components/Search/SearchTableHeader.tsx	50.57% <ø> (ø)
...omponents/Table/EditableCell/useInlineEditState.ts	100.00% <100.00%> (ø)
... and 33 more
... and 246 files with indirect coverage changes

[trjExpensify]

@mohammadjafarinejad when can you have this ready for review?

[dubielzyk-expensify]

And let us know when we can adhoc test build 😄

[trjExpensify]

Bump @mohammadjafarinejad. Can we get daily updates please to get this back out?

[trjExpensify]

Bump again @mohammadjafarinejad. Please provide an update.

[mohammadjafarinejad]

@trjExpensify I'll have it ready for review by tomorrow, after I test it to make sure all bugs are fixed.

[trjExpensify]

Okay, thank you.

[MelvinBot]

I reviewed the changes in this PR and found that help site updates are needed. Two articles required updates:

1. Getting Started with the Spend Page — The inline editing section listed date, merchant, description, category, and amount as editable fields, but was missing tag (which this PR adds).
2. Edit Expenses — Had no mention of inline editing at all. Added a tip about editing cells directly from the table on desktop.

Draft PR created: #90813

[jponikarchuk]

Deploy Blocker #90814 was identified to be related to this PR.

[lanitochka17]

Deploy Blocker ##90815 was identified to be related to this PR

[jponikarchuk]

Deploy Blocker #90816 was identified to be related to this PR.

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[mitarachim]

Deploy Blocker #90853 was identified to be related to this PR.
I’m a bit unsure because when I checked the build in this PR, I could still enter a negative sign in step 9 in this issue .

Screen.Recording.2026-05-16.at.7.49.23.AM.mov

[jponikarchuk]

Deploy Blocker #90862 was identified to be related to this PR.

[lanitochka17]

Deploy Blocker ##90997 was identified to be related to this PR.

[tgolen]

@mohammadjafarinejad @puneetlath None of these connectWithoutView() references should be here. They need to be refactored and removed to be pure functions.

[puneetlath]

Oh, thanks for pointing that out. @mohammadjafarinejad @ahmedGaber93 can you take care of that in your follow-up?

[ahmedGaber93]

Added to the follow-ups list.

[brunovjk]

The unconditional Wide RHP subscription appears to cause main-pane cell rerenders. Scope subscriptions to RHP cells and verify render counts when toggling the panel. Fixed here.