Skip to content

Revert "[CP Staging] fix Deeplink - App is stuck on splash screen when navigating to a public room as anon user" #89206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mollfpr wants to merge 1 commit into from
Closed

Revert "[CP Staging] fix Deeplink - App is stuck on splash screen when navigating to a public room as anon user" #89206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions src/DeepLinkHandler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ function DeepLinkHandler({onInitialUrl}: DeepLinkHandlerProps) {
const linkingChangeListener = useRef<NativeEventSubscription | null>(null);
const initialUrlProcessed = useRef(false);

const [allReports, allReportsMetadata] = useOnyx(ONYXKEYS.COLLECTION.REPORT);
const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT);
const [, sessionMetadata] = useOnyx(ONYXKEYS.SESSION);
const [conciergeReportID, conciergeReportIDMetadata] = useOnyx(ONYXKEYS.CONCIERGE_REPORT_ID);
const [introSelected, introSelectedMetadata] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED);
const [conciergeReportID] = useOnyx(ONYXKEYS.CONCIERGE_REPORT_ID);
const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED);
const [isSelfTourViewed, isSelfTourViewedMetadata] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {selector: hasSeenTourSelector});
const [betas, betasMetadata] = useOnyx(ONYXKEYS.BETAS);
const [betas] = useOnyx(ONYXKEYS.BETAS);
const isAuthenticated = useIsAuthenticated();

useEffect(() => {
if (isLoadingOnyxValue(allReportsMetadata, sessionMetadata, conciergeReportIDMetadata, introSelectedMetadata, isSelfTourViewedMetadata, betasMetadata)) {
if (isLoadingOnyxValue(sessionMetadata, isSelfTourViewedMetadata)) {
return;
}

Expand Down Expand Up @@ -111,17 +111,7 @@ function DeepLinkHandler({onInitialUrl}: DeepLinkHandlerProps) {
linkingChangeListener.current?.remove();
};
// eslint-disable-next-line react-hooks/exhaustive-deps -- intentionally excluding allReports, isAuthenticated, and onInitialUrl to avoid re-triggering deep link handling on every report update
}, [
conciergeReportID,
introSelected,
betas,
allReportsMetadata.status,
sessionMetadata.status,
conciergeReportIDMetadata.status,
introSelectedMetadata.status,
isSelfTourViewedMetadata.status,
betasMetadata.status,
]);
}, [sessionMetadata?.status, conciergeReportID, introSelected, isSelfTourViewedMetadata, betas]);

// Safety net: if getInitialURL() resolves before the session loads, hasAuthToken() may return false
// for an authenticated user, causing openReportFromDeepLink to take the wrong path. Once isAuthenticated
Expand Down
Loading