Repository navigation
Revert "Fix issue: Spend - New report does not appear in the background after moving expense to new report" - #89291
Conversation
…nd after moving expense to new report"
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9abd432d71
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const isSearchStillActive = isFocused || isSearchTopmostFullScreenRoute(); | ||
| if (!isSearchStillActive || isOffline) { | ||
| // If we're not focused or offline, don't trigger search | ||
| if (!isFocused || isOffline) { |
There was a problem hiding this comment.
Keep Search refetching when RHP overlays fullscreen Search
This focus gate regresses the fullscreen Search + RHP flow: when a user opens an RHP action (for example moving an expense to a new report), useIsFocused() becomes false even though Search is still the active fullscreen route, so this effect only marks hasPendingSearchRef and never refetches until RHP closes. In that state, newly created/moved items do not appear in the background Search snapshot, which breaks the expected live update behavior while the user is still in the Search context.
Useful? React with 👍 / 👎.
|
This will re-introduce #88972 |
|
oops i meant to close it. And yeah i agree, we cannot straight revert. Any suggestions on next steps welcome here https://expensify.slack.com/archives/C0B0K40D0KY/p1777558632919569 @mkhutornyi |
Reverts #89088