Skip to content

Revert "Fix issue: Spend - New report does not appear in the background after moving expense to new report" - #89291

Closed
chiragsalian wants to merge 1 commit into
mainfrom
revert-89088-@adamgrzybowski/fix-search-snapshot-refresh-from-rhp
Closed

chiragsalian wants to merge 1 commit into
mainfrom
revert-89088-@adamgrzybowski/fix-search-snapshot-refresh-from-rhp

Conversation

@chiragsalian

Copy link
Copy Markdown
Contributor

Reverts #89088

@chiragsalian chiragsalian self-assigned this Apr 30, 2026
@chiragsalian
chiragsalian marked this pull request as ready for review April 30, 2026 17:13
@chiragsalian
chiragsalian requested review from a team as code owners April 30, 2026 17:13
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and madmax330 and removed request for a team April 30, 2026 17:13
@melvin-bot

melvin-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team April 30, 2026 17:13
@codecov

codecov Bot commented Apr 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/hooks/useSearchHighlightAndScroll.ts 82.96% <100.00%> (-0.13%) ⬇️
... and 14 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9abd432d71

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

const isSearchStillActive = isFocused || isSearchTopmostFullScreenRoute();
if (!isSearchStillActive || isOffline) {
// If we're not focused or offline, don't trigger search
if (!isFocused || isOffline) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Search refetching when RHP overlays fullscreen Search

This focus gate regresses the fullscreen Search + RHP flow: when a user opens an RHP action (for example moving an expense to a new report), useIsFocused() becomes false even though Search is still the active fullscreen route, so this effect only marks hasPendingSearchRef and never refetches until RHP closes. In that state, newly created/moved items do not appear in the background Search snapshot, which breaks the expected live update behavior while the user is still in the Search context.

Useful? React with 👍 / 👎.

@mkhutornyi

Copy link
Copy Markdown
Contributor

This will re-introduce #88972

@chiragsalian

Copy link
Copy Markdown
Contributor Author

oops i meant to close it. And yeah i agree, we cannot straight revert. Any suggestions on next steps welcome here https://expensify.slack.com/archives/C0B0K40D0KY/p1777558632919569 @mkhutornyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants