Repository navigation
Update workspaces page to use the table component - #90204
Conversation
…p into jsenyitko-workspace-tables
…p into jsenyitko-workspace-tables
…p into jsenyitko-workspace-tables
|
Lets not block on that issue then, I'm not able to see it locally, lets see if QA sees the same thing |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hybrid.mp4Android: mWeb Chromeandroid_mWeb.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
Krishna2323
left a comment
There was a problem hiding this comment.
LGTM! ![]()
The failing checks are not related.
|
@grgia could I bother you with another approval 🙇🏻 |
|
Merging since @grgia mentioned no blockers |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.91-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR against Expensify's help site files under WhyThis PR splits Workspaces and Domains into two separate tabs (domains were previously a section within the combined Workspaces list) and redesigns the domains empty state. Several domain articles still describe the old navigation and labels:
I verified all tab names, the empty state title/subtitle, and button labels against the live UI before writing. Draft help site PR📝 #92317 Files updated:
@JS00001, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #92353 was identified to be related to this PR. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.94-0 🚀
Bundle Size Analysis (Sentry): |
HelpDot review — changes requiredYes, this PR requires help site updates. It reworks the Workspaces list page so that Workspaces and Domains are now separate tabs (a horizontal tab selector), replacing the previous setup where Domains appeared as an Enhanced security section under Workspaces that got relabeled to Domains after a domain was claimed. The domains empty state was also restyled (new title and button). I verified the new navigation, tabs, and labels against the live UI before writing. Draft help site PR: #92438 What changed in the docs and whyThe PR makes these user-facing changes that the existing articles documented incorrectly:
Articles updated:
@JS00001, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.94-0 🚀
|
Reflect the UI change in Expensify#90204 where Workspaces and Domains were split into separate tabs and the domains empty state was redesigned. Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
Explanation of Change
Update the tables for workspaces/domains to the new styles:
Note, some of the mocks wont match perfectly, we are only updating the table, and adding the sidebar for separating domains and workspaces.
Fixed Issues
$ #89228
Tests
Validate the same behavior expected of the tables on production
Click on the table header for workspaces
Ensure that the workspaces are sorted by name
Click on the table header for domains
Ensure that the domains are sorted by name
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Screen.Recording.2026-05-19.at.10.40.05.AM.mov