Repository navigation
[No QA] Add Pre-Booking Approval docs to travel help articles - #91355
Conversation
Update Setting Approval Types and Approving Travel articles to document the new Pre-Booking Approval group policy action. Includes approver workflow, post-approval expectations, FAQ entries, and heading level fixes per HelpDot template standards. Co-authored-by: Sheena Trepanier <strepanier03@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR adds documentation for the new Pre-Booking Approval travel policy feature across two help articles. It also performs significant governance cleanup on the existing content -- fixing heading hierarchies, replacing non-compliant terminology, reformatting FAQ sections, and cleaning up trailing whitespace. The new content is well-structured and clearly explains a multi-step approval workflow. Overall, this is a strong PR that improves both files substantially. Scores Summary
Key FindingsPositive aspects:
Items to address:
Recommendations
Files Reviewed
Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Adding-Members.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…Adding-Members.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Okay this is ready for review! |
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://28242551.helpdot.pages.dev ⚡️ Updated articles: |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@kadiealexander looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
|
||
| Set this up under: | ||
|
|
||
| - Approvers can set their own secondary approver under **User icon** > **My profile** > **Configuration** > **Approval Settings**. Click Add Approver to designate a secondary approver who can approve on your behalf. You may add multiple secondary approvers. |
There was a problem hiding this comment.
Button naming violation: "Click Add Approver" should bold the button name to match the button naming standards. The second bullet in this same section correctly bolds Add approver, but this first bullet does not.
Suggested fix: Click **Add Approver** to designate a secondary approver...
HelpDot Documentation ReviewOverall AssessmentThis PR makes strong, governance-aligned improvements to two travel documentation files. The changes add Pre-Booking Approval content, fix heading hierarchy (eliminating Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.3.80-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|
Explanation of Change
Adds documentation for the new Pre-Booking Approval travel policy feature across two help articles:
Setting-Approval-Types-and-Adding-Members.md:
###to##per HelpDot template standardsApproving-Travel.md:
#to##for content sections per HelpDot template standardsFixed Issues
$ https://github.com/Expensify/Expensify/issues/639554
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A - documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - documentation-only change.
Android: mWeb Chrome
N/A - documentation-only change.
iOS: Native
N/A - documentation-only change.
iOS: mWeb Safari
N/A - documentation-only change.
MacOS: Chrome / Safari
N/A - documentation-only change.