Repository navigation
[CP Staging] Revert "Fix required tags state after switching tag levels" - #91548
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
(cherry picked from commit c2ccc8e) (cherry-picked to staging by mountiny)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.81-0 🚀
|
|
No help site changes are required for this PR. This is a revert of #89147 that fixes a regression (#91483) where the Tags toggle remains disabled after disabling "Members must tag all expenses." The changes are purely internal code-level fixes:
The existing help site articles (Create and manage expense tags and Require tags and categories for expenses) don't reference any of the internal behavior being reverted. The user-facing functionality (enabling tags, importing tags, requiring tags) is unchanged — this is a bug fix, not a feature change. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|
This reverts the changes from #89147 (merge commit 2703b90).
The reverted PR introduced a regression tracked in #91483 where the Tags toggle remains disabled after disabling "Members must tag all expenses".
Fixed Issues
#91483
Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari