Skip to content

Update onyx - #9160

Merged
AndrewGable merged 2 commits into
mainfrom
cmartins-onyx
May 25, 2022
Merged

AndrewGable merged 2 commits into
mainfrom
cmartins-onyx

Conversation

@luacmartins

@luacmartins luacmartins commented May 24, 2022 •

Copy link
Copy Markdown
Contributor

Details

Updates Onyx
Context for removing Onyx from webpack includeModules - #9163 (comment)

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/211233

Tests

  1. Run npm i and verify that the app still works
  • Verify that no errors appear in the JS console

QA Steps

  1. Launch the app and verify that it works
  • Verify that no errors appear in the JS console

@luacmartins luacmartins self-assigned this May 24, 2022
@melvin-bot

melvin-bot Bot commented May 25, 2022

Copy link
Copy Markdown

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@luacmartins
luacmartins marked this pull request as ready for review May 25, 2022 15:44
@luacmartins
luacmartins requested a review from a team as a code owner May 25, 2022 15:44
@melvin-bot
melvin-bot Bot requested review from madmax330 and removed request for a team May 25, 2022 15:44
@AndrewGable
AndrewGable merged commit db7a1b7 into main May 25, 2022
@AndrewGable
AndrewGable deleted the cmartins-onyx branch May 25, 2022 17:15
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request May 25, 2022
13 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @AndrewGable in version: 1.1.67-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.67-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants