Skip to content

fix: sign out user when session expires - #91619

Merged
marcochavezf merged 28 commits into
Expensify:mainfrom
nabi-ebrahimi:fix/session-expiration-signout
Jun 17, 2026
Merged

marcochavezf merged 28 commits into
Expensify:mainfrom
nabi-ebrahimi:fix/session-expiration-signout

Conversation

@nabi-ebrahimi

@nabi-ebrahimi nabi-ebrahimi commented May 25, 2026 •

Copy link
Copy Markdown

Explanation of Change

When short-lived auth tokens (used for support/delegate sessions) expire, the app previously got stuck unable to re-authenticate, requiring users to sign out and back in manually. This change detects when the auth process has completed, but stale state flags remain, clears them, and allows normal re-authentication to proceed automatically.

Fixed Issues

$ #90544
PROPOSAL: #90544 (comment)

Tests

  1. Open any chat
  2. Open DevTools → Console.
  3. Run:
(async () => {
    const session = await window.Onyx.get('session');

    localStorage.setItem('issue90544_originalSession', JSON.stringify(session ?? {}));

    await window.Onyx.merge('session', {
        authToken: 'invalid-auth-token-for-issue-90544',
        encryptedAuthToken: 'invalid-auth-token-for-issue-90544',
        creationDate: Date.now() - 3 * 60 * 60 * 1000,
        isAuthenticatingWithShortLivedToken: true,
    });

    console.log('90544 mock applied. Now send a message or perform another authenticated action.');
})();
  1. Wait 2-3 seconds.
  2. Send a message or try another authenticated action.
  3. Observe for at least 2 minutes.
  4. Verified that the app redirct to login page
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not applicable.

Android: mWeb Chrome

Not applicable.

iOS: Native

Not applicable.

iOS: mWeb Safari

Not applicable.

MacOS: Chrome / Safari
Screen.Recording.2026-05-25.at.6.48.11.PM.mov

@melvin-bot
melvin-bot Bot requested review from brunovjk and heyjennahay and removed request for a team May 25, 2026 14:41
@melvin-bot

melvin-bot Bot commented May 25, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from a team and marcochavezf and removed request for a team May 25, 2026 14:41
@melvin-bot

melvin-bot Bot commented May 25, 2026

Copy link
Copy Markdown

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be102d76e0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/Reauthentication.ts Outdated
// Prevent re-authentication if authentication with shortLiveToken is in progress
if (isAuthenticatingWithShortLivedToken) {
Log.hmmm('[Reauthenticate] Authentication with shortLivedToken is in progress. Re-authentication aborted.', {
if (account?.isLoading) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid clearing short-lived auth state before account is loaded

When isAuthenticatingWithShortLivedToken is true but ONYXKEYS.ACCOUNT has not been hydrated yet, account is undefined so this check falls through to the "stale state" branch and clears the short-lived auth flags. That can happen during startup races (session loaded before account), and then reauthenticate() proceeds with normal credentials that may not exist yet, potentially redirecting the user to sign-in in the middle of a valid short-lived-token login. Previously this path always aborted while short-lived auth was active, so this introduces a real login interruption risk.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented May 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...c/libs/actions/Session/clearShortLivedAuthState.ts 0.00% <0.00%> (ø)
src/libs/Middleware/Reauthentication.ts 79.06% <73.46%> (+6.76%) ⬆️
src/libs/Reauthentication.ts 61.70% <20.83%> (-4.97%) ⬇️
... and 197 files with indirect coverage changes

@brunovjk

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f96b37385

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/Middleware/Reauthentication.ts Outdated
})
.catch((error) => {
if (isExpiredSessionError(error)) {
return handleExpiredSession(request, isFromSequentialQueue, undefined, true).catch((reauthenticationError) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Respect offline state before retrying HTTP 407 auth flow

The new HTTP-407 catch path forces handleExpiredSession(..., true), which bypasses the offline guard and can trigger full reauthentication retries even when the app is already offline by the time reauth starts. In that case, reauthenticate() keeps retrying Authenticate and eventually redirects to sign-in after max retries, whereas the existing body-407 path explicitly avoids reauth while offline. This creates a regression for flaky connections where users can be signed out solely because connectivity dropped right after receiving the 407 response.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this comment @nabi-ebrahimi? I think it makes sense, but I want to know your thoughts. Thank you.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunovjk Thank you for the feedback and for pointing this out. I agree that the HTTP 407 path should respect offline state in the same way as the existing body-407 path. Without this safeguard, unstable network conditions could incorrectly trigger reauthentication retries and potentially sign the user out. I’ve updated the thrown-407 flow to honor the offline check and added regression test coverage for this scenario.

@brunovjk

Copy link
Copy Markdown
Contributor

Using the code snippet you provided, I can reproduce the bug in the last main, still in dev, normally. However, in our PR here, the error message doesn't appear, but we aren't redirected to the login screen.

Screen.Recording.2026-05-26.at.20.18.31.mov

Did everything go well in your tests?

@nabi-ebrahimi

nabi-ebrahimi commented May 28, 2026 •

Copy link
Copy Markdown
Author

Using the code snippet you provided, I can reproduce the bug in the last main, still in dev, normally. However, in our PR here, the error message doesn't appear, but we aren't redirected to the login screen.

@brunovjk, thanks for checking. That matches what I’m seeing as well: on main, the snippet still reproduces the original bug, while in this PR the flow gets stuck before completing the standard expired-session handling. As a result, neither the error message is shown nor the redirect to sign-in occurs. I traced this to the reauthentication edge cases introduced here, and I’ve updated those paths to ensure the session-expiration flow completes consistently. Could you please take another look at this?

@brunovjk

brunovjk commented May 28, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for the updates @nabi-ebrahimi. But it still won't "log out" for me:

Screen.Recording.2026-05-28.at.12.12.56.mov

I have to leave now, when I get back I'll investigate further.

@brunovjk

Copy link
Copy Markdown
Contributor

@nabi-ebrahimi, did everything go well in your tests? Thank you.

@nabi-ebrahimi

Copy link
Copy Markdown
Author

@nabi-ebrahimi, did everything go well in your tests? Thank you.

@brunovjk, thank you for checking.

Yes, everything went well in my testing. I verified the relevant scenarios, and the updated flow behaved as expected in all cases I tested.

@brunovjk

brunovjk commented Jun 1, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
91619_web_chrome.mov

@brunovjk

brunovjk commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

It worked now @nabi-ebrahimi, thank you so much for your hard work.

@brunovjk

Copy link
Copy Markdown
Contributor

Great! I will check ASAP.

@nabi-ebrahimi

Copy link
Copy Markdown
Author

Hi, @brunovjk, I addressed the ESLint failure by isolating the Reauthentication tests into a dedicated test file. Could you please take another look when you have a chance?

@mountiny

Copy link
Copy Markdown
Contributor

@brunovjk can you prioritize this one please?

@brunovjk

Copy link
Copy Markdown
Contributor

@nabi-ebrahimi your mock doesn't seem to work anymore, I changed a bit and was able to test it normally:

(async () => {
    const session = await window.Onyx.get('session');

    localStorage.setItem('issue90544_originalSession', JSON.stringify(session ?? {}));

    await window.Onyx.merge('session', {
        authToken: 'invalid-auth-token-for-issue-90544',
        encryptedAuthToken: 'invalid-auth-token-for-issue-90544',
        creationDate: Date.now() - 3 * 60 * 60 * 1000,
        signedInWithShortLivedAuthToken: true,
        isSupportAuthTokenUsed: true,
    });

    await window.Onyx.set('isAuthenticatingWithShortLivedToken', true);
    await window.Onyx.merge('account', {isLoading: false});

    console.log('0544 mock applied. Now send a message or perform another authenticated action.');
})();

@marcochavezf
marcochavezf merged commit 5d6211d into Expensify:main Jun 17, 2026
33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 17, 2026
67 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no docs changes required.

This PR is an internal auth/session bug fix — it touches only the re-authentication middleware and session-state logic:

  • src/libs/Middleware/Reauthentication.ts
  • src/libs/Reauthentication.ts
  • src/libs/actions/Session/clearShortLivedAuthState.ts
  • tests/unit/ReauthenticationMiddlewareTest.ts

Why no help site update is needed:

  • The change fixes a stuck state when a short-lived (support/delegate) auth token expires, so the app now redirects to the login page automatically instead of requiring a manual sign out / sign in. This restores expected behavior rather than introducing a new feature, setting, tab, button, or user-facing flow.
  • Nothing in App/docs/articles documents this internal re-authentication mechanism, so there's no existing article that becomes inaccurate.
  • The closest user-facing article, Login troubleshooting, already covers session recovery (including "Force a clean sign out") and remains accurate — the fix simply makes the app reach that login state on its own.

No draft PR was created since there are no help site files to change.

@nabi-ebrahimi, let me know if you'd like a docs note added anyway (for example, to the Login troubleshooting article) and I'll open a draft help site PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review — no docs changes required

I reviewed the changes in this PR against the help site articles under docs/articles and concluded that no help site updates are needed, so I did not create a draft PR.

Why: This is a purely internal fix to the re-authentication flow. It changes how the app handles an expired short-lived auth token (support/delegate sessions): instead of getting stuck unable to re-authenticate, the app now detects the completed-but-stale auth state, clears the leftover flags, and gracefully redirects the user to the login page.

  • Changed files are all internal logic + tests: Reauthentication.ts middleware, Reauthentication.ts, clearShortLivedAuthState.ts, and a unit test.
  • There is no new or modified user-facing feature, setting, tab, label, button, or workflow to document — the behavior change (redirect to login on session expiry) is standard expected behavior, not a documented feature.
  • I searched docs/articles for any article describing session expiration / sign-out / re-authentication behavior. The only matches are unrelated integration auth/sync errors (Sage Intacct INT122/INT176, Xero XERO11, personal card connections), none of which describe the App's internal session-token mechanism this PR touches.

If you believe a specific help article should mention this behavior, reply with the article and I'll take another look.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.14-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@mvtglobally

Copy link
Copy Markdown

We are still able to reproduce the original issue.

2026-06-17.23-11-40.mp4

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@nabi-ebrahimi

Copy link
Copy Markdown
Author

We are still able to reproduce the original issue.

Hi @brunovjk, thanks for the feedback.

I'm unable to reproduce this on the latest main. Could you please check again?

Screencast.From.2026-06-19.06-54-35.mp4

@nabi-ebrahimi

Copy link
Copy Markdown
Author

@brunovjk Gentle bump.thanks

@brunovjk

Copy link
Copy Markdown
Contributor

Sorry for the delay, I'll check it out ASAP.

@brunovjk

brunovjk commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

@nabi-ebrahimi—using the mocks we have, the app stays logged in. I wonder if there's a more reliable way to test this?

Screen.Recording.2026-06-23.at.12.54.24.mov

Thanks a lot.

@nabi-ebrahimi

Copy link
Copy Markdown
Author

@nabi-ebrahimi—using the mocks we have, the app stays logged in. I wonder if there's a more reliable way to test this?

@brunovjk Thank you for testing this and sharing your feedback. I retested it on staging with a cleaner mock that invalidates the session and clears the stored credentials, which makes the expected sign-in redirect deterministic. With the old mock, valid stored credentials could still exist, so the app could reauthenticate successfully instead of logging out, which is expected. With the updated mock, the app redirects to the sign-in page correctly.

(async () => {
    const session = await window.Onyx.get('session');
    const credentials = await window.Onyx.get('credentials');

    localStorage.setItem('issue90544_originalSession', JSON.stringify(session ?? {}));
    localStorage.setItem('issue90544_originalCredentials', JSON.stringify(credentials ?? {}));

    await window.Onyx.merge('session', {
        authToken: 'invalid-auth-token-for-issue-90544',
        encryptedAuthToken: 'invalid-auth-token-for-issue-90544',
        creationDate: Date.now() - 3 * 60 * 60 * 1000,
        signedInWithShortLivedAuthToken: true,
        isSupportAuthTokenUsed: true,
    });

    await window.Onyx.set('credentials', null);
    await window.Onyx.merge('account', {isLoading: false});

    console.log('90544 mock applied with missing credentials. Try emoji reaction now.');
})();

Tested Demo ON Staging:

Screencast.From.2026-06-24.16-44-08.mp4

@brunovjk

Copy link
Copy Markdown
Contributor

Great! Thank you @nabi-ebrahimi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants