Repository navigation
[Fraud Protection] Send authentication=infiniteSession for restored sessions - #91803
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No need for a C+ review here |
|
Also, no product change here. |
|
@mjasikowski looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Forgot reviewer checklist: Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.84-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR against the help site articles under No help site changes are required. This PR modifies internal fraud protection logic (GroupIB session tagging) to distinguish restored sessions from fresh sign-ins. The changes are entirely backend/infrastructure:
None of this is user-facing or referenced in any existing help site article. @cristipaval, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@cristipaval can you QA this? |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.86-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. It adds an internal No help site changes are required. @cristipaval, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.88-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR against the help site files under No help site changes are required. This PR adds internal fraud detection logic (tagging restored sessions with @cristipaval, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀
|
Explanation of Change
Tags NewDot sessions that were already authenticated when the app booted (i.e. restored from disk, not a fresh sign-in) with
authentication=infiniteSessionfor GroupIB.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/632349
PROPOSAL:
Tests
authenticationattribute is set to what you used to sign inauthenticationattribute is set toinfiniteSessionOffline tests
QA Steps
Same as tests. Feel free to ping @cristipaval to QA.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari