Repository navigation
[CP Staging + Production] [Payment due @huult] Pass header to backend when importing CSV company cards - #91936
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Please tag me when it’s ready. Thank you! |
Reviewer Checklist
Screenshots/Videos |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@huult all yours |
|
Reviewing... |
|
🎯 @huult, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.86-2 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR against the help site articles under No help site changes are required. This PR is a backend data-passing fix — it corrects how the CSV header row is structured before being sent to the backend when importing company card transactions from a spreadsheet. The user-facing import flow (UI steps, buttons, labels, field mappings) is completely unchanged. The existing help article (Import Company Card Transactions From a Spreadsheet) already accurately describes the import process and does not need any updates. @Gonals, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
DetailsGithub\Exception\RuntimeException |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.88-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR against the help site articles under No help site changes are required. This PR is a backend communication fix — it changes how the header row is structured in the data payload sent to the API when importing CSV company card transactions. No user-facing steps, UI labels, settings, or workflows are affected. The existing article Import Company Card Transactions From a Spreadsheet accurately describes the current import flow and does not need updating. @Gonals, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀
|
|
🤖 Payment issue created: #92018 |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.89-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review I reviewed the changes in this PR and no help site updates are required. WhyThis PR is a backend integration bug fix in There is no change to:
The existing article Import Company Card Transactions From a Spreadsheet already accurately documents this flow and remains correct.
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.89-7 🚀
|





Explanation of Change
The backend expects the header and we are not passing it.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/641913
PROPOSAL:
Tests
Go to a workspace > Company Cards > Add Cards > Import transactions from File. You can use this file:
w_9f67f19202de1b258cd1bcd3470527338782cf2f.csv
Follow the import process
Confirm the card displays properly. It may take a bit for it to show:
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari