Repository navigation
Add sticky group headers to Spend table (two-phase approach) - #92067
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…o header + children pairs Signed-off-by: krishna2323 <belivethatkg@gmail.com>
0636261 to
d8c1da2
Compare
…layout Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…tedCollapsible Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…collapsed Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…h results Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…n widths and borders Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5980a0aa06
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…en layout Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…nimation completes Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…der clipping Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…Header Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ngPress and hover props Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…onLongPress and hover props Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ontainer Signed-off-by: krishna2323 <belivethatkg@gmail.com>
… children container gap Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…-screen regressions Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…s TransactionGroupListItem Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…panded state Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ghlight, and padding Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb880dcc4d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…oup items Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Deploy Blocker #93488 was identified to be related to this PR. |
|
Deploy Blocker #93489 was identified to be related to this PR. |
|
Deploy Blocker #93492 was identified to be related to this PR. |
|
Deploy Blocker ##93491 was identified to be related to this PR. |
|
Deploy Blocker #93493 was identified to be related to this PR. |
|
Deploy Blocker #93494 was identified to be related to this PR. |
|
Deploy Blocker #93495 was identified to be related to this PR. |
|
Deploy Blocker #93518 was identified to be related to this PR. |
|
Deploy Blocker #93526 was identified to be related to this PR. |
|
Deploy Blocker #93527 was identified to be related to this PR. |
|
Deploy Blocker #93534 was identified to be related to this PR. |
|
Deploy Blocker #93535 was identified to be related to this PR. |
|
Deploy Blocker #93536 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.7-4 🚀
|
| } | ||
|
|
||
| return ( | ||
| <View style={[styles.mh5, {backgroundColor: isSelected ? theme.activeComponentBG : theme.highlightBG}, isLastItem && [styles.tableBottomRadius, styles.overflowHidden]]}> |
Explanation of Change
Fixed Issues
$ #88926
PROPOSAL:
Tests
Setup
Sticky Headers
Animations
Selection
Navigation & Press Behavior
Long Press
Keyboard Navigation
Narrow Screen (No Regression)
mainBorder & Styling
Edge Cases
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4