Skip to content

Add sticky group headers to Spend table (two-phase approach) - #92067

Merged
JS00001 merged 45 commits into
Expensify:mainfrom
Krishna2323:krishna/sticky-group-headers
Jun 12, 2026
Merged

JS00001 merged 45 commits into
Expensify:mainfrom
Krishna2323:krishna/sticky-group-headers

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented May 29, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #88926
PROPOSAL:

Tests

Setup

  • Have a workspace with multiple expense reports/groups that have enough transactions to require scrolling within a group
  • Use a large screen width (desktop/web) so the sub-header (column header row) is visible

Sticky Headers

  1. Expand a group that has many transactions (enough to scroll)
  2. Scroll down within the list — ensure the group header sticks to the top
  3. Ensure the sub-header (column names row) also sticks below the group header
  4. Continue scrolling past the group — ensure the next group's header pushes the previous sticky header off-screen
  5. Scroll back up — ensure headers re-stick correctly

Animations

  1. Click a group header to expand it — ensure the expand animation (height reveal) plays smoothly
  2. Click again to collapse — ensure the collapse animation plays smoothly
  3. Expand a group, scroll down so the sub-header is sticky, then collapse — ensure animation still works correctly

Selection

  1. Select individual transactions within an expanded group via checkboxes — ensure they highlight correctly
  2. Select all transactions in a group via the group header checkbox — ensure all rows highlight including the sub-header and bottom padding area
  3. Deselect all via the group header checkbox — ensure everything unhighlights
  4. Verify the sub-header border remains visible when the group is selected (not blending into background)

Navigation & Press Behavior

  1. For expense report groups: tap the header row — ensure it navigates to the report (does NOT just toggle expand/collapse)
  2. For non-expense-report groups: tap the header row — ensure it toggles expand/collapse
  3. Click the expand/collapse arrow specifically — ensure it toggles the group
  4. For an empty group with no transactions: click the arrow — ensure it navigates rather than toggling

Long Press

  1. Long-press a group header — ensure it enters selection mode (mobile behavior)
  2. Long-press a transaction row within an expanded group — ensure it selects that transaction

Keyboard Navigation

  1. Use Tab/arrow keys to navigate between group headers — ensure focus styling appears
  2. Press Enter on a focused group header — ensure it behaves the same as a click

Narrow Screen (No Regression)

  1. Resize the window to a narrow/mobile width
  2. Ensure groups behave exactly as before (no sticky headers, no sub-header visible)
  3. Expand/collapse, select, navigate — all should work as on main

Border & Styling

  1. Verify the sub-header has a visible border-bottom separating it from transaction rows
  2. Verify no extra gaps or borders appear between rows when collapsed
  3. Verify the group header has correct border-radius when collapsed, and no border-radius when expanded
  4. Verify hover effect does NOT appear on expanded group headers, only on collapsed ones

Edge Cases

  1. Expand a group, create a new transaction in it — ensure the group refreshes and shows the new transaction
  2. Delete a transaction (pending delete state) — ensure the group header becomes disabled/non-pressable
  3. Scroll rapidly between multiple expanded groups — ensure no visual glitches or layout jumps
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4

@codecov

codecov Bot commented May 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
.../Search/SearchList/BaseSearchList/index.native.tsx 100.00% <ø> (ø)
...ponents/Search/SearchList/BaseSearchList/index.tsx 0.00% <ø> (ø)
...archList/ListItem/TransactionGroupListExpanded.tsx 64.51% <100.00%> (ø)
src/components/Search/SearchList/ListItem/types.ts 100.00% <100.00%> (ø)
src/styles/index.ts 59.06% <ø> (ø)
...h/SearchList/ListItem/TransactionGroupListItem.tsx 74.50% <50.00%> (+0.16%) ⬆️
...rch/SearchList/ListItem/GroupChildrenContainer.tsx 0.00% <0.00%> (ø)
src/libs/SearchUIUtils.ts 64.05% <0.00%> (-0.33%) ⬇️
src/hooks/useExpandCollapseAnimation.ts 5.88% <5.88%> (ø)
src/components/Search/SearchList/index.tsx 48.90% <37.70%> (-7.67%) ⬇️
... and 2 more
... and 89 files with indirect coverage changes

…o header + children pairs

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Krishna2323 force-pushed the krishna/sticky-group-headers branch from 0636261 to d8c1da2 Compare May 29, 2026 11:57
…layout

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…tedCollapsible

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…collapsed

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…h results

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…n widths and borders

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5980a0aa06

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…en layout

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…nimation completes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…der clipping

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…Header

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ngPress and hover props

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…onLongPress and hover props

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ontainer

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
… children container gap

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…-screen regressions

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…s TransactionGroupListItem

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…panded state

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ghlight, and padding

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb880dcc4d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/SearchUIUtils.ts Resolved
…oup items

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93488 was identified to be related to this PR.

@nlemma

nlemma commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Blocker #93489 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93492 was identified to be related to this PR.

@lanitochka17

Copy link
Copy Markdown

Deploy Blocker ##93491 was identified to be related to this PR.

@nlemma

nlemma commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Blocker #93493 was identified to be related to this PR.

@nlemma

nlemma commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Blocker #93494 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93495 was identified to be related to this PR.

@nlemma

nlemma commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Blocker #93518 was identified to be related to this PR.

@nlemma

nlemma commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Blocker #93526 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93527 was identified to be related to this PR.

@nlemma

nlemma commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Blocker #93534 was identified to be related to this PR.

@nlemma

nlemma commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Blocker #93535 was identified to be related to this PR.

@nlemma

nlemma commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Blocker #93536 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.7-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

}

return (
<View style={[styles.mh5, {backgroundColor: isSelected ? theme.activeComponentBG : theme.highlightBG}, isLastItem && [styles.tableBottomRadius, styles.overflowHidden]]}>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filing this against #92067, this never had an isFirstItem concept, so the first child row always got the same border/spacing as later rows, and the grouped-view header padding didn't match. Fixed in #99586.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.