Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/CONST/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2076,6 +2076,8 @@ const CONST = {
RHP_DURATION_OUT_WEB: 100,
CENTERED_DURATION_IN_WEB: 120,
CENTERED_DURATION_OUT_WEB: 80,
NARROW_SLIDE_DURATION_IN_WEB: 300,
NARROW_SLIDE_DURATION_OUT_WEB: 200,
},
RHP_ENTER_OFFSET_PX_WEB: 60,
},
Expand Down
4 changes: 3 additions & 1 deletion src/components/Modal/BaseModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,10 @@ function BaseModal({

const shouldSuppressRightDockedBackdrop =
type === CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED && !isSmallScreenWidth && (isInNarrowPane || isInNarrowPaneModal) && !shouldKeepRightDockedBackdropInNarrowPane;
const isFullWidthNarrowSheet =
(type === CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED || type === CONST.MODAL.MODAL_TYPE.CENTERED_SWIPEABLE_TO_RIGHT) && isSmallScreenWidth && !shouldKeepRightDockedBackdropInNarrowPane;
const backdropOpacityAdjusted =
hideBackdrop || shouldSuppressRightDockedBackdrop // right_docked modals shouldn't add backdrops when opened in same-width RHP
hideBackdrop || shouldSuppressRightDockedBackdrop || isFullWidthNarrowSheet // full-width narrow sheets (RHP-like) shouldn't dim a backdrop behind them
? 0
: backdropOpacity;

Expand Down
67 changes: 48 additions & 19 deletions src/components/Modal/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, {useCallback, useEffect, useRef, useState} from 'react';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useStyleUtils from '@hooks/useStyleUtils';
import useTheme from '@hooks/useTheme';
import StatusBar from '@libs/StatusBar';
Expand All @@ -8,26 +9,54 @@ import {withInternalPopstate} from './internalPopstateGuard';
import type BaseModalProps from './types';
import type {WindowState} from './types';

type WebModalAnimation = Pick<BaseModalProps, 'animationIn' | 'animationOut' | 'animationInTiming' | 'animationOutTiming'>;

const CENTERED_MODAL_TYPES = new Set<BaseModalProps['type']>([
CONST.MODAL.MODAL_TYPE.CONFIRM,
CONST.MODAL.MODAL_TYPE.CENTERED,
CONST.MODAL.MODAL_TYPE.CENTERED_UNSWIPEABLE,
CONST.MODAL.MODAL_TYPE.CENTERED_SMALL,
CONST.MODAL.MODAL_TYPE.CENTERED_SWIPEABLE_TO_RIGHT,
]);

// Faster timing and slide-and-fade are desktop-only; narrow web keeps the full-slide baseline at the original 300/200 timing.
function getWebModalAnimation(type: BaseModalProps['type'], isSmallScreenWidth: boolean): WebModalAnimation {
const isRightDocked = type === CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED;
const isCentered = CENTERED_MODAL_TYPES.has(type);
if (!isRightDocked && !isCentered) {
return {};
}
const isFadeOnlyCentered = type === CONST.MODAL.MODAL_TYPE.CONFIRM || type === CONST.MODAL.MODAL_TYPE.CENTERED_SMALL;
if (isSmallScreenWidth && !isFadeOnlyCentered) {
return {
animationInTiming: CONST.MODAL.ANIMATION_TIMING.NARROW_SLIDE_DURATION_IN_WEB,
animationOutTiming: CONST.MODAL.ANIMATION_TIMING.NARROW_SLIDE_DURATION_OUT_WEB,
};
}
if (isRightDocked) {
return {
animationIn: 'slideAndFadeInRight',
animationOut: 'slideAndFadeOutRight',
animationInTiming: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_IN_WEB,
animationOutTiming: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_OUT_WEB,
};
}
return {
animationInTiming: CONST.MODAL.ANIMATION_TIMING.CENTERED_DURATION_IN_WEB,
animationOutTiming: CONST.MODAL.ANIMATION_TIMING.CENTERED_DURATION_OUT_WEB,
};
}

function Modal({fullscreen = true, onModalHide = () => {}, type, onModalShow = () => {}, children, shouldHandleNavigationBack, ...rest}: BaseModalProps) {
const theme = useTheme();
const StyleUtils = useStyleUtils();
// We gate the web animation on raw screen width (desktop vs mobile web) rather than shouldUseNarrowLayout,
// because a modal opened on top of an RHP on desktop must keep its desktop animation, not the narrow one.
// eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth
const {isSmallScreenWidth} = useResponsiveLayout();
const [previousStatusBarColor, setPreviousStatusBarColor] = useState<string>();

const isRightDocked = type === CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED;
const isCentered =
type === CONST.MODAL.MODAL_TYPE.CONFIRM ||
type === CONST.MODAL.MODAL_TYPE.CENTERED ||
type === CONST.MODAL.MODAL_TYPE.CENTERED_UNSWIPEABLE ||
type === CONST.MODAL.MODAL_TYPE.CENTERED_SMALL ||
type === CONST.MODAL.MODAL_TYPE.CENTERED_SWIPEABLE_TO_RIGHT;
const rightDockedInTiming = isRightDocked ? CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_IN_WEB : undefined;
const rightDockedOutTiming = isRightDocked ? CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_OUT_WEB : undefined;
const centeredInTiming = isCentered ? CONST.MODAL.ANIMATION_TIMING.CENTERED_DURATION_IN_WEB : undefined;
const centeredOutTiming = isCentered ? CONST.MODAL.ANIMATION_TIMING.CENTERED_DURATION_OUT_WEB : undefined;
const animationInTiming = rest.animationInTiming ?? rightDockedInTiming ?? centeredInTiming;
const animationOutTiming = rest.animationOutTiming ?? rightDockedOutTiming ?? centeredOutTiming;
const animationIn = rest.animationIn ?? (isRightDocked ? 'slideAndFadeInRight' : undefined);
const animationOut = rest.animationOut ?? (isRightDocked ? 'slideAndFadeOutRight' : undefined);
const webAnimation = getWebModalAnimation(type, isSmallScreenWidth);

const setStatusBarColor = (color = theme.appBG) => {
if (!fullscreen) {
Expand Down Expand Up @@ -123,10 +152,10 @@ function Modal({fullscreen = true, onModalHide = () => {}, type, onModalShow = (
return (
<BaseModal
{...rest}
animationIn={animationIn}
animationOut={animationOut}
animationInTiming={animationInTiming}
animationOutTiming={animationOutTiming}
animationIn={rest.animationIn ?? webAnimation.animationIn}
animationOut={rest.animationOut ?? webAnimation.animationOut}
animationInTiming={rest.animationInTiming ?? webAnimation.animationInTiming}
animationOutTiming={rest.animationOutTiming ?? webAnimation.animationOutTiming}
onModalHide={hideModal}
onModalShow={showModal}
onModalWillShow={onModalWillShow}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import type {ParamListBase} from '@react-navigation/native';
import {CardStyleInterpolators} from '@react-navigation/stack';
import type {StackCardStyleInterpolator} from '@react-navigation/stack';
import {useCallback} from 'react';
import {useWideRHPState} from '@components/WideRHPContextProvider';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useThemeStyles from '@hooks/useThemeStyles';
import enhanceCardStyleInterpolator from '@libs/Navigation/AppNavigator/enhanceCardStyleInterpolator';
import hideKeyboardOnSwipe from '@libs/Navigation/AppNavigator/hideKeyboardOnSwipe';
import RHP_WEB_TRANSITION_SPEC from '@libs/Navigation/AppNavigator/RHPTransitionSpec';
import useModalCardStyleInterpolator from '@libs/Navigation/AppNavigator/useModalCardStyleInterpolator';
import type {PlatformStackNavigationOptions, PlatformStackRouteProp} from '@libs/Navigation/PlatformStackNavigation/types';
import CONST from '@src/CONST';
Expand All @@ -23,8 +25,9 @@ function useWideModalStackScreenOptions() {

return useCallback<({route}: {route: PlatformStackRouteProp<ParamListBase, string>}) => PlatformStackNavigationOptions>(
({route}) => {
const baseInterpolator: StackCardStyleInterpolator = (props) =>
modalCardStyleInterpolator({props, enter: {kind: 'slide-and-fade', distancePx: CONST.MODAL.RHP_ENTER_OFFSET_PX_WEB}});
const baseInterpolator: StackCardStyleInterpolator = isSmallScreenWidth
? CardStyleInterpolators.forHorizontalIOS
: (props) => modalCardStyleInterpolator({props, enter: {kind: 'slide-and-fade', distancePx: CONST.MODAL.RHP_ENTER_OFFSET_PX_WEB}});

let cardStyleInterpolator: StackCardStyleInterpolator = baseInterpolator;

Expand Down Expand Up @@ -55,10 +58,7 @@ function useWideModalStackScreenOptions() {
web: {
cardStyle: styles.navigationScreenCardStyle,
cardStyleInterpolator,
transitionSpec: {
open: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_IN_WEB}},
close: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_OUT_WEB}},
},
transitionSpec: isSmallScreenWidth ? undefined : RHP_WEB_TRANSITION_SPEC,
},
};
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import React from 'react';
import {View} from 'react-native';
import NoDropZone from '@components/DragAndDrop/NoDropZone';
import ExplanationModal from '@components/ExplanationModal';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import RHP_WEB_TRANSITION_SPEC from '@libs/Navigation/AppNavigator/RHPTransitionSpec';
import createPlatformStackNavigator from '@libs/Navigation/PlatformStackNavigation/createPlatformStackNavigator';
import Animations from '@libs/Navigation/PlatformStackNavigation/navigationOptions/animation';
import type {ExplanationModalNavigatorParamList} from '@libs/Navigation/types';
Expand All @@ -10,10 +12,13 @@ import SCREENS from '@src/SCREENS';
const Stack = createPlatformStackNavigator<ExplanationModalNavigatorParamList>();

function ExplanationModalNavigator() {
const {shouldUseNarrowLayout} = useResponsiveLayout();
return (
<NoDropZone>
<View>
<Stack.Navigator screenOptions={{headerShown: false, animation: Animations.SLIDE_FROM_RIGHT}}>
<Stack.Navigator
screenOptions={{headerShown: false, animation: Animations.SLIDE_FROM_RIGHT, web: {transitionSpec: shouldUseNarrowLayout ? undefined : RHP_WEB_TRANSITION_SPEC}}}
>
<Stack.Screen
name={SCREENS.EXPLANATION_MODAL.ROOT}
component={ExplanationModal}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import React from 'react';
import {View} from 'react-native';
import AutoSubmitModal from '@components/AutoSubmitModal';
import NoDropZone from '@components/DragAndDrop/NoDropZone';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import RHP_WEB_TRANSITION_SPEC from '@libs/Navigation/AppNavigator/RHPTransitionSpec';
import createPlatformStackNavigator from '@libs/Navigation/PlatformStackNavigation/createPlatformStackNavigator';
import Animations from '@libs/Navigation/PlatformStackNavigation/navigationOptions/animation';
import type {FeatureTrainingNavigatorParamList} from '@libs/Navigation/types';
Expand All @@ -12,10 +14,13 @@ import SCREENS from '@src/SCREENS';
const Stack = createPlatformStackNavigator<FeatureTrainingNavigatorParamList>();

function FeatureTrainingModalNavigator() {
const {shouldUseNarrowLayout} = useResponsiveLayout();
return (
<NoDropZone>
<View>
<Stack.Navigator screenOptions={{headerShown: false, animation: Animations.SLIDE_FROM_RIGHT}}>
<Stack.Navigator
screenOptions={{headerShown: false, animation: Animations.SLIDE_FROM_RIGHT, web: {transitionSpec: shouldUseNarrowLayout ? undefined : RHP_WEB_TRANSITION_SPEC}}}
>
<Stack.Screen
name={SCREENS.FEATURE_TRAINING_ROOT}
component={TrackTrainingPage}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import Navigation from '@libs/Navigation/Navigation';
import createPlatformStackNavigator from '@libs/Navigation/PlatformStackNavigation/createPlatformStackNavigator';
import Animations from '@libs/Navigation/PlatformStackNavigation/navigationOptions/animation';
import Presentation from '@libs/Navigation/PlatformStackNavigation/navigationOptions/presentation';
import RHP_WEB_TRANSITION_SPEC from '@navigation/AppNavigator/RHPTransitionSpec';
import useModalCardStyleInterpolator from '@navigation/AppNavigator/useModalCardStyleInterpolator';
import variables from '@styles/variables';
import CONST from '@src/CONST';
Expand Down Expand Up @@ -181,6 +182,7 @@ function MultifactorAuthenticationModalNavigator() {
* on wide layout, so the slide range is stable regardless of layout timing.
*/
cardStyleInterpolator: (props: StackCardInterpolationProps) => modalCardStyleInterpolator({props, enter: {kind: 'slide-from-width'}}),
transitionSpec: shouldUseNarrowLayout ? undefined : RHP_WEB_TRANSITION_SPEC,
},
}}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useThemeStyles from '@hooks/useThemeStyles';
import {isMobileSafari} from '@libs/Browser';
import GoogleTagManager from '@libs/GoogleTagManager';
import RHP_WEB_TRANSITION_SPEC from '@libs/Navigation/AppNavigator/RHPTransitionSpec';
import useModalCardStyleInterpolator from '@libs/Navigation/AppNavigator/useModalCardStyleInterpolator';
import createPlatformStackNavigator from '@libs/Navigation/PlatformStackNavigation/createPlatformStackNavigator';
import Animations from '@libs/Navigation/PlatformStackNavigation/navigationOptions/animation';
Expand Down Expand Up @@ -40,7 +41,7 @@ let signUpEventPublishedForAccountID: number | undefined;

function OnboardingModalNavigator() {
const styles = useThemeStyles();
const {onboardingIsMediumOrLargerScreenWidth} = useResponsiveLayout();
const {onboardingIsMediumOrLargerScreenWidth, shouldUseNarrowLayout} = useResponsiveLayout();
const outerViewRef = React.useRef<View>(null);
const [account, accountMetadata] = useOnyx(ONYXKEYS.ACCOUNT);
const isOnPrivateDomainAndHasAccessiblePolicies = !account?.isFromPublicDomain && account?.hasAccessibleDomainPolicies;
Expand Down Expand Up @@ -93,9 +94,10 @@ function OnboardingModalNavigator() {
cardStyle: {
height: '100%',
},
transitionSpec: shouldUseNarrowLayout ? undefined : RHP_WEB_TRANSITION_SPEC,
},
};
}, [customInterpolator]);
}, [customInterpolator, shouldUseNarrowLayout]);

// If the account data is not loaded yet, we don't want to show the onboarding modal
if (isLoadingOnyxValue(accountMetadata)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import React from 'react';
import {View} from 'react-native';
import NoDropZone from '@components/DragAndDrop/NoDropZone';
import TestDriveModal from '@components/TestDrive/Modal';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import RHP_WEB_TRANSITION_SPEC from '@libs/Navigation/AppNavigator/RHPTransitionSpec';
import createPlatformStackNavigator from '@libs/Navigation/PlatformStackNavigation/createPlatformStackNavigator';
import Animations from '@libs/Navigation/PlatformStackNavigation/navigationOptions/animation';
import type {TestDriveModalNavigatorParamList} from '@libs/Navigation/types';
Expand All @@ -10,10 +12,13 @@ import SCREENS from '@src/SCREENS';
const Stack = createPlatformStackNavigator<TestDriveModalNavigatorParamList>();

function TestDriveModalNavigator() {
const {shouldUseNarrowLayout} = useResponsiveLayout();
return (
<NoDropZone>
<View>
<Stack.Navigator screenOptions={{headerShown: false, animation: Animations.SLIDE_FROM_RIGHT}}>
<Stack.Navigator
screenOptions={{headerShown: false, animation: Animations.SLIDE_FROM_RIGHT, web: {transitionSpec: shouldUseNarrowLayout ? undefined : RHP_WEB_TRANSITION_SPEC}}}
>
<Stack.Screen
name={SCREENS.TEST_DRIVE_MODAL.ROOT}
component={TestDriveModal}
Expand Down
9 changes: 9 additions & 0 deletions src/libs/Navigation/AppNavigator/RHPTransitionSpec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import type {StackNavigationOptions} from '@react-navigation/stack';
import CONST from '@src/CONST';

const RHP_WEB_TRANSITION_SPEC: StackNavigationOptions['transitionSpec'] = {
open: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_IN_WEB}},
close: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_OUT_WEB}},
};

export default RHP_WEB_TRANSITION_SPEC;
4 changes: 3 additions & 1 deletion src/libs/Navigation/AppNavigator/useRHPScreenOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {isSafari} from '@libs/Browser';
import Animations from '@libs/Navigation/PlatformStackNavigation/navigationOptions/animation';
import Presentation from '@libs/Navigation/PlatformStackNavigation/navigationOptions/presentation';
import type {PlatformStackNavigationOptions} from '@libs/Navigation/PlatformStackNavigation/types/NavigationOptions';
import RHP_WEB_TRANSITION_SPEC from './RHPTransitionSpec';
import useModalCardStyleInterpolator from './useModalCardStyleInterpolator';

// This function is necessary for proper animation if a wide format RHP screen is visible.
Expand Down Expand Up @@ -51,9 +52,10 @@ const useRHPScreenOptions = (): PlatformStackNavigationOptions => {
cardOverlayEnabled: false,
cardStyle: styles.navigationScreenCardStyle,
gestureDirection: 'horizontal',
transitionSpec: isSmallScreenWidth ? undefined : RHP_WEB_TRANSITION_SPEC,
},
};
}, [customInterpolator, shouldAdjustInterpolatorProps, styles.navigationScreenCardStyle]);
}, [customInterpolator, shouldAdjustInterpolatorProps, isSmallScreenWidth, styles.navigationScreenCardStyle]);
};

export default useRHPScreenOptions;
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import Presentation from '@libs/Navigation/PlatformStackNavigation/navigationOpt
import type {PlatformStackNavigationOptions} from '@libs/Navigation/PlatformStackNavigation/types';
import CONST from '@src/CONST';
import hideKeyboardOnSwipe from './hideKeyboardOnSwipe';
import RHP_WEB_TRANSITION_SPEC from './RHPTransitionSpec';
import useModalCardStyleInterpolator from './useModalCardStyleInterpolator';
import type {EnterAnimation} from './useModalCardStyleInterpolator';

Expand All @@ -32,6 +33,7 @@ const useRootNavigatorScreenOptions = () => {

const fullScreenEnter: EnterAnimation = shouldUseNarrowLayout ? {kind: 'slide-from-width'} : {kind: 'none'};
const onboardingEnter: EnterAnimation = onboardingIsMediumOrLargerScreenWidth ? {kind: 'fade'} : {kind: 'slide-from-width'};
const rhpEnter: EnterAnimation = shouldUseNarrowLayout ? {kind: 'slide-from-width'} : {kind: 'slide-and-fade', distancePx: CONST.MODAL.RHP_ENTER_OFFSET_PX_WEB};

return {
rightModalNavigator: {
Expand All @@ -45,9 +47,10 @@ const useRootNavigatorScreenOptions = () => {
cardStyleInterpolator: (props: StackCardInterpolationProps) =>
modalCardStyleInterpolator({
props,
enter: {kind: 'slide-and-fade', distancePx: CONST.MODAL.RHP_ENTER_OFFSET_PX_WEB},
enter: rhpEnter,
applySidePanelOffset: true,
}),
transitionSpec: shouldUseNarrowLayout ? undefined : RHP_WEB_TRANSITION_SPEC,
},
},
basicModalNavigator: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
import type {StackNavigationOptions} from '@react-navigation/stack';
import type {PlatformSpecificNavigationOptions} from '@libs/Navigation/PlatformStackNavigation/types';
import CONST from '@src/CONST';
import {InternalPlatformAnimations} from '..';

const slideFromRight: PlatformSpecificNavigationOptions = {
animation: InternalPlatformAnimations.SLIDE_FROM_RIGHT,
gestureDirection: 'horizontal',
transitionSpec: {
open: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_IN_WEB}},
close: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_OUT_WEB}},
},
} satisfies StackNavigationOptions;
const slideFromRight: PlatformSpecificNavigationOptions = {animation: InternalPlatformAnimations.SLIDE_FROM_RIGHT, gestureDirection: 'horizontal'} satisfies StackNavigationOptions;
Comment thread
adhorodyski marked this conversation as resolved.
Resolved
Comment thread
adhorodyski marked this conversation as resolved.
Resolved

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve desktop timing for remaining slide routes

This removes the 150/100ms transitionSpec from the shared SLIDE_FROM_RIGHT option, but several web routes still rely only on animation: Animations.SLIDE_FROM_RIGHT and do not get an explicit replacement (for example, I checked SCREENS.SEARCH_ROUTER.ROOT in AuthScreens.tsx). When those routes are opened on desktop web they now fall back to React Navigation's default stack timing instead of the fast timing that had shipped, so desktop behavior is no longer unchanged. Please either keep this spec for wide web or add the desktop spec to the remaining wide callsites while overriding only narrow ones.

Useful? React with 👍 / 👎.

@adhorodyski adhorodyski Jun 8, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aimane-chnaif can you test this one on your end please? Myself I only see this route being rendered through a modal which is correctly not animated at all now (as per previous PRs)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is repro step?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just open and close the Search Router (icon in the right side of our global header)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, no animation on desktop web as expected.
Can you check if this is expected on mobile web? Asking because I noticed background overlay.

router.mov

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Search Router opens via SearchRouterModal, which on narrow uses the CENTERED_SWIPEABLE_TO_RIGHT modal type.

Our full-width-narrow backdrop suppression in BaseModal only covered RIGHT_DOCKED, so this sheet still rendered a dimmed overlay that faded in behind the slide.

I extended the suppression to cover CENTERED_SWIPEABLE_TO_RIGHT too, so on mobile web it now slides in overlay-free, matching the RHP navigation case.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aimane-chnaif just a ping there for some eyes

@aimane-chnaif aimane-chnaif Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

demo.mov


export default slideFromRight;
Loading