Repository navigation
[No QA] Gate RHP web animation changes to desktop only #92086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3871973
0b5632d
ae24f37
f9b8ddc
d695749
c67a097
104c263
9a397a2
d9eb8c4
a4ea9f9
8678cfa
c01d376
7cd9d14
78d6837
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import type {StackNavigationOptions} from '@react-navigation/stack'; | ||
| import CONST from '@src/CONST'; | ||
|
|
||
| const RHP_WEB_TRANSITION_SPEC: StackNavigationOptions['transitionSpec'] = { | ||
| open: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_IN_WEB}}, | ||
| close: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_OUT_WEB}}, | ||
| }; | ||
|
|
||
| export default RHP_WEB_TRANSITION_SPEC; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,7 @@ | ||
| import type {StackNavigationOptions} from '@react-navigation/stack'; | ||
| import type {PlatformSpecificNavigationOptions} from '@libs/Navigation/PlatformStackNavigation/types'; | ||
| import CONST from '@src/CONST'; | ||
| import {InternalPlatformAnimations} from '..'; | ||
|
|
||
| const slideFromRight: PlatformSpecificNavigationOptions = { | ||
| animation: InternalPlatformAnimations.SLIDE_FROM_RIGHT, | ||
| gestureDirection: 'horizontal', | ||
| transitionSpec: { | ||
| open: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_IN_WEB}}, | ||
| close: {animation: 'timing', config: {duration: CONST.MODAL.ANIMATION_TIMING.RHP_DURATION_OUT_WEB}}, | ||
| }, | ||
| } satisfies StackNavigationOptions; | ||
| const slideFromRight: PlatformSpecificNavigationOptions = {animation: InternalPlatformAnimations.SLIDE_FROM_RIGHT, gestureDirection: 'horizontal'} satisfies StackNavigationOptions; | ||
|
adhorodyski marked this conversation as resolved.
Resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This removes the 150/100ms Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aimane-chnaif can you test this one on your end please? Myself I only see this route being rendered through a modal which is correctly not animated at all now (as per previous PRs)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is repro step?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just open and close the Search Router (icon in the right side of our global header)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, no animation on desktop web as expected. router.mov
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Search Router opens via SearchRouterModal, which on narrow uses the Our full-width-narrow backdrop suppression in BaseModal only covered I extended the suppression to cover
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aimane-chnaif just a ping there for some eyes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looking good demo.mov |
||
|
|
||
| export default slideFromRight; | ||
Uh oh!
There was an error while loading. Please reload this page.