Repository navigation
feat: Wire ExportDownloadStatusModal into CSV export flow #92169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
f1fd1ab
feat: Wire ExportDownloadStatusModal into CSV export flow
truph01 1b0763e
fix: add failure data
truph01 43cf551
fix: lint
truph01 01b3131
fix: update fileDownload
truph01 68737e0
fix: conflicts
truph01 2b13d84
fix: conflicts
truph01 5b63de7
fix: missing exportID
truph01 20d4f61
fix: lint
truph01 1dedaf2
fix: tests
truph01 28a401d
Merge branch 'Expensify:main' into fix/90298
truph01 585b3be
fix: lint
truph01 8b46b5c
Merge branch 'Expensify:main' into fix/90298
truph01 28b87e9
Merge branch 'Expensify:main' into fix/90298
truph01 e4f23b2
fix: conflicts
truph01 7b04b39
fix: conflicts
truph01 2b2ad75
fix: update download logic
truph01 b697c3d
fix: test
truph01 293d556
fix: remove line
truph01 8f0e62e
fix: spell check
truph01 b93b44b
Merge branch 'Expensify:main' into fix/90298
truph01 8bca27f
fix: prettier
truph01 68506e5
fix: open external link in safari
truph01 e21f674
fix: test
truph01 0e9f019
fix: conflicts
truph01 b597f27
fix: conflicts
truph01 3143396
fix: lint
truph01 e80fe22
fix: introduce shouldTrackExportProgress
truph01 ac91450
fix: don't clear selected transactions in export
truph01 41975d5
fix: prettier
truph01 a4e38ba
Merge branch 'Expensify:main' into fix/90298
truph01 dc924c1
fix: lint
truph01 ce1883d
fix: remove redundant code
truph01 14496aa
Merge branch 'Expensify:main' into fix/90298
truph01 35ca7f0
fix: conflicts
truph01 9806705
fix: conflicts
truph01 52c17b0
fix: typecheck
truph01 5eb8252
fix: resolve comment
truph01 46aa29a
fix: test
truph01 8894dff
fix: turn off selection mode after closing modal
truph01 d06dd6b
fix: resolve comment
truph01 2fbb6ff
fix: prettier
truph01 d0da579
Merge branch 'Expensify:main' into fix/90298
truph01 47608dd
fix: update handleGoToConcierge
truph01 c02e8bd
fix: test
truph01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@truph01, why do we need this
eslint-disableline?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to add
downloadFileto the dependencies and without the eslint-disabled, it will throws error: