Repository navigation
Conversation
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@OlimpiaZurek is the below use case testable?
|
|
@Pujan92 You're right, those conditions are mutually exclusive ( |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.1-0 🚀
Bundle Size Analysis (Sentry): |
Help site review — no changes requiredI reviewed the changes in this PR against Why: This is a purely internal performance refactor of
There are no new features, UI elements, labels, tabs, settings, or workflow changes that the help site documents. Because no changes are required, I did not create a draft docs PR. @OlimpiaZurek, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.1-6 🚀
|
Explanation of Change
Two small mount-time cleanups for IOURequestStepAmount:
BetasContextinstead of subscribing viauseOnyx(ONYXKEYS.BETAS). The context is already loaded upstream byusePermissions— same Beta[] reference, different access path. Removes one mount subscription.usePrivateIsArchivedMap()with a singleuseOnyx(REPORT_NAME_VALUE_PAIRS)+ per-key lookup at the call site. The hook subscribed to the same collection and rebuilt an O(N)Record<key, boolean>in the render body on every render, but the screen only ever looks up a single key. Same subscription count; eliminates the per-render map allocationPart 2/6 of #92411.
Fixed Issues
$ #92411
PROPOSAL:
Tests
N/A
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari