Skip to content

Guard DeepLinkHandler against stale post-sign-out initial URL - #92839

Merged
carlosmiceli merged 8 commits into
Expensify:mainfrom
MobileMage:fix/91437-stale-initial-url-deep-link
Jun 25, 2026
Merged

carlosmiceli merged 8 commits into
Expensify:mainfrom
MobileMage:fix/91437-stale-initial-url-deep-link

Conversation

@MobileMage

Copy link
Copy Markdown
Contributor

Explanation of Change

On web (and other react-native-web targets), after a user signs out while sitting on a workspace settings path (e.g. /workspace/{OLD_POLICY_ID}/rules) and then signs in with a new account that completes onboarding, the "Hmm... it's not here" page flashes briefly before the correct post-onboarding screen renders.

Root cause: react-native-web caches Linking.getInitialURL() at JS bundle load into a module-scoped constant (var initialURL = canUseDOM ? window.location.href : ''). After sign-out, that cached URL still points at the previous session's path. DeepLinkHandler's effect re-runs on session metadata change and on that run calls openReportFromDeepLink(staleUrl, isAuthenticated=false, ...). openReportFromDeepLink captures the URL and the (false) auth flag in closure and queues an Onyx.connectWithoutView subscription via waitForUserSignIn().then(...). On the next sign-in, NVP_ONBOARDING updates, the subscription's callback runs, the if (isAuthenticated) return; bail at Link.ts:341 does not trip because the closure captured false, and Navigation.navigate(staleWorkspaceURL) fires — mounting WORKSPACE_NAVIGATOR, triggering AccessOrNotFoundWrapper to render NotFoundPage for a workspace the new account cannot access, and a frame later the legit post-onboarding navigate replaces it. That gap is the flash.

This PR guards the DeepLinkHandler .then((url) => ...) callback with an early return when the user is signed out and an initial URL was already processed once. That blocks the post-sign-out re-run from queueing the stale openReportFromDeepLink call, without affecting the legit signed-out-first-time deep-link flow (which still has initialUrlProcessed.current === false on its first run and sets up its subscription as before).

Fixed Issues

$ #91437
PROPOSAL: #91437 (comment)

Tests

  1. Go to staging.new.expensify.com
  2. Create a workspace.
  3. Go to workspace settings > More features.
  4. Enable Rules.
  5. Upgrade workspace to enable Rules.
  6. Go to Rules.
  7. Refresh the page.
  8. Go to Account > Sign out.
  9. Log in with a new Gmail account.
  10. Complete onboarding with Manage my team's expenses intent.
  11. Verify the Not here page does not appear after completing onboarding.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests above with the network disabled before step 9, then re-enable the network and verify the Not here page does not appear after completing onboarding.

QA Steps

  1. Go to staging.new.expensify.com
  2. Create a workspace.
  3. Go to workspace settings > More features.
  4. Enable Rules.
  5. Upgrade workspace to enable Rules.
  6. Go to Rules.
  7. Refresh the page.
  8. Go to Account > Sign out.
  9. Log in with a new Gmail account.
  10. Complete onboarding with Manage my team's expenses intent.
  11. Verify the Not here page does not appear after completing onboarding.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
91437-android-native.mp4
Android: mWeb Chrome
iOS: Native
91437-ios-native.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Kapture.2026-06-05.at.22.03.13.mp4

On web, react-native-web caches Linking.getInitialURL() at JS bundle load,
so after sign-out the cached URL still returns the previous session's path.
The DeepLinkHandler effect re-runs on session metadata change and would
then call openReportFromDeepLink() with that stale URL, queueing a
waitForUserSignIn() callback that fires on the next sign-in and navigates
the new account to a route it has no access to.

Bail out of the post-sign-out re-run when an initial URL has already been
processed once, leaving the first-run signed-out deep-link flow intact.
@MobileMage
MobileMage requested review from a team as code owners June 5, 2026 23:45
@melvin-bot
melvin-bot Bot requested review from dmkt9 and trjExpensify June 5, 2026 23:45
@melvin-bot

melvin-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team and trjExpensify June 5, 2026 23:45
@codecov

codecov Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/DeepLinkHandler.tsx 83.33% <66.66%> (-1.97%) ⬇️
src/libs/actions/Link.ts 28.64% <25.00%> (-0.08%) ⬇️
... and 11 files with indirect coverage changes

@dmkt9

dmkt9 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

I just realized our PR might fail in the case where a user is not logged in but accesses a workspace rule via a deep link. I think we need a more comprehensive guard.

I have an idea to add a guard in the ONYXKEYS.NVP_ONBOARDING callback, and prevent navigation to the deep link if the user is required to complete onboarding first.

patch.diff
diff --git a/src/libs/actions/Link.ts b/src/libs/actions/Link.ts
index f777337f5f9..f9e52f9e539 100644
--- a/src/libs/actions/Link.ts
+++ b/src/libs/actions/Link.ts
@@ -295,6 +295,7 @@ function openReportFromDeepLink(
     // Navigate to the report after sign-in/sign-up.
     InteractionManager.runAfterInteractions(() => {
         waitForUserSignIn().then(() => {
+            let prevHasCompletedGuidedSetupFlow: boolean | undefined;
             // Subscribe to onboarding data using connectWithoutView to determine if user has completed the onboarding flow without affecting UI
             const connection = Onyx.connectWithoutView({
                 key: ONYXKEYS.NVP_ONBOARDING,
@@ -303,6 +304,10 @@ function openReportFromDeepLink(
                         return;
                     }
 
+                    if (!isAuthenticated && prevHasCompletedGuidedSetupFlow === undefined && val && !isAnonymousUser()) {
+                        prevHasCompletedGuidedSetupFlow = val.hasCompletedGuidedSetupFlow;
+                    }
+
                     Navigation.waitForProtectedRoutes().then(() => {
                         if (route && isAnonymousUser() && !canAnonymousUserAccessRoute(route)) {
                             signOutAndRedirectToSignIn(true);
@@ -337,6 +342,10 @@ function openReportFromDeepLink(
                                 return;
                             }
 
+                            if (prevHasCompletedGuidedSetupFlow === false) {
+                                return;
+                            }
+
                             // Navigation for signed users is handled by react-navigation.
                             if (isAuthenticated) {
                                 return;

However, I'm not fully confident this won't introduce regressions. If you go with this diff, please carefully review the impact across all platforms and verify the behavior end-to-end.

If you have a better approach, feel free to post it here.

@dmkt9

dmkt9 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@MobileMage Do you have an ETA for this?

@MobileMage

Copy link
Copy Markdown
Contributor Author

@dmkt9 Yup, the DeepLinkHandler guard only catches the post-sign-out re-run on web. A logged-out user who opens a workspace deep link for the first time gets past it, since initialUrlProcessed is still false on that run.

I added the guard in openReportFromDeepLink where you pointed. It reads hasCompletedGuidedSetupFlow once, on the first callback for a deep link captured while signed out. If the user still had to onboard then (a fresh sign-up, or the URL react-native-web cached from the previous session), it returns before navigating once onboarding finishes. That stops the "Not here" flash.

The guard stays narrow, so it won't drop a link the user can reach. Accounts that already onboarded (true) and old or migrated accounts with an empty onboarding NVP (undefined) navigate the same as before. The public-room and new-workspace branches above it stay untouched.

Tested on web:

  • logged-out → workspace rules link → fresh sign-up → onboarding: no "Not here" (your case)
  • original repro (sign out → new account → onboard): still fixed
  • logged-out → a report the account can reach → sign in: still navigates

Pushed in aca74ed.

# Conflicts:
#	src/libs/actions/Link.ts
@dmkt9

dmkt9 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@MobileMage Thanks. Looking at this

@dmkt9

dmkt9 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8511f6d215

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/Link.ts
Comment on lines +347 to +348
if (initialHasCompletedGuidedSetupFlow === false) {
return;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep pending deep links after onboarding

When a real signed-out user opens a protected deep link and then signs up, the first NVP_ONBOARDING value after sign-in is normally {hasCompletedGuidedSetupFlow: false}, so the new capture above leaves initialHasCompletedGuidedSetupFlow set to false. After the user completes onboarding, hasCompletedGuidedSetupFlowSelector(val) allows handleDeeplinkNavigation() to run, but this guard returns after the Onyx subscription has already been disconnected, so the originally requested deep link is permanently dropped. This regresses the legitimate first-time signed-out deep-link flow that the handler previously waited to complete onboarding before navigating.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the user completes onboarding, they will be navigated by navigateAfterOnboarding instead

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MobileMage But I think you should validate all option onboarding to call navigateAfterOnboarding for sure.

Comment thread src/libs/actions/Link.ts Outdated
return;
}

// Don't honor a deep link captured before the user finished onboarding (#91437).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Don't honor a deep link captured before the user finished onboarding (#91437).
// Don't honor a deep link captured when the user has to complete onboarding, since after finishing it the user will be navigated by `navigateAfterOnboarding````

Comment thread src/libs/actions/Link.ts
Comment on lines +347 to +348
if (initialHasCompletedGuidedSetupFlow === false) {
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the user completes onboarding, they will be navigated by navigateAfterOnboarding instead

@dmkt9

dmkt9 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8511f6d215

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/Link.ts
Comment on lines +347 to +348
if (initialHasCompletedGuidedSetupFlow === false) {
return;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve legitimate signed-out deep links after onboarding

When a user opens a real report/workspace/invite deep link while signed out and then completes onboarding, the onboarding subscription first observes hasCompletedGuidedSetupFlow: false and this new guard later returns before navigateHandler can open the requested route. That suppresses not only the stale post-sign-out URL from #91437 but also valid first-time signup deep links, so new users can be dropped on the default post-onboarding destination instead of the link they opened. The stale URL case needs to be distinguished before queuing the callback rather than treating every pre-onboarding deep link as stale.

Useful? React with 👍 / 👎.

Comment thread src/libs/actions/Link.ts Outdated
// Drop a non-report deep link captured before the user finished onboarding (#91437).
// Scope this to routes without a reportID: a report deep link self-heals in navigateHandler
// below (it falls back to the last accessed report/Concierge when the report isn't
// accessible), so dropping those would lose a legitimate first-time sign-up link (e.g. an

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow this. Why does a user who needs to complete onboarding need to navigate to the last accessed report? If the user is new, wouldn't the last accessed report also be empty?

Additionally, is the deep link actually processed in this case?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the wordings

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MobileMage It seems you misunderstood my point. I mean, if the user needs to complete onboarding, they will be navigated by navigateAfterOnboarding, right? And in that case, is this deeplink actually handled? If not handled, adding a check for reportID here doesn't make much sense.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmkt9 Just checked myself. I added some logging and went through the flow. The reportID check was guarding a link that doesn't survive onboarding anyway, and navigateAfterOnboarding replaces it. I've dropped the check and gone back to skipping the deep link outright.

@dmkt9

dmkt9 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android.hybrid.mp4
Android: mWeb Chrome
android.chrome.mp4
iOS: HybridApp
ios.native.mp4
iOS: mWeb Safari
ios.safari.mp4
MacOS: Chrome / Safari
mac.safari.mp4

@dmkt9

dmkt9 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@MobileMage Sorry for the delay. Could you merge the latest main branch into this PR to ensure that none of our changes cause any CI failures?

@MobileMage

Copy link
Copy Markdown
Contributor Author

@dmkt9 Done

@dmkt9 dmkt9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MobileMage Thanks. LGTM

@melvin-bot
melvin-bot Bot requested a review from carlosmiceli June 25, 2026 02:22
@carlosmiceli
carlosmiceli merged commit f289caf into Expensify:main Jun 25, 2026
34 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 25, 2026
60 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.20-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required.

I reviewed the changes in this PR against the help site files under App/docs/articles. No documentation updates are needed, so I did not open a draft docs PR.

Why: This is an internal bug fix for a transient UI flash — after sign-out → sign-in → onboarding, the "Hmm... it's not here" page briefly flashed because react-native-web caches a stale Linking.getInitialURL(). The fix guards DeepLinkHandler against re-queuing the stale openReportFromDeepLink call. It changes only internal behavior (src/DeepLinkHandler.tsx, src/libs/actions/Link.ts) and introduces:

  • No new or changed user-facing feature, workflow, or page
  • No new/renamed settings, tabs, buttons, or labels
  • No change to any behavior currently documented on the help site

A search of App/docs/articles for the affected concepts (deep links, the "not here" page, onboarding navigation) surfaced nothing that describes this behavior, so there is nothing to update.

If you believe a specific article should be updated, reply with the article and the behavior to document and I'll take another pass.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants