Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e17bd10545
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@situchan, I've addressed all the feedback. all yours—thanks! |
|
@situchan, friendly bump. thanks. |
|
@situchan, kindly bump, thanks |
|
@situchan can you please review/help move this along |
|
@nabi-ebrahimi please pull main |
|
@nabi-ebrahimi bump! |
|
Lots of tests failing |
|
@situchan, I addressed the actionable items: The remaining points look intentional/non-blocking for this first slice, especially the web/native FullStory property format difference. |
|
@situchan, Gentle bump. thanks. |
|
I am still not seeing my accounts in FS dashboard. Isn't fullstory supposed to be enabled in adhoc build? @nabi-ebrahimi can you share your test emails so I can see if they're shown in dashboard? Also test adhoc builds. |
|
App/src/libs/Fullstory/common.ts Lines 71 to 78 in 9810961 Looks like Fullstory is enabled only in production or when email has |
@situchan Thanks for checking. As I mentioned earlier, I don’t have a FullStory-enabled QA account, so I’m not able to verify this directly in the FullStory dashboard from my side. I tested what I could locally via console logs based on your earlier suggestion: |
|
@nabi-ebrahimi please check this last feedback from AI: 🔴 Cross-platform bug — free-trial date fails to parse on Safari/iOS/Android
On every platform except Chrome, Critically, the tests don't catch this: Fix: use the codebase's established safe parser — 🟡 previousFullstoryPath is a module global, never reset across sessions
RecommendationOne blocker: the date-parsing bug (🔴) — it silently breaks the free-trial metrics on Safari, iOS, and Android (i.e. everywhere but Chrome), and current tests give false confidence. Switch to |
|
@situchan Addressed both points. Please take another look when you get a chance. Thanks! |
@JS00001 I think we can merge this as-is and observe logs when this PR reaches production |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a7d0f4238
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@JS00001, Addressed the latest feedback, all yours. Thanks! |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.43-0 🚀
|
|
🤖 Help site review — no changes required I reviewed the changes in this PR against the help site articles under Conclusion: No help site updates are needed, so I have not created a draft PR. Why: These changes are purely internal analytics instrumentation for FullStory:
None of this introduces or changes any user-facing feature, UI, setting, button, or copy. FullStory instrumentation runs behind the scenes for session analytics and is invisible to customers, so there is nothing to document on the public help site. The only strings touched (e.g. @nabi-ebrahimi, there is no linked help site PR since no documentation changes were required. If you believe a customer-facing aspect of this work does warrant a help site update, let me know the specifics and I'll draft one. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.43-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
These changes add the first part of the FullStory instrumentation requested in this issue.
Previously, the app initialized FullStory but did not sync the requested user/workspace/onboarding context or emit an explicit
Page_viewedevent. Now, a renderlessuseOnyx-based handler derives and syncs FullStory user vars throughFS.setUserVars(...), and navigation changes emit aPage_viewedevent.Fixed Issues
$ #92006
PROPOSAL: #92006 (Comment)
Tests
Offline tests
N/A
QA Steps
N/A
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari