Migrate InteractionManager - batch 3 part 3 by mrejdak · Pull Request #94040 · Expensify/App

mrejdak · 2026-06-19T11:54:52Z

Explanation of Change

Part 3 of batch 3 of InteractionManager migration.

Fixed Issues

$ #83064
$ #71913
PROPOSAL:

Tests

ReceiptView/index.tsx (mobile)

Press on the FAB and select "Create expense"
In the "Scan" tab select the multi-scan feature
Take a few photos (2-3 are enough)
Open a preview of one of the taken photos
Delete it and verify that the 'not found' page is not shown briefly

IOURequestStepDestination.tsx

Create a new workspace and open its Overview tab
Change the workspace type to "Control"
Create two more "Control" type workspaces (so 3 in total)
Enable the Per diem feature in all of the 3 workspaces
In two of them set the Per diem rates, the remaining one should not have any rates set
Press FAB and select "Create expense"
Choose the Per diem tab and select the workspace without rates set
Press the Edit per diem rates button
Verify that the app navigates correctly to the Per diem tab in that workspace

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ReceiptView/index.tsx

batch3v3_multi_scan.mov

Android: mWeb Chrome

iOS: Native

IOURequestStepDestination.tsx

batch3v3_per_diem_mobile.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

IOURequestStepDestination.tsx

batch3v3_per_diem.mov

github-actions · 2026-06-19T11:55:03Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-06-19T12:00:36Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../pages/iou/request/step/IOURequestStepCategory.tsx	`0.00% <ø> (ø)`
...ges/iou/request/step/IOURequestStepDestination.tsx	`2.40% <ø> (ø)`
src/pages/iou/SplitExpensePage.tsx	`0.00% <0.00%> (ø)`
...uest/step/IOURequestStepScan/ReceiptView/index.tsx	`0.00% <0.00%> (ø)`
... and 155 files with indirect coverage changes

mrejdak · 2026-06-19T13:20:52Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

No native changes - unmerged main caused a diff in some native files

war-in · 2026-06-19T13:37:18Z

-                                            ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute(
-                                                policyID,
-                                                ROUTES.MONEY_REQUEST_STEP_CATEGORY.getRoute(action, iouType, transactionID, report.reportID, backTo, reportActionID),
+                                    TransitionTracker.runAfterTransitions({


What kind of transition happens that we need to wait for it? Won't calling Navigation.navigate be enough?

We need to defer it so that when enablePolicyCategories(...) is called first, the optimistic onyx merge can propagate first. Otherwise the navigation redirects to workspace settings, since it doesn't see that workspace categories feature is enabled yet. I also think requestAnimationFrame is a better fit in this case, so I'll modify that.

melvin-bot · 2026-06-22T09:57:21Z

@Pujan92 @ikevin127 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18f9072116

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Pujan92 · 2026-06-22T11:47:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-22.at.20.16.18.mov

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-22.at.20.17.06.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-22.at.20.19.59.mov

Pujan92 · 2026-06-22T13:19:13Z

@mrejdak ~~I think this isn't for perdiem flow which you mentioned in the test steps, could you plz check and update with the correct steps?~~

Oops, my bad.

Pujan92

LGTM!

joekaufmanexpensify · 2026-06-22T21:29:39Z

No product review needed

Pujan92 · 2026-06-23T11:00:33Z

Though it is not from this PR and exists on staging/prod, I found a bug related to the back navigation on the workspace page for the per diem flow. It looks like it's because we're preserving the backTo parameter with a value of non-workspace page here. It gets stuck in the navigation loop

cc: @WojtekBoman @sumo-slonik

Screen.Recording.2026-06-23.at.15.36.31.mov

mrejdak · 2026-06-25T12:31:20Z

@roryabraham I think we can merge this, as the issue is not related to the changes from this PR, so no need to wait for it.

I'm OOO starting tomorrow, so @collectioneur will take care of this PR from now on, if anything comes up

github-actions · 2026-06-25T20:57:00Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-25T21:02:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-25T21:03:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94040.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3a6e8f3b532-f7f8a31-41efedb1e138ca2fde2a7463b4b0360519e67014/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3a6e8f3-f7f8a31-af0cb6a741276b4c9c606ad8ee6cef64a8029fed/index.html

Web 🕸️
https://94040.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-25T21:51:33Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.20-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-06-25T21:54:18Z

🤖 Help site review: no changes required.

This PR is part 3 of batch 3 of the InteractionManager migration — a purely internal refactor. The changes swap InteractionManager.runAfterInteractions(...) for equivalent scheduling primitives (KeyboardUtils.dismiss({afterTransition}), requestAnimationFrame, Navigation.goBack(..., {afterTransition})) across four IOU/scan files:

src/pages/iou/SplitExpensePage.tsx
src/pages/iou/request/step/IOURequestStepCategory.tsx
src/pages/iou/request/step/IOURequestStepDestination.tsx
src/pages/iou/request/step/IOURequestStepScan/ReceiptView/index.tsx

These only affect the timing/implementation of keyboard dismissal and navigation transitions. There are no new features, UI labels, button text, settings, or user-facing behavior changes. Nothing in the public help site under App/docs/articles documents this internal scheduling mechanism, so no draft docs PR was created.

OSBotify · 2026-06-26T19:23:27Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

mrejdak added 3 commits June 12, 2026 15:16

Merge branch 'main' into mrejdak/migrate-interactionmanager-b3_v3

724b0d7

multiscan

bc61511

remaining cases

bd332be

melvin-bot Bot assigned mrejdak Jun 19, 2026

Merge branch 'main' into mrejdak/migrate-interactionmanager-b3_v3

f35df31

war-in approved these changes Jun 19, 2026

View reviewed changes

mrejdak added 2 commits June 22, 2026 11:05

update to rAF

66c3fd1

cleanup

18f9072

mrejdak marked this pull request as ready for review June 22, 2026 09:57

mrejdak requested review from a team as code owners June 22, 2026 09:57

melvin-bot Bot requested review from Pujan92, ikevin127 and joekaufmanexpensify and removed request for a team June 22, 2026 09:57

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepScan/ReceiptView/index.tsx Resolved

Pujan92 approved these changes Jun 22, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham June 22, 2026 14:51

joekaufmanexpensify removed their request for review June 22, 2026 21:29

roryabraham approved these changes Jun 25, 2026

View reviewed changes

roryabraham merged commit 3a6e8f3 into Expensify:main Jun 25, 2026
36 of 38 checks passed

OSBotify mentioned this pull request Jun 25, 2026

Deploy Checklist: New Expensify 2026-06-25 #94631

Closed

60 tasks done

This was referenced Jun 26, 2026

[Due for payment 2026-07-03] [Due for payment 2026-06-24] [Due for payment 2026-06-19] [BATCH 3] Migrate Navigation usage v2 #83064

Closed

[Due for payment 2026-08-31] [Partial Payment x 3][Tracking] Deprecation of InteractionManager #71913

Closed

Conversation

mrejdak commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jun 19, 2026

Uh oh!

codecov Bot commented Jun 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mrejdak commented Jun 19, 2026

Uh oh!

war-in Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

mrejdak Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Pujan92 commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Jun 22, 2026

Uh oh!

Pujan92 commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrejdak commented Jun 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

OSBotify commented Jun 25, 2026

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

OSBotify commented Jun 25, 2026

Uh oh!

MelvinBot commented Jun 25, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mrejdak commented Jun 19, 2026 •

edited

Loading

codecov Bot commented Jun 19, 2026 •

edited by github-actions Bot

Loading

mrejdak Jun 22, 2026 •

edited

Loading

Pujan92 commented Jun 22, 2026 •

edited

Loading

Pujan92 commented Jun 22, 2026 •

edited

Loading

Pujan92 commented Jun 23, 2026 •

edited

Loading