Skip to content

[No QA] Docs updates for E/A#93063 Add currency selection to card rules - #94066

Merged
lschurr merged 4 commits into
mainfrom
melvin-docs-card-rules-currency
Jul 16, 2026
Merged

lschurr merged 4 commits into
mainfrom
melvin-docs-card-rules-currency

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Why this PR

This updates the help site to match the changes from #93063, which restructured the Expensify Card Spend rules UI:

  • Restriction type (Allow / Block) is replaced by Restrict merchants with three options: Off, Allow, and Block.
  • A new Permitted currencies setting was added (default All currencies, with the option to select specific currencies). The card's settlement currency is always permitted, and selecting specific currencies (or a max amount) requires the selected cards to settle in the same currency.
  • Spend category is now surfaced as merchant types — Allowed merchant types / Blocked merchant types — alongside Allowed merchants / Blocked merchants.
  • The section is now titled Spend rules, and the save action is Save rule.

What changed

Updated docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md:

  • Reworked the configuration section into What you can configure in an Expensify Card Spend rule, documenting Permitted currencies, Max amount, and the Restrict merchants Off/Allow/Block options.
  • Updated the create, edit/delete, and issue-a-card steps to match the new UI and exact labels (Choose cards, Add spend rule, Save rule, Delete rule).
  • Updated the intro, metadata (description/keywords/internalScope), and FAQ (added a same-settlement-currency FAQ; removed the outdated "uses either Allow or Block" wording).

All UI labels were taken verbatim from src/languages/en.ts in the linked PR.

Source

Help site changes for #93063.


@JS00001, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

…estrict merchants

Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 19, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review July 1, 2026 20:09
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 1, 2026 20:09
@stephanieelliott stephanieelliott added HOLD and removed HOLD labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md to match the restructured Expensify Card Spend rules UI from E/A#93063 (Permitted currencies, Max amount, the Restrict merchants Off/Allow/Block model, and merchant types). The changes are accurate, well-scoped to a single workflow, and pull UI labels verbatim from the source. Overall quality is high and the diff is very close to fully compliant with the governance files.

Scores Summary

  • Readability: 8/10 - Prose is clear, steps are sequential and action-oriented, and the Off/Allow/Block options are parallel and scannable. The three Restrict merchants bullets repeat the "Charges are approved for permitted currencies that don't exceed a max amount" clause verbatim, which is slightly dense; light rewording would improve scannability.
  • AI Readiness: 9/10 - description, keywords, and internalScope were all updated to reflect permitted currencies, max amount, and merchant types, aligning well with real search intent. Only # and ## headings are used, headings remain task-based (e.g. "What you can configure in an Expensify Card Spend rule"), and full feature names are used throughout.
  • Style Compliance: 9/10 - UI labels are bolded and match the source PR exactly (Choose cards, Add spend rule, Save rule, Delete rule, Restrict merchants, Permitted currencies, All currencies, Off/Allow/Block). Navigation phrasing follows the unified web/mobile convention, and the outdated Restriction type / Allow-Block wording and grammar issues ("takes"/"take") were correctly fixed.

Key Findings

  • Strong, accurate mapping of the new UI: the Off/Allow/Block model and the currency/max-amount settlement constraint are documented clearly, including a well-targeted new FAQ ("Can I set a max amount or specific currencies for cards that settle in different currencies?").
  • Metadata is a highlight - it now surfaces the new concepts, improving AI retrievability.
  • Minor inconsistency (outside the diff, but worth a cleanup pass): the file still mixes "Spend Rule" and "Spend rule" casing in unchanged lines. Since this PR touches label casing, aligning to a single form would strengthen consistency.
  • The heading "What you can configure in an Expensify Card Spend rule" is acceptable as a "What..." task-based heading; no change required.

Recommendations

  • Trim the repeated "permitted currencies that don't exceed a max amount" clause in the three Restrict merchants bullets so each option reads more distinctly.
  • Optional: normalize remaining "Spend Rule" vs "Spend rule" casing across the article for consistency with the corrected labels.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md - Accurate, compliant update; minor readability/casing polish suggested.

Note: This is a single top-level summary review.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4aa8329c6e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#93063 Add currency selection to card rules [No QA] Docs updates for E/A#93063 Add currency selection to card rules Jul 6, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott requested a review from a team July 16, 2026 05:03
@melvin-bot

melvin-bot Bot commented Jul 16, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lschurr

@melvin-bot
melvin-bot Bot requested a review from lschurr July 16, 2026 05:03
@melvin-bot

melvin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

@lschurr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 16, 2026 05:03
@OSBotify

This comment has been minimized.

description: Learn how Workspace Admins use Expensify Card Spend rules to approve or decline card transactions in real time, including Allow and Block restriction types, default protections, and rule management.
keywords: [New Expensify, Expensify Card Spend rule, block card transactions, allow list, decline transaction, merchant restrictions, spend category, permitted currencies, currency restrictions, default protections, Workspace Admin]
internalScope: Audience is Workspace Admins. Covers creating and managing Expensify Card Spend rules and understanding default protections. Does not cover post-submission expense rules, card limits, or cardholder-side card management.
description: Learn how Workspace Admins use Expensify Card Spend rules to approve or decline card transactions in real time, including permitted currencies, max amount, the Restrict merchants Off, Allow, and Block options, default protections, and rule management.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

including permitted currencies, max amount, the Restrict merchants Off, Allow, and Block options, default protections, and rule management.

This sentence is really confusing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call — reworded to a plain summary sentence:

Learn how Workspace Admins use Expensify Card Spend rules to approve or decline card transactions in real time based on currency, amount, and merchant.

Dropped the "Off/Allow/Block/default protections/rule management" pile-up; the body already covers those in detail.

Spend rules takes effect immediately and are applied to future transactions on the selected cards.
Spend rules take effect immediately and are applied to future transactions on the selected cards.

<!-- SCREENSHOT:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a <!-- SCREENSHOT: --> placeholder marker (it doesn't render on the published page) — it flags a good spot for a screenshot of the Spend rules config screen with Permitted currencies, Max amount, and the Restrict merchants Off/Allow/Block toggle. I can't capture product screenshots myself, so I left the marker in place for a Concierge reviewer to drop in an actual image during review. Happy to remove the marker instead if you'd rather not include a screenshot here.

Separately, I noticed the create-rule steps just above had a leftover duplicate — an orphaned Permitted currencies bullet and a second Click Save after Click Save rule. I removed both so the steps now end cleanly at 6. Click Save rule.

…cate step, normalize Spend rule casing

Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Addressed the review feedback and pushed to melvin-docs-card-rules-currency (5651c17):

  • Confusing description (JS00001) — reworded to a plain summary: "…approve or decline card transactions in real time based on currency, amount, and merchant."
  • <!-- SCREENSHOT --> "should we add this?" (JS00001) — that's a non-rendering placeholder marker; left it for a Concierge reviewer to add an actual screenshot (I can't capture product screenshots). While there, I removed a leftover duplicate step in the create-rule flow (orphaned Permitted currencies bullet + a second Click Save after Click Save rule).
  • Block approval wording was backwards (codex bot, P2) — old text implied matching a blocked merchant approved the charge; rewrote the three Restrict merchants options so Block correctly declines matched merchants/types, and trimmed the repeated currency/max-amount clause.
  • "Spend Rule" vs "Spend rule" casing (bot) — normalized prose and section/FAQ headings to "Spend rule"; kept the article title and H1 as the formal "Expensify Card Spend Rules".

Replied inline on each thread. JS00001, let me know if you'd rather I drop the screenshot marker entirely.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://1dfec2c7.helpdot.pages.dev ⚡️

Updated articles:

@lschurr
lschurr merged commit 6e31793 into main Jul 16, 2026
20 checks passed
@lschurr
lschurr deleted the melvin-docs-card-rules-currency branch July 16, 2026 23:01
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lschurr in version: 9.4.36-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify OSBotify mentioned this pull request Jul 17, 2026
53 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lschurr in version: 9.4.38-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lschurr in version: 9.4.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants