Repository navigation
[No QA] Docs updates for E/A#93063 Add currency selection to card rules - #94066
Conversation
…estrict merchants Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
HelpDot Documentation ReviewOverall AssessmentThis PR updates docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md to match the restructured Expensify Card Spend rules UI from E/A#93063 (Permitted currencies, Max amount, the Restrict merchants Off/Allow/Block model, and merchant types). The changes are accurate, well-scoped to a single workflow, and pull UI labels verbatim from the source. Overall quality is high and the diff is very close to fully compliant with the governance files. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a single top-level summary review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4aa8329c6e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
This comment has been minimized.
This comment has been minimized.
| description: Learn how Workspace Admins use Expensify Card Spend rules to approve or decline card transactions in real time, including Allow and Block restriction types, default protections, and rule management. | ||
| keywords: [New Expensify, Expensify Card Spend rule, block card transactions, allow list, decline transaction, merchant restrictions, spend category, permitted currencies, currency restrictions, default protections, Workspace Admin] | ||
| internalScope: Audience is Workspace Admins. Covers creating and managing Expensify Card Spend rules and understanding default protections. Does not cover post-submission expense rules, card limits, or cardholder-side card management. | ||
| description: Learn how Workspace Admins use Expensify Card Spend rules to approve or decline card transactions in real time, including permitted currencies, max amount, the Restrict merchants Off, Allow, and Block options, default protections, and rule management. |
There was a problem hiding this comment.
including permitted currencies, max amount, the Restrict merchants Off, Allow, and Block options, default protections, and rule management.
This sentence is really confusing
There was a problem hiding this comment.
Good call — reworded to a plain summary sentence:
Learn how Workspace Admins use Expensify Card Spend rules to approve or decline card transactions in real time based on currency, amount, and merchant.
Dropped the "Off/Allow/Block/default protections/rule management" pile-up; the body already covers those in detail.
| Spend rules takes effect immediately and are applied to future transactions on the selected cards. | ||
| Spend rules take effect immediately and are applied to future transactions on the selected cards. | ||
|
|
||
| <!-- SCREENSHOT: |
There was a problem hiding this comment.
That's a <!-- SCREENSHOT: --> placeholder marker (it doesn't render on the published page) — it flags a good spot for a screenshot of the Spend rules config screen with Permitted currencies, Max amount, and the Restrict merchants Off/Allow/Block toggle. I can't capture product screenshots myself, so I left the marker in place for a Concierge reviewer to drop in an actual image during review. Happy to remove the marker instead if you'd rather not include a screenshot here.
Separately, I noticed the create-rule steps just above had a leftover duplicate — an orphaned Permitted currencies bullet and a second Click Save after Click Save rule. I removed both so the steps now end cleanly at 6. Click Save rule.
…cate step, normalize Spend rule casing Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
|
🤖 Addressed the review feedback and pushed to
Replied inline on each thread. |
|
A preview of your ExpensifyHelp changes have been deployed to https://1dfec2c7.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/lschurr in version: 9.4.36-2 🚀
|
|
🚀 Deployed to staging by https://github.com/lschurr in version: 9.4.38-0 🚀
|
|
🚀 Deployed to staging by https://github.com/lschurr in version: 9.4.40-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.40-0 🚀
Bundle Size Analysis (Sentry): |
Why this PR
This updates the help site to match the changes from #93063, which restructured the Expensify Card Spend rules UI:
What changed
Updated
docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md:description/keywords/internalScope), and FAQ (added a same-settlement-currency FAQ; removed the outdated "uses either Allow or Block" wording).All UI labels were taken verbatim from
src/languages/en.tsin the linked PR.Source
Help site changes for #93063.
@JS00001, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.