Repository navigation
[Payment due @daledah] Add receipt-type filter on the Search (Spend) page #94129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JS00001
merged 20 commits into
Expensify:main
from
allgandalf:search-receipt-type-filter
Jun 26, 2026
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
cecf886
Add receipt-type search filter constants and screen
allgandalf 9f4c165
Add receipt-type advanced filter form types
allgandalf 65b0b4a
Parse receipt-type in the search grammar
allgandalf b375cc1
Register the receipt-type filter page route
allgandalf 34ec00a
Add the receipt-type filter page
allgandalf 5848633
Render receipt-type in the advanced filter components
allgandalf d817c1f
Show receipt-type in search filter display and options
allgandalf 791c2ff
Build and parse receipt-type query filter values
allgandalf 191362d
Add receipt-type translation key helper
allgandalf ccad8b8
Add receipt-type to advanced search filter hooks
allgandalf 96c19b7
Add receipt-type filter translations
allgandalf 8dbce6a
Test the receipt-type search filter
allgandalf 46f3fb7
Merge branch 'Expensify:main' into search-receipt-type-filter
allgandalf 6b12640
Remove redundant manual memoization in receipt type page
allgandalf de91640
Clear conflicting negated receipt types on positive selection
allgandalf 9ad7564
Merge branch 'Expensify:main' into search-receipt-type-filter
allgandalf 57c0ec6
Merge branch 'Expensify:main' into search-receipt-type-filter
allgandalf b29c110
Hoist receipt type lookup to a Set in the receipt type page
allgandalf 1c31e9a
Clear conflicting negated receipt types on the generic filter picker …
allgandalf 4ee6fda
Merge branch 'Expensify:main' into search-receipt-type-filter
allgandalf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fresh evidence after the follow-up fix:
SearchAdvancedFiltersBasestill routes every filter row throughROUTES.SEARCH_ADVANCED_FILTERS_CONTENT, so this generic multiselect is the path used from the Filters list, not the dedicated receipt-type page. When the current query contains-receipt-type:hotel, this path only merges{receiptType: ['hotel']}and leaves the existingreceiptTypeNotin the draft filters; applying then serializes both-receiptType:hotelandreceiptType:hotel, making the search unsatisfiable for that selected value.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, the dedicated page isn't the path the Filters list uses. fixed in 1c31e9a, the generic content page (SearchAdvancedFiltersContentBase) now drops the conflicting values from receiptTypeNot when a positive receipt-type selection is applied.