Repository navigation
[Payment due @mkhutornyi] Fix thread RHP not closing when parent message deleted from search pages #94293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
grgia
merged 1 commit into
Expensify:main
from
software-mansion-labs:fix/deleting-reply-in-rhp
Jun 26, 2026
Merged
[Payment due @mkhutornyi] Fix thread RHP not closing when parent message deleted from search pages #94293
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelvinBot Which PR first introduced this logic? Trying to find offending PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
else ifbranch that navigates back when the deleted action'schildReportIDis the active route was first introduced in #58889 ("fix: header shows skeleton, message is empty" bynkdengineer, merged 2025-03-23, fixing #58134).ROUTES.REPORT_WITH_ID.getRoute(reportAction.childReportID)check +goBack(commiteb215dab1aa)goBackargs:goBack(undefined, {shouldPopToTop: true})→goBack(undefined)(commitd2cea8ba7aa)Before that PR the block only had the first
if(navigate back fromREPORT_WITH_ID.getRoute(reportID, reportActionID)), so #58889 is where the child-reportgoBacklogic originated. This PR (#94293) later refactored that same branch to also handle theSEARCH_REPORTroute.Blame evidence
Blame of the pre-#94293 version of
src/libs/actions/Report/index.ts:3157-3158:Both commits merged via #58889.